Re: [PATCH 1/1] hv: Use only one txf buffer per channel and kmalloc on initialize

? -- Evgeniy Polyakov ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization

Re: [PATCH 1/3]: An implementation of HyperV KVP functionality

. -- Evgeniy Polyakov ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization

Re: [PATCH 2/4] Rename the file hv_utils.c

; + u32 buflen, recvlen; + u64 requestid; + struct icmsg_hdr *icmsghdrp; + struct heartbeat_msg_data *heartbeat_msg; + + buflen = PAGE_SIZE; + buf = kmalloc(buflen, GFP_ATOMIC); + + vmbus_recvpacket(channel, buf, buflen, recvlen, requestid); -- Evgeniy Polyakov

Re: [PATCH 2/3]: An implementation of HyperV KVP functionality

since previous review and this is wrong. It is the right way to crash kernel. I did not read further since this is a show-stopper imo. -- Evgeniy Polyakov ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https

Re: [PATCH 2/3]: An Implementation of HyperV KVP functionality

, since this function returns void and thus can not propagate error, which is likely not a good idea. -- Evgeniy Polyakov ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo

Re: [PATCH] AF_VMCHANNEL address family for guest-host communication.

to dynamically allocate them. Looks very good. Especially liked how you used idx.val pairs to register multiple users. Please add some comment in connector header on how you use it and feel free to add my ack if needed. -- Evgeniy Polyakov

Re: [PATCH] AF_VMCHANNEL address family for guest-host communication.

versa. -- Evgeniy Polyakov ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization

Re: [PATCH] AF_VMCHANNEL address family for guest-host communication.

) to replace it with process context, so this at least requires some note in comments. Except that about questions, this patch looks good. -- Evgeniy Polyakov ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https

Re: [PATCH 2/5] /dev/vring: simple userspace-kernel ringbuffer interface.

; + + if (copy_to_user(vr-ring.used-ring[used_idx vr-mask], used, + sizeof(used))) + return; + + wmb(); + used_idx++; + put_user(used_idx, vr-ring.used-idx); +} +EXPORT_SYMBOL_GPL(vring_used_buffer); -- Evgeniy Polyakov

Re: [PATCH 2/5] /dev/vring: simple userspace-kernel ringbuffer interface.

decided that too. But it limits its usage to tun only or any other system where only single thread picks up results, so no generic userspace ring buffers? -- Evgeniy Polyakov ___ Virtualization mailing list Virtualization@lists.linux