Re: [PATCH v2] virtio_pci: Switch away from deprecated irq_set_affinity_hint

2023-10-27 Thread Jakub Sitnicki via Virtualization
On Thu, Oct 26, 2023 at 01:20 PM -04, Michael S. Tsirkin wrote: > On Thu, Oct 26, 2023 at 06:25:08PM +0200, Jakub Sitnicki wrote: >> On Wed, Oct 25, 2023 at 04:53 PM +02, Jakub Sitnicki wrote: >> > Since commit 65c7cdedeb30 ("genirq: Provide new interfaces for affinity >> > hints") irq_set_affinity

Re: [PATCH v2] virtio_pci: Switch away from deprecated irq_set_affinity_hint

2023-10-26 Thread Jakub Sitnicki via Virtualization
On Wed, Oct 25, 2023 at 04:53 PM +02, Jakub Sitnicki wrote: > Since commit 65c7cdedeb30 ("genirq: Provide new interfaces for affinity > hints") irq_set_affinity_hint is being phased out. > > Switch to new interfaces for setting and applying irq affinity hints. > > Signed-off-by: Jakub Sitnicki > -

[PATCH v2] virtio_pci: Switch away from deprecated irq_set_affinity_hint

2023-10-25 Thread Jakub Sitnicki via Virtualization
Since commit 65c7cdedeb30 ("genirq: Provide new interfaces for affinity hints") irq_set_affinity_hint is being phased out. Switch to new interfaces for setting and applying irq affinity hints. Signed-off-by: Jakub Sitnicki --- v2: - Leave cpumask_copy as is. We can't pass pointer to stack memor

Re: [PATCH 1/2] virtio_pci: Don't make an extra copy of cpu affinity mask

2023-10-24 Thread Jakub Sitnicki via Virtualization
On Tue, Oct 24, 2023 at 07:46 PM +08, Xuan Zhuo wrote: > On Tue, 24 Oct 2023 13:26:49 +0200, Jakub Sitnicki > wrote: >> On Tue, Oct 24, 2023 at 06:53 PM +08, Xuan Zhuo wrote: >> > On Tue, 24 Oct 2023 10:17:19 +0200, Jakub Sitnicki >> > wrote: >> >> On Tue, Oct 24, 2023 at 10:31 AM +08, Xuan Zhu

Re: [PATCH 1/2] virtio_pci: Don't make an extra copy of cpu affinity mask

2023-10-24 Thread Jakub Sitnicki via Virtualization
On Tue, Oct 24, 2023 at 06:53 PM +08, Xuan Zhuo wrote: > On Tue, 24 Oct 2023 10:17:19 +0200, Jakub Sitnicki > wrote: >> On Tue, Oct 24, 2023 at 10:31 AM +08, Xuan Zhuo wrote: >> > On Mon, 23 Oct 2023 18:52:45 +0200, Jakub Sitnicki >> > wrote: >> >> On Thu, Oct 19, 2023 at 08:55 PM +08, Xuan Zhu

Re: [PATCH 1/2] virtio_pci: Don't make an extra copy of cpu affinity mask

2023-10-24 Thread Jakub Sitnicki via Virtualization
On Tue, Oct 24, 2023 at 10:31 AM +08, Xuan Zhuo wrote: > On Mon, 23 Oct 2023 18:52:45 +0200, Jakub Sitnicki > wrote: >> On Thu, Oct 19, 2023 at 08:55 PM +08, Xuan Zhuo wrote: >> > On Thu, 19 Oct 2023 12:16:24 +0200, Jakub Sitnicki >> > wrote: >> >> Since commit 19e226e8cc5d ("virtio: Make vp_se

Re: [PATCH 1/2] virtio_pci: Don't make an extra copy of cpu affinity mask

2023-10-23 Thread Jakub Sitnicki via Virtualization
On Thu, Oct 19, 2023 at 08:55 PM +08, Xuan Zhuo wrote: > On Thu, 19 Oct 2023 12:16:24 +0200, Jakub Sitnicki > wrote: >> Since commit 19e226e8cc5d ("virtio: Make vp_set_vq_affinity() take a >> mask.") it is actually not needed to have a local copy of the cpu mask. > > > Could you give more info to

[PATCH 2/2] virtio_pci: Switch away from deprecated irq_set_affinity_hint

2023-10-19 Thread Jakub Sitnicki via Virtualization
Since commit 65c7cdedeb30 ("genirq: Provide new interfaces for affinity hints") irq_set_affinity_hint is being phased out. Switch to new interfaces for setting and applying irq affinity hints. Signed-off-by: Jakub Sitnicki --- drivers/virtio/virtio_pci_common.c | 4 ++-- 1 file changed, 2 inser

[PATCH 1/2] virtio_pci: Don't make an extra copy of cpu affinity mask

2023-10-19 Thread Jakub Sitnicki via Virtualization
Since commit 19e226e8cc5d ("virtio: Make vp_set_vq_affinity() take a mask.") it is actually not needed to have a local copy of the cpu mask. Pass the cpu mask we got as argument to set the irq affinity hint. Cc: Caleb Raitto Signed-off-by: Jakub Sitnicki --- drivers/virtio/virtio_pci_common.c

Re: [PATCH 2/2] virtio-mmio: Support multiple interrupts per device

2023-10-14 Thread Jakub Sitnicki via Virtualization
Sorry for the delay in my response. I've been away at a conference. On Tue, Oct 10, 2023 at 02:52 PM +08, Jason Wang wrote: > On Sat, Sep 30, 2023 at 4:46 AM Jakub Sitnicki wrote: >> >> Some virtual devices, such as the virtio network device, can use multiple >> virtqueues (or multiple pairs of v