Re: [BUG] virtio-net linux driver fails to probe on MIPS Malta since 'hw/virtio-pci: fix virtio behaviour'

2017-03-27 Thread James Hogan
Hi Marcel, On Tue, Mar 21, 2017 at 04:16:58PM +0200, Marcel Apfelbaum wrote: > Can you please check if the below patch fixes the problem? > Please note it is not a solution. > > diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c > index f9b7244..5b4d429 100644 > --- a/hw/virtio/virtio-p

[BUG] virtio-net linux driver fails to probe on MIPS Malta since 'hw/virtio-pci: fix virtio behaviour'

2017-03-17 Thread James Hogan
Hi, I've bisected the following failure of the virtio_net linux v4.10 driver to probe in QEMU v2.9.0-rc1 emulating a MIPS Malta machine: virtio_net virtio0: virtio: device uses modern interface but does not have VIRTIO_F_VERSION_1 virtio_net: probe of virtio0 failed with error -22 To QEMU commi

Re: [PATCH v2 20/32] metag: define __smp_xxx

2016-01-04 Thread James Hogan
ces, but it'd be nice if the definitions at least still all lined up. You're touching all the definitions which use spaces anyway, so feel free to convert them to tabs while you're at it. Other than those niggles, it looks sensible to me: Acked-by: James Hogan Cheers James &

Re: [PATCH v2 10/32] metag: reuse asm-generic/barrier.h

2016-01-04 Thread James Hogan
asm-generic/barrier.h instead. > > This is in preparation to refactoring this code area. > > Signed-off-by: Michael S. Tsirkin > Acked-by: Arnd Bergmann Looks good, and confirmed no text change (once patch 1 is applied that is). Acked-by: James Hogan Thanks James > --- >

Re: [PATCH v2 20/32] metag: define __smp_xxx

2016-01-04 Thread James Hogan
On Mon, Jan 04, 2016 at 04:30:36PM +0100, Peter Zijlstra wrote: > On Mon, Jan 04, 2016 at 03:25:58PM +0000, James Hogan wrote: > > It is used along with the metag specific __global_lock1() (global > > voluntary lock between hw threads) whenever a write is performed, and by > &

Re: [PATCH v2 20/32] metag: define __smp_xxx

2016-01-04 Thread James Hogan
Hi Peter, On Mon, Jan 04, 2016 at 02:41:28PM +0100, Peter Zijlstra wrote: > On Thu, Dec 31, 2015 at 09:08:22PM +0200, Michael S. Tsirkin wrote: > > +#ifdef CONFIG_SMP > > +#define fence() metag_fence() > > +#else > > +#define fence()do { } while (0) > > #endif > > James, it strikes m