Re: [PATCH] fuse: avoid unnecessary spinlock bump

2022-04-12 Thread JeffleXu
On 4/11/22 10:00 PM, Vivek Goyal wrote: > On Mon, Apr 11, 2022 at 03:20:05PM +0200, Bernd Schubert wrote: > > So for testing DAX, I have to rely on out of tree patches from qemu > here if any changes in virtiofs client happen. > > https://gitlab.com/virtio-fs/qemu/-/tree/virtio-fs-dev > >

Re: [PATCH] fuse: avoid unnecessary spinlock bump

2022-04-11 Thread JeffleXu
On 4/11/22 7:52 PM, Vivek Goyal wrote: > On Mon, Apr 11, 2022 at 10:10:23AM +0800, JeffleXu wrote: >> >> >> On 4/8/22 8:06 PM, Vivek Goyal wrote: >>> On Fri, Apr 08, 2022 at 07:50:55PM +0800, JeffleXu wrote: >>>> >>>> >>>> On 4

Re: [PATCH] fuse: avoid unnecessary spinlock bump

2022-04-10 Thread JeffleXu
On 4/8/22 8:06 PM, Vivek Goyal wrote: > On Fri, Apr 08, 2022 at 07:50:55PM +0800, JeffleXu wrote: >> >> >> On 4/8/22 7:25 PM, Vivek Goyal wrote: >>> On Fri, Apr 08, 2022 at 10:36:40AM +0800, JeffleXu wrote: >>>> >>>> >>>> On 4/

Re: [PATCH] fuse: avoid unnecessary spinlock bump

2022-04-08 Thread JeffleXu
On 4/8/22 7:25 PM, Vivek Goyal wrote: > On Fri, Apr 08, 2022 at 10:36:40AM +0800, JeffleXu wrote: >> >> >> On 4/7/22 10:10 PM, Vivek Goyal wrote: >>> On Sat, Apr 02, 2022 at 06:32:50PM +0800, Jeffle Xu wrote: >>>> Move dmap free worker kicker

Re: [PATCH] fuse: avoid unnecessary spinlock bump

2022-04-07 Thread JeffleXu
On 4/7/22 10:10 PM, Vivek Goyal wrote: > On Sat, Apr 02, 2022 at 06:32:50PM +0800, Jeffle Xu wrote: >> Move dmap free worker kicker inside the critical region, so that extra >> spinlock lock/unlock could be avoided. >> >> Suggested-by: Liu Jiang >> Signed-off-by: Jeffle Xu > > Looks good to

Re: [Virtio-fs] [PATCH v4 0/8] fuse,virtiofs: support per-file DAX

2021-09-22 Thread JeffleXu
Thanks for the replying and suggesting. ;) On 9/20/21 3:45 AM, Vivek Goyal wrote: > On Thu, Sep 16, 2021 at 04:21:59PM +0800, JeffleXu wrote: >> Hi, I add some performance statistics below. >> >> >> On 8/17/21 8:40 PM, Vivek Goyal wrote: >>> On Tue, Aug 17,

Re: [Virtio-fs] [PATCH v4 0/8] fuse,virtiofs: support per-file DAX

2021-09-17 Thread JeffleXu
Hi Vivek, Miklos, On 9/16/21 4:21 PM, JeffleXu wrote: > Hi, I add some performance statistics below. > > > On 8/17/21 8:40 PM, Vivek Goyal wrote: >> On Tue, Aug 17, 2021 at 10:32:14AM +0100, Dr. David Alan Gilbert wrote: >>> * Miklos Szeredi (mik...@szeredi.hu) wrot

Re: [Virtio-fs] [PATCH v4 0/8] fuse,virtiofs: support per-file DAX

2021-09-16 Thread JeffleXu
Hi, I add some performance statistics below. On 8/17/21 8:40 PM, Vivek Goyal wrote: > On Tue, Aug 17, 2021 at 10:32:14AM +0100, Dr. David Alan Gilbert wrote: >> * Miklos Szeredi (mik...@szeredi.hu) wrote: >>> On Tue, 17 Aug 2021 at 04:22, Jeffle Xu wrote: This patchset adds support of

Re: [Virtio-fs] [virtiofsd PATCH v4 4/4] virtiofsd: support per-file DAX in FUSE_LOOKUP

2021-09-08 Thread JeffleXu
On 8/24/21 6:15 PM, Greg Kurz wrote: > On Fri, 20 Aug 2021 13:03:23 +0800 > JeffleXu wrote: >> >> Fine. Got it. However the returned fd (opened without O_PATH) is only >> used for FS_IOC_GETFLAGS/FS_IOC_FSGETXATTR ioctl, while in most cases >> for special device

Re: [PATCH 1/2] fuse: disable atomic_o_trunc if no_open is enabled

2021-09-08 Thread JeffleXu
On 9/7/21 4:34 PM, Miklos Szeredi wrote: > On Thu, 12 Aug 2021 at 07:46, Jeffle Xu wrote: >> >> From: Liu Bo >> >> When 'no_open' is used by virtiofsd, guest kernel won't send OPEN request >> any more. However, with atomic_o_trunc, SETATTR request is also omitted in >> OPEN(O_TRUNC) so that

Re: [PATCH 0/2] virtiofs: miscellaneous fixes

2021-09-06 Thread JeffleXu
ping ... On 8/12/21 1:46 PM, Jeffle Xu wrote: > Some fixes or optimization for virtiofs, which are authored by Liu Bo. > > Liu Bo (2): > virtio-fs: disable atomic_o_trunc if no_open is enabled > virtiofs: reduce lock contention on fpq->lock > > fs/fuse/file.c | 11 +-- >

Re: [PATCH v4 0/8] fuse,virtiofs: support per-file DAX

2021-09-02 Thread JeffleXu
On 8/17/21 10:08 PM, Miklos Szeredi wrote: > On Tue, 17 Aug 2021 at 15:22, JeffleXu wrote: >> >> >> >> On 8/17/21 8:39 PM, Vivek Goyal wrote: >>> On Tue, Aug 17, 2021 at 10:06:53AM +0200, Miklos Szeredi wrote: >>>> On Tue, 17 Aug 2021 at 04:22,

Re: [Virtio-fs] [virtiofsd PATCH v4 4/4] virtiofsd: support per-file DAX in FUSE_LOOKUP

2021-08-19 Thread JeffleXu
On 8/19/21 9:08 PM, Dr. David Alan Gilbert wrote: > * JeffleXu (jeffl...@linux.alibaba.com) wrote: >> >> >> On 8/18/21 3:00 AM, Dr. David Alan Gilbert wrote: >>> * Jeffle Xu (jeffl...@linux.alibaba.com) wrote: >>>> For passthrough, when the

Re: [Virtio-fs] [PATCH v4 0/8] fuse,virtiofs: support per-file DAX

2021-08-19 Thread JeffleXu
On 8/17/21 10:54 PM, Vivek Goyal wrote: [...] >> >> As for virtiofs, Dr. David Alan Gilbert has mentioned that various files >> may compete for limited DAX window resource. >> >> Besides, supporting DAX for small files can be expensive. Small files >> can consume DAX window resource rapidly,

Re: [Virtio-fs] [virtiofsd PATCH v4 4/4] virtiofsd: support per-file DAX in FUSE_LOOKUP

2021-08-17 Thread JeffleXu
On 8/18/21 3:00 AM, Dr. David Alan Gilbert wrote: > * Jeffle Xu (jeffl...@linux.alibaba.com) wrote: >> For passthrough, when the corresponding virtiofs in guest is mounted >> with '-o dax=inode', advertise that the file is capable of per-file >> DAX if the inode in the backend fs is marked with

Re: [Virtio-fs] [virtiofsd PATCH v4 3/4] virtiofsd: support per-file DAX negotiation in FUSE_INIT

2021-08-17 Thread JeffleXu
On 8/18/21 1:15 AM, Dr. David Alan Gilbert wrote: > * Jeffle Xu (jeffl...@linux.alibaba.com) wrote: >> In FUSE_INIT negotiating phase, server/client should advertise if it >> supports per-file DAX. >> >> Once advertising support for per-file DAX feature, virtiofsd should >> support storing

Re: [PATCH v4 0/8] fuse,virtiofs: support per-file DAX

2021-08-17 Thread JeffleXu
On 8/17/21 10:57 PM, Vivek Goyal wrote: > On Tue, Aug 17, 2021 at 09:22:53PM +0800, JeffleXu wrote: >> >> >> On 8/17/21 8:39 PM, Vivek Goyal wrote: >>> On Tue, Aug 17, 2021 at 10:06:53AM +0200, Miklos Szeredi wrote: >>>> On Tue, 17 Aug 2021 at 04:22, J

Re: [Virtio-fs] [PATCH v4 0/8] fuse,virtiofs: support per-file DAX

2021-08-17 Thread JeffleXu
On 8/17/21 10:54 PM, Vivek Goyal wrote: > On Tue, Aug 17, 2021 at 09:08:35PM +0800, JeffleXu wrote: >> >> >> On 8/17/21 6:09 PM, Miklos Szeredi wrote: >>> On Tue, 17 Aug 2021 at 11:32, Dr. David Alan Gilbert >>> wrote: >>>> >>>> *

Re: [PATCH v4 0/8] fuse,virtiofs: support per-file DAX

2021-08-17 Thread JeffleXu
On 8/17/21 10:08 PM, Miklos Szeredi wrote: > On Tue, 17 Aug 2021 at 15:22, JeffleXu wrote: >> >> >> >> On 8/17/21 8:39 PM, Vivek Goyal wrote: >>> On Tue, Aug 17, 2021 at 10:06:53AM +0200, Miklos Szeredi wrote: >>>> On Tue, 17 Aug 2021 at 04:22,

Re: [Virtio-fs] [PATCH v4 6/8] fuse: mark inode DONT_CACHE when per-file DAX indication changes

2021-08-17 Thread JeffleXu
On 8/17/21 6:26 PM, Dr. David Alan Gilbert wrote: > * Jeffle Xu (jeffl...@linux.alibaba.com) wrote: >> When the per-file DAX indication changes while the file is still >> *opened*, it is quite complicated and maybe fragile to dynamically >> change the DAX state. >> >> Hence mark the inode and

Re: [PATCH v4 0/8] fuse,virtiofs: support per-file DAX

2021-08-17 Thread JeffleXu
On 8/17/21 8:39 PM, Vivek Goyal wrote: > On Tue, Aug 17, 2021 at 10:06:53AM +0200, Miklos Szeredi wrote: >> On Tue, 17 Aug 2021 at 04:22, Jeffle Xu wrote: >>> >>> This patchset adds support of per-file DAX for virtiofs, which is >>> inspired by Ira Weiny's work on ext4[1] and xfs[2]. >> >> Can

Re: [Virtio-fs] [PATCH v4 0/8] fuse,virtiofs: support per-file DAX

2021-08-17 Thread JeffleXu
On 8/17/21 6:09 PM, Miklos Szeredi wrote: > On Tue, 17 Aug 2021 at 11:32, Dr. David Alan Gilbert > wrote: >> >> * Miklos Szeredi (mik...@szeredi.hu) wrote: >>> On Tue, 17 Aug 2021 at 04:22, Jeffle Xu wrote: This patchset adds support of per-file DAX for virtiofs, which is

Re: [PATCH v3 0/8] fuse,virtiofs: support per-file DAX

2021-08-11 Thread JeffleXu
ping? Corresponding patches for virtiofsd are also included in this patch set. On 8/4/21 3:06 PM, Jeffle Xu wrote: > changes since v2: > - modify fuse_show_options() accordingly to make it compatible with > new tri-state mount option (patch 2) > - extract FUSE protocol changes into one seperate

Re: [PATCH v2 0/4] virtiofs,fuse: support per-file DAX

2021-08-04 Thread JeffleXu
On 7/21/21 10:42 PM, Vivek Goyal wrote: > On Wed, Jul 21, 2021 at 08:48:57AM -0400, Vivek Goyal wrote: > [..] So is "dax=inode" enough for your needs? What's your requirement, can you give little bit of more details. >>> >>> In our use case, the backend fs is something like SquashFS

Re: [PATCH v2 3/4] fuse: add per-file DAX flag

2021-07-21 Thread JeffleXu
On 7/21/21 3:27 AM, Vivek Goyal wrote: > On Tue, Jul 20, 2021 at 02:51:34PM +0800, JeffleXu wrote: >> >> >> On 7/20/21 3:44 AM, Vivek Goyal wrote: >>> On Fri, Jul 16, 2021 at 06:47:52PM +0800, Jeffle Xu wrote: >>>> Add one flag for fuse_att

Re: [PATCH v2 3/4] fuse: add per-file DAX flag

2021-07-21 Thread JeffleXu
On 7/21/21 3:40 AM, Vivek Goyal wrote: > On Tue, Jul 20, 2021 at 03:19:50PM +0800, JeffleXu wrote: >> >> >> On 7/20/21 2:41 AM, Vivek Goyal wrote: >>> On Fri, Jul 16, 2021 at 06:47:52PM +0800, Jeffle Xu wrote: >>>> Add one flag for fuse_att

Re: [PATCH v2 0/4] virtiofs,fuse: support per-file DAX

2021-07-21 Thread JeffleXu
On 7/21/21 3:18 AM, Vivek Goyal wrote: > On Tue, Jul 20, 2021 at 01:25:11PM +0800, JeffleXu wrote: >> >> >> On 7/20/21 5:30 AM, Vivek Goyal wrote: >>> On Fri, Jul 16, 2021 at 06:47:49PM +0800, Jeffle Xu wrote: >>>> This patchset adds support of per-fil

Re: [PATCH v2 3/4] fuse: add per-file DAX flag

2021-07-20 Thread JeffleXu
On 7/20/21 2:51 PM, JeffleXu wrote: > > > On 7/20/21 3:44 AM, Vivek Goyal wrote: >> On Fri, Jul 16, 2021 at 06:47:52PM +0800, Jeffle Xu wrote: >>> Add one flag for fuse_attr.flags indicating if DAX shall be enabled for >>> this file. >>> >>>

Re: [PATCH v2 3/4] fuse: add per-file DAX flag

2021-07-20 Thread JeffleXu
On 7/20/21 2:41 AM, Vivek Goyal wrote: > On Fri, Jul 16, 2021 at 06:47:52PM +0800, Jeffle Xu wrote: >> Add one flag for fuse_attr.flags indicating if DAX shall be enabled for >> this file. >> >> When the per-file DAX flag changes for an *opened* file, the state of >> the file won't be updated

Re: [PATCH v2 3/4] fuse: add per-file DAX flag

2021-07-20 Thread JeffleXu
On 7/20/21 3:44 AM, Vivek Goyal wrote: > On Fri, Jul 16, 2021 at 06:47:52PM +0800, Jeffle Xu wrote: >> Add one flag for fuse_attr.flags indicating if DAX shall be enabled for >> this file. >> >> When the per-file DAX flag changes for an *opened* file, the state of >> the file won't be updated

Re: [PATCH v2 2/4] fuse: Make DAX mount option a tri-state

2021-07-19 Thread JeffleXu
On 7/20/21 2:02 AM, Vivek Goyal wrote: > On Fri, Jul 16, 2021 at 06:47:51PM +0800, Jeffle Xu wrote: >> We add 'always', 'never', and 'inode' (default). '-o dax' continues to >> operate the same which is equivalent to 'always'. >> >> By the time this patch is applied, 'inode' mode is actually

Re: [PATCH v2 0/4] virtiofs,fuse: support per-file DAX

2021-07-19 Thread JeffleXu
On 7/20/21 5:30 AM, Vivek Goyal wrote: > On Fri, Jul 16, 2021 at 06:47:49PM +0800, Jeffle Xu wrote: >> This patchset adds support of per-file DAX for virtiofs, which is >> inspired by Ira Weiny's work on ext4[1] and xfs[2]. >> >> There are three related scenarios: >> 1. Alloc inode: get

Re: [RFC PATCH 3/3] fuse: add per-file DAX flag

2021-07-15 Thread JeffleXu
On 7/16/21 9:32 AM, Vivek Goyal wrote: > On Fri, Jul 16, 2021 at 09:18:34AM +0800, JeffleXu wrote: >> >> >> On 7/16/21 8:51 AM, Vivek Goyal wrote: >>> On Fri, Jul 16, 2021 at 08:40:29AM +0800, Liu Bo wrote: >>>> On Thu, Jul 15, 2021 at 05:30:31PM

Re: [RFC PATCH 3/3] fuse: add per-file DAX flag

2021-07-15 Thread JeffleXu
On 7/16/21 8:51 AM, Vivek Goyal wrote: > On Fri, Jul 16, 2021 at 08:40:29AM +0800, Liu Bo wrote: >> On Thu, Jul 15, 2021 at 05:30:31PM +0800, Jeffle Xu wrote: >>> Add one flag for fuse_attr.flags indicating if DAX shall be enabled for >>> this file. >>> >>> When the per-file DAX flag changes

Re: [PATCH RFC] virtio-blk: support per-device queue depth

2021-01-19 Thread JeffleXu
On 1/19/21 12:06 PM, Jason Wang wrote: > > On 2021/1/19 上午9:33, JeffleXu wrote: >> >> On 1/18/21 1:25 PM, Jason Wang wrote: >>> On 2021/1/18 上午11:58, Joseph Qi wrote: >>>> module parameter 'virtblk_queue_depth' was firstly introduced for >>>>

Re: [PATCH RFC] virtio-blk: support per-device queue depth

2021-01-18 Thread JeffleXu
On 1/18/21 1:25 PM, Jason Wang wrote: > > On 2021/1/18 上午11:58, Joseph Qi wrote: >> module parameter 'virtblk_queue_depth' was firstly introduced for >> testing/benchmarking purposes described in commit fc4324b4597c >> ("virtio-blk: base queue-depth on virtqueue ringsize or module param"). >>