[PATCH] drm/virtio: fix OOB in virtio_gpu_object_create

2020-03-19 Thread Jiri Slaby
in virtio_gpu_create_object. Signed-off-by: Jiri Slaby Fixes: f651c8b05542 ("drm/virtio: factor out the sg_table from virtio_gpu_object") Cc: Gurchetan Singh Cc: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_object.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git

Re: [RESEND PATCH v2 9/9] ath5k: Constify ioreadX() iomem argument (as in generic implementation)

2020-02-20 Thread Jiri Slaby
On 19. 02. 20, 18:50, Krzysztof Kozlowski wrote: > The ioreadX() helpers have inconsistent interface. On some architectures > void *__iomem address argument is a pointer to const, on some not. > > Implementations of ioreadX() do not modify the memory under the address > so they can be converted

Re: [PATCH] drm: virtio: use kmem_cache

2017-03-10 Thread Jiri Slaby
On 03/01/2017, 03:09 PM, Gerd Hoffmann wrote: > @@ -128,12 +96,9 @@ void virtio_gpu_free_vbufs(struct virtio_gpu_device > *vgdev) > { > struct virtio_gpu_vbuffer *vbuf; > > - spin_lock(>free_vbufs_lock); > - BUG_ON(list_empty(>free_vbufs)); > - vbuf =

Re: BUG: 'list_empty(>free_vbufs)' is true!

2016-12-15 Thread Jiri Slaby
On 11/16/2016, 02:12 PM, Gerd Hoffmann wrote: > On Fr, 2016-11-11 at 17:28 +0100, Jiri Slaby wrote: >> On 11/09/2016, 09:01 AM, Gerd Hoffmann wrote: >>> On Di, 2016-11-08 at 22:37 +0200, Michael S. Tsirkin wrote: >>>> On Mon, Nov 07, 2016 at 09:43:24AM +01

Re: BUG: 'list_empty(>free_vbufs)' is true!

2016-11-15 Thread Jiri Slaby
On 11/15/2016, 09:46 AM, Gerd Hoffmann wrote: > On Fr, 2016-11-11 at 17:28 +0100, Jiri Slaby wrote: >> On 11/09/2016, 09:01 AM, Gerd Hoffmann wrote: >>> On Di, 2016-11-08 at 22:37 +0200, Michael S. Tsirkin wrote: >>>> On Mon, Nov 07, 2016 at 09:43:24AM +01

Re: BUG: 'list_empty(>free_vbufs)' is true!

2016-11-11 Thread Jiri Slaby
On 11/09/2016, 09:01 AM, Gerd Hoffmann wrote: > On Di, 2016-11-08 at 22:37 +0200, Michael S. Tsirkin wrote: >> On Mon, Nov 07, 2016 at 09:43:24AM +0100, Jiri Slaby wrote: >>> Hi, >>> >>> I can relatively easily reproduce this bug: > > How? Run dmesg

Re: BUG: 'list_empty(>free_vbufs)' is true!

2016-11-11 Thread Jiri Slaby
On 11/08/2016, 09:37 PM, Michael S. Tsirkin wrote: > On Mon, Nov 07, 2016 at 09:43:24AM +0100, Jiri Slaby wrote: > The following might be helpful for debugging - if kernel still will > not stop panicing, we are looking at some kind > of memory corruption. > > > diff --

BUG: 'list_empty(>free_vbufs)' is true!

2016-11-07 Thread Jiri Slaby
Hi, I can relatively easily reproduce this bug: BUG: 'list_empty(>free_vbufs)' is true! [ cut here ] kernel BUG at /home/latest/linux/drivers/gpu/drm/virtio/virtgpu_vq.c:130! invalid opcode: [#1] PREEMPT SMP KASAN Modules linked in: CPU: 1 PID: 355 Comm: kworker/1:2

Re: [PATCH 2/3]: Staging: hv: Use native wait primitives

2011-02-15 Thread Jiri Slaby
On 02/11/2011 06:59 PM, K. Y. Srinivasan wrote: In preperation for getting rid of the osd layer; change the code to use native wait interfaces. As part of this, fixed the buggy implementation in the osd_wait_primitive where the condition was cleared potentially after the condition was

[PATCH] Char: virtio_console, fix memory leak

2010-11-06 Thread Jiri Slaby
Stanse found that in init_vqs, memory is leaked under certain circumstanses (the fail path order is incorrect). Fix that by checking allocations in one turn and free all of them at once if some fails (some may be NULL, but this is OK). Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Amit Shah amit.s

[PATCH v2 3/5] VIDEO: xen-fb, switch to for_each_console

2010-11-04 Thread Jiri Slaby
Use newly added for_each_console for iterating consoles. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Jeremy Fitzhardinge jer...@xensource.com Cc: Chris Wright chr...@sous-sol.org Cc: virtualizat...@lists.osdl.org Cc: xen-de...@lists.xensource.com Cc: linux-fb...@vger.kernel.org --- drivers

[PATCH 3/3] VIDEO: xen-fb, switch to for_each_console

2010-11-03 Thread Jiri Slaby
Use newly added for_each_console for iterating consoles. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Jeremy Fitzhardinge jer...@xensource.com Cc: Chris Wright chr...@sous-sol.org Cc: virtualizat...@lists.osdl.org Cc: xen-de...@lists.xensource.com Cc: linux-fb...@vger.kernel.org --- drivers