Re: [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no cvq

2021-11-02 Thread Juan Quintela
umber of queues. > > Fixes: 049eb15b5fc9 ("vhost: record the last virtqueue index for the > virtio device") > Signed-off-by: Eugenio Pérez Reviewed-by: Juan Quintela ___ Virtualization mailing list Virtualization@lists.linux-foundation.

Re: [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no cvq

2021-11-02 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Tue, Nov 02, 2021 at 08:25:27AM +0100, Juan Quintela wrote: >> Eugenio Pérez wrote: >> > The -1 assumes that all devices with no cvq have an spare vq allocated >> > for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This may

Re: [RFC PATCH v5 05/26] vhost: Add x-vhost-set-shadow-vq qmp

2021-11-02 Thread Juan Quintela
Eugenio Pérez wrote: > Command to set shadow virtqueue mode. > > Signed-off-by: Eugenio Pérez Reviewed-by: Juan Quintela You need to keep care of: Markus Armbruster ] [PATCH v2 0/9] Configurable policy for handling unstable interfaces When this hit the tree, you need to d

Re: [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no cvq

2021-11-02 Thread Juan Quintela
Eugenio Pérez wrote: > The -1 assumes that all devices with no cvq have an spare vq allocated > for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This may not be the > case, and the device may have a pair number of queues. even I know, I know, I am

Re: [RFC PATCH v5 01/26] util: Make some iova_tree parameters const

2021-10-31 Thread Juan Quintela
shout in case of > modifying or freeing the const-qualified returned pointer. > > Signed-off-by: Eugenio Pérez > Acked-by: Peter Xu > Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela This patch can go in already, whos

Re: [PULL] virtio console fixes, abi change

2010-04-14 Thread Juan Quintela
, with a couple of fixes: - Create a console port when not using multiport (fix was sent as a reply to prev. series) - Add hunk that got inadvertently reverted during git rebase operations (thanks Juan). The diff to the v6 version is attached below: Acked-by: Juan Quintela quint...@redhat.com

Re: [PATCH 0/2] virtio: console: Trivial fixes based on review comments

2010-03-08 Thread Juan Quintela
names for fill_queue operation drivers/char/virtio_console.c | 29 - 1 files changed, 16 insertions(+), 13 deletions(-) Acked-by: Juan Quintela quint...@redhat.com ___ Virtualization mailing list Virtualization

Re: [PATCH 3/3] vhost: fix get_user_pages_fast error handling

2010-02-23 Thread Juan Quintela
the number * requested. If nr_pages is 0 or negative, returns 0. If no pages * were pinned, returns -errno. */ I agree that code was wrong, but the BUG_ON() is not neccessary IMHO. The important bit is the change in the comparison. Reviewed-by: Juan Quintela quint...@redhat.com Signed-off

Re: [PATCH 1/3] vhost: logging math fix

2010-02-23 Thread Juan Quintela
...@redhat.com Reviewed-by: Juan Quintela quint...@redhat.com --- drivers/vhost/vhost.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 6eb1525..c767279 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost

Re: [PATCH 2/3] vhost: initialize log eventfd context pointer

2010-02-23 Thread Juan Quintela
Michael S. Tsirkin m...@redhat.com wrote: vq log eventfd context pointer needs to be initialized, otherwise operation may fail or oops if log is enabled but log eventfd not set by userspace. Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Juan Quintela quint...@redhat.com

Re: [PATCH 2/2] virtio-console: Add interface for generic guest-host communication

2009-09-03 Thread Juan Quintela
Amit Shah amit.s...@redhat.com wrote: This interface extends the virtio-console device to handle multiple ports that present a char device from which bits can be sent and read. Sample uses for such a device can be obtaining info from the guest like the file systems used, apps installed, etc.

Re: [PATCH 2/2] virtio-console: Add interface for generic guest-host communication

2009-09-03 Thread Juan Quintela
Amit Shah amit.s...@redhat.com wrote: Hi +static void virtio_console_set_port_active(uint32_t idx) +{ +int i = 0; + +while (idx / 32) { +i++; +idx -= 32; +} It is just me, or you are doing a division + modulus in a very strange way?

Re: [Xen-devel] Re: Next steps with pv_ops for Xen

2007-11-26 Thread Juan Quintela
Hi, your console works great, but rest of patches are assuming: arch/x86/boot/compressed/notes-xen.c arch/x86/xen/early.c at least. It looks as if there is missing another patche, could you take a look, please? Otherwise, I will take a look at what is missing. It breaks with: Intel machine