> From: Michael S. Tsirkin
> Sent: Tuesday, October 31, 2023 1:29 PM
>
> On Tue, Oct 31, 2023 at 03:11:57AM +, Parav Pandit wrote:
> >
> >
> > > From: Michael S. Tsirkin
> > > Sent: Tuesday, October 31, 2023 5:02 AM
> > >
> > > On Mon, Oct 30, 2023 at 06:10:06PM +, Parav Pandit wrote:
> From: Michael S. Tsirkin
> Sent: Tuesday, October 31, 2023 5:02 AM
>
> On Mon, Oct 30, 2023 at 06:10:06PM +, Parav Pandit wrote:
> >
> >
> > > From: Michael S. Tsirkin
> > > Sent: Monday, October 30, 2023 9:29 PM On Mon, Oct 30, 2023 at
> > > 03:51:40PM +, Parav Pandit wrote:
> > >
> From: Michael S. Tsirkin
> Sent: Monday, October 30, 2023 9:29 PM
> On Mon, Oct 30, 2023 at 03:51:40PM +, Parav Pandit wrote:
> >
> >
> > > From: Michael S. Tsirkin
> > > Sent: Monday, October 30, 2023 1:53 AM
> > >
> > > On Sun, Oct 29, 2023 at 05:59:45PM +0200, Yishai Hadas wrote:
> >
> From: Michael S. Tsirkin
> Sent: Monday, October 30, 2023 1:53 AM
>
> On Sun, Oct 29, 2023 at 05:59:45PM +0200, Yishai Hadas wrote:
> > From: Feng Liu
> >
> > Introduce support for the admin virtqueue. By negotiating
> > VIRTIO_F_ADMIN_VQ feature, driver detects capability and creates one
> From: Michael S. Tsirkin
> Sent: Thursday, October 26, 2023 9:16 PM
> On Thu, Oct 26, 2023 at 03:09:13PM +, Parav Pandit wrote:
> >
> > > From: Michael S. Tsirkin
> > > Sent: Thursday, October 26, 2023 8:36 PM
> > >
> > > On Thu, Oct 26, 2023 at 01:28:18PM +, Parav Pandit wrote:
> >
> From: Michael S. Tsirkin
> Sent: Thursday, October 26, 2023 8:36 PM
>
> On Thu, Oct 26, 2023 at 01:28:18PM +, Parav Pandit wrote:
> >
> > > From: Michael S. Tsirkin
> > > Sent: Thursday, October 26, 2023 6:45 PM
> >
> > > > Followed by an open coded driver check for 0x1000 to 0x103f
> From: Michael S. Tsirkin
> Sent: Thursday, October 26, 2023 6:45 PM
> > Followed by an open coded driver check for 0x1000 to 0x103f range.
> > Do you mean windows driver expects specific subsystem vendor id of 0x1af4?
>
> Look it up, it's open source.
Those are not OS inbox drivers anyway.
> From: Michael S. Tsirkin
> Sent: Thursday, October 26, 2023 5:42 PM
>
> On Thu, Oct 26, 2023 at 03:08:12PM +0300, Yishai Hadas wrote:
> > > > Makes sense ?
> > > So do I understand correctly that virtio dictates the subsystem
> > > device ID for all subsystem vendor IDs that implement a legacy
> From: Alex Williamson
> Sent: Wednesday, October 18, 2023 6:22 PM
> Are we realistically extending this beyond virtio-net? Maybe all the
> descriptions
> should be limited to what is actually supported as proposed rather than
> aspirational goals. Thanks,
Virtio blk would the second user
> From: Michael S. Tsirkin
> Sent: Thursday, October 12, 2023 5:00 PM
> I am instead talking about devices that work with existing legacy linux
> drivers
> with no traps.
>
Yep, I understood.
> > I am not expecting OASIS to do anything extra for legacy registers.
> >
> > [1] The device MUST
> From: Michael S. Tsirkin
> Sent: Thursday, October 12, 2023 4:23 PM
>
> On Tue, Sep 26, 2023 at 03:45:36AM +, Parav Pandit wrote:
> >
> >
> > > From: Michael S. Tsirkin
> > > Sent: Tuesday, September 26, 2023 12:06 AM
> >
> > > One can thinkably do that wait in hardware, though. Just
Hi Christoph,
> From: Christoph Hellwig
> Sent: Wednesday, October 11, 2023 12:29 PM
>
> On Wed, Oct 11, 2023 at 02:43:37AM -0400, Michael S. Tsirkin wrote:
> > > Btw, what is that intel thing everyone is talking about? And why
> > > would the virtio core support vendor specific behavior like
> From: Jason Gunthorpe
> Sent: Tuesday, October 10, 2023 9:37 PM
>
> On Tue, Oct 10, 2023 at 12:03:29PM -0400, Michael S. Tsirkin wrote:
> > On Tue, Oct 10, 2023 at 12:59:37PM -0300, Jason Gunthorpe wrote:
> > > On Tue, Oct 10, 2023 at 11:14:56AM -0400, Michael S. Tsirkin wrote:
> > >
> > > >
> From: Yishai Hadas
> Sent: Tuesday, October 10, 2023 9:14 PM
>
> On 10/10/2023 18:14, Michael S. Tsirkin wrote:
> > On Tue, Oct 10, 2023 at 06:09:44PM +0300, Yishai Hadas wrote:
> >> On 10/10/2023 17:54, Michael S. Tsirkin wrote:
> >>> On Tue, Oct 10, 2023 at 11:08:49AM -0300, Jason
> From: Michael S. Tsirkin
> Sent: Friday, September 22, 2023 9:23 PM
> > +static int virtiovf_pci_probe(struct pci_dev *pdev,
> > + const struct pci_device_id *id) {
> > + const struct vfio_device_ops *ops = _acc_vfio_pci_ops;
> > + struct virtiovf_pci_core_device
> From: Michael S. Tsirkin
> Sent: Tuesday, September 26, 2023 10:30 PM
> For example, a transitional device
> must not in theory be safely passed through to guest userspace, because guest
> then might try to use it through the legacy BAR without acknowledging
> ACCESS_PLATFORM.
> Do any
> From: Jason Wang
> Sent: Tuesday, September 26, 2023 10:08 AM
> Right, so if we'd consider migration from virtio to vDPA, it needs to be
> designed
> in a way that allows more involvement from hypervisor other than coupling it
> with a specific interface (like admin virtqueues).
It is not
> From: Jason Wang
> Sent: Tuesday, September 26, 2023 10:07 AM
>
> If you can't find a way to make legacy drivers work, use modern.
>
Understood.
This vfio series make the legacy drivers work.
Thanks.
> That's it.
>
> Thanks
___
> From: Jason Wang
> Sent: Tuesday, September 26, 2023 8:03 AM
>
> It's the implementation details in legacy. The device needs to make sure
> (reset)
> the driver can work (is done before get_status return).
It is part of the 0.9.5 and 1.x specification as I quoted those text above.
> From: Michael S. Tsirkin
> Sent: Tuesday, September 26, 2023 12:06 AM
> One can thinkably do that wait in hardware, though. Just defer completion
> until
> read is done.
>
Once OASIS does such new interface and if some hw vendor _actually_ wants to do
such complex hw, may be vfio driver
> From: Jason Wang
> Sent: Monday, September 25, 2023 8:00 AM
>
> On Fri, Sep 22, 2023 at 8:25 PM Parav Pandit wrote:
> >
> >
> > > From: Jason Gunthorpe
> > > Sent: Friday, September 22, 2023 5:53 PM
> >
> >
> > > > And what's more, using MMIO BAR0 then it can work for legacy.
> > >
> > >
> From: Jason Gunthorpe
> Sent: Friday, September 22, 2023 6:07 PM
>
> On Thu, Sep 21, 2023 at 01:58:32PM -0600, Alex Williamson wrote:
>
> > If the heart of this driver is simply pretending to have an I/O BAR
> > where I/O accesses into that BAR are translated to accesses in the
> > MMIO
> From: Jason Gunthorpe
> Sent: Friday, September 22, 2023 5:53 PM
> > And what's more, using MMIO BAR0 then it can work for legacy.
>
> Oh? How? Our team didn't think so.
It does not. It was already discussed.
The device reset in legacy is not synchronous.
The drivers do not wait for reset
> From: Michael S. Tsirkin
> Sent: Thursday, September 21, 2023 10:31 PM
> Another question I'm interested in is whether there's actually a performance
> benefit to using this as compared to just software vhost. I note there's a VM
> exit
> on each IO access, so ... perhaps?
> Would be nice
> From: Feng Liu
> Sent: Tuesday, May 2, 2023 8:35 PM
> Issue: 3383038
Remove this internal garbage.
> Fixes: 754b8a21a96d ("virtio_net: setup xdp_rxq_info")
> Signed-off-by: Feng Liu
> Reviewed-by: William Tu
> Reviewed-by: Parav Pandit
> Reviewed-by: Simon Horman
> Acked-by: Michael S.
On 4/3/2023 12:20 PM, Eli Cohen wrote:
Hi,
the single patch in this series adds support for posted interrupts in
mlx5.
It depends on the patch series already accpted can be seen here:
https://patchwork.kernel.org/project/netdevbpf/patch/20230324231341.29808-1-sa...@kernel.org/
git pull
On 4/3/2023 12:20 PM, Eli Cohen wrote:
Add support for generation of interrupts from the device directly to the
VM to the VCPU thus avoiding the overhead on the host CPU.
When supported, the driver will attempt to allocate vectors for each
data virtqueue. If a vector for a virtqueue cannot
> From: Feng Liu
> Sent: Friday, March 10, 2023 12:34 AM
>
> - if (!is_power_of_2(num)) {
> - dev_warn(_dev->pci_dev->dev, "bad queue size %u",
> num);
> - return ERR_PTR(-EINVAL);
> - }
> -
The check is still valid for split q.
Maybe the right place for such
> From: Jiri Pirko
> Sent: Tuesday, February 21, 2023 9:48 AM
>
> From: Jiri Pirko
>
> Virtio spec introduced a feature VIRTIO_NET_F_GUEST_HDRLEN which when
> set implicates that the driver provides the exact size of the header.
>
> Quoting the original virtio spec:
> "hdr_len is a hint to
To easily audit the code, better to keep the device stop()
sequence to be mirror of the device open() sequence.
Acked-by: Michael S. Tsirkin
Reviewed-by: Jiri Pirko
Signed-off-by: Parav Pandit
---
drivers/net/virtio_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
> From: Si-Wei Liu
> Sent: Thursday, February 2, 2023 4:59 PM
>
> On 2/1/2023 9:05 PM, Parav Pandit wrote:
> >
> >> From: Si-Wei Liu
> >> Sent: Tuesday, January 31, 2023 6:22 PM
> >>
> >> With device feature provisioning, there's a chance for
> >> misconfiguration that the vdpa feature
Cited commit in fixes tag frees rxq xdp info while RQ NAPI is
still enabled and packet processing may be ongoing.
Follow the mirror sequence of open() in the stop() callback.
This ensures that when rxq info is unregistered, no rx
packet processing is ongoing.
Fixes: 754b8a21a96d ("virtio_net:
> From: Jiri Pirko
> Sent: Thursday, February 2, 2023 10:47 AM
>
> Thu, Feb 02, 2023 at 04:10:56PM CET, pa...@nvidia.com wrote:
> >
> >> From: Jiri Pirko
> >> Sent: Thursday, February 2, 2023 7:26 AM
> >>
> >> Thu, Feb 02, 2023 at 06:00:38AM CET, pa...@nvidia.com wrote:
> >> >To easily audit
> From: Jiri Pirko
> Sent: Thursday, February 2, 2023 7:26 AM
>
> Thu, Feb 02, 2023 at 06:00:38AM CET, pa...@nvidia.com wrote:
> >To easily audit the code, better to keep the device stop() sequence to
> >be mirror of the device open() sequence.
> >
> >Signed-off-by: Parav Pandit
>
>
> From: Si-Wei Liu
> Sent: Tuesday, January 31, 2023 6:22 PM
>
> With device feature provisioning, there's a chance for misconfiguration that
> the
> vdpa feature attribute supplied in 'vdpa dev add' command doesn't get
> selected on the device_features to be provisioned. For instance, when
Hi,
This two small patches improves ndo_close() callback to follow
the mirror sequence of ndo_open() callback. This improves the code auditing
and also ensure that xdp rxq info is not unregistered while NAPI on
RXQ is ongoing.
Please review.
Patch summary:
patch-1 ensures that xdp rq info is
Cited commit in fixes tag frees rxq xdp info while RQ NAPI is
still enabled and packet processing may be ongoing.
Follow the mirror sequence of open() in the stop() callback.
This ensures that when rxq info is unregistered, no rx
packet processing is ongoing.
Fixes: 754b8a21a96d ("virtio_net:
> From: Si-Wei Liu
> Sent: Tuesday, January 31, 2023 6:22 PM
>
> The spec says:
> status only exists if VIRTIO_NET_F_STATUS is set
>
> Similar to MAC and MTU, vdpa_dev_net_config_fill() should read STATUS
> conditionally depending on the feature bits.
>
> Signed-off-by: Si-Wei Liu
>
> From: Si-Wei Liu
> Sent: Tuesday, January 31, 2023 6:22 PM
>
> In below example, before the fix, mtu attribute is supported by the parent
> mgmtdev, but the error message showing "All provided are not supported" is
> just misleading.
>
> $ vdpa mgmtdev show
> vdpasim_net:
>
virtio queue index can be maximum of 65535. 16 bytes are enough to store
the vq name with the existing string prefix.
With this change, send queue struct saves 24 bytes and receive
queue saves whole cache line worth 64 bytes per structure
due to saving in alignment bytes.
Pahole results before:
> From: Michael S. Tsirkin
> Sent: Monday, January 16, 2023 5:13 PM
>
> On Mon, Jan 16, 2023 at 10:27:08PM +0200, Parav Pandit wrote:
> > virtnet_rq_free_unused_buf() helper function to free the buffer
> > already exists. Avoid code duplication by reusing existing function.
> >
> >
virtnet_rq_free_unused_buf() helper function to free the buffer
already exists. Avoid code duplication by reusing existing function.
Reviewed-by: Alexander Duyck
Reviewed-by: Xuan Zhuo
Signed-off-by: Parav Pandit
---
drivers/net/virtio_net.c | 8 +---
1 file changed, 1 insertion(+), 7
Hi Jakub, Dave,
> From: Parav Pandit
> Sent: Friday, January 13, 2023 5:36 PM
>
> Hi,
>
> These two changes improve the small packet handling.
>
> Patch summary:
> patch-1 fixes the length check by considering Ethernet 60B frame size
> patch-2 avoids code duplication by reuses existing buffer
> From: Alexander Duyck
> Sent: Friday, January 13, 2023 7:24 PM
>
> On Fri, Jan 13, 2023 at 3:37 PM Parav Pandit wrote:
> >
> >
> > > From: Alexander H Duyck
> > > Sent: Friday, January 13, 2023 6:24 PM
> > >
> > > On Sat, 2023-01-14 at 00:36 +0200, Parav Pandit wrote:
> > > > A smallest
> From: Alexander H Duyck
> Sent: Friday, January 13, 2023 6:24 PM
>
> On Sat, 2023-01-14 at 00:36 +0200, Parav Pandit wrote:
> > A smallest Ethernet frame defined by IEEE 802.3 is 60 bytes without
> > any preemble and CRC.
> >
> > Current code only checks for minimal 14 bytes of Ethernet
virtnet_rq_free_unused_buf() helper function to free the buffer
already exists. Avoid code duplication by reusing existing function.
Signed-off-by: Parav Pandit
---
drivers/net/virtio_net.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/net/virtio_net.c
Hi,
These two changes improve the small packet handling.
Patch summary:
patch-1 fixes the length check by considering Ethernet 60B frame size
patch-2 avoids code duplication by reuses existing buffer free helper
Please review.
Parav Pandit (2):
virtio_net: Fix short frame length check
A smallest Ethernet frame defined by IEEE 802.3 is 60 bytes without any
preemble and CRC.
Current code only checks for minimal 14 bytes of Ethernet header length.
Correct it to consider the minimum Ethernet frame length.
Fixes: 296f96fcfc16 ("Net driver using virtio")
Signed-off-by: Parav Pandit
> From: Si-Wei Liu
> Sent: Thursday, October 20, 2022 2:12 PM
>
>
> On 10/19/2022 10:25 PM, Jason Wang wrote:
> > On Wed, Oct 19, 2022 at 8:56 AM Si-Wei Liu
> wrote:
> >> Live migration of vdpa would typically require re-instate vdpa device
> >> with an idential set of configs on the
> From: Jakub Kicinski
> Sent: Thursday, September 22, 2022 6:05 PM
>
> On Thu, 22 Sep 2022 06:14:59 -0400 Michael S. Tsirkin wrote:
> > It's nitpicking to be frank. v6 arrived while I was traveling and I
> > didn't notice it. I see Jason acked that so I guess I will just apply
> > as is.
>
>
> From: Michael S. Tsirkin
> Sent: Thursday, September 22, 2022 6:15 AM
>
> It's nitpicking to be frank. v6 arrived while I was traveling and I didn't
> notice it.
> I see Jason acked that so I guess I will just apply as is. Do you ack v6 too?
>
Yes. I reviewed it. Gavin added reviewed-by.
> From: Michael S. Tsirkin
> Sent: Thursday, September 22, 2022 5:27 AM
> > >
> > > And I'd like commit log to include results of perf testing
> > > - with indirect feature on
> > Which device do you suggest using for this test?
>
> AFAIK most devices support INDIRECT, e.g. don't nvidia cards
> From: Michael S. Tsirkin
> Sent: Thursday, September 22, 2022 5:35 AM
>
> On Thu, Sep 01, 2022 at 05:10:38AM +0300, Gavin Li wrote:
> > Currently add_recvbuf_big() allocates MAX_SKB_FRAGS segments for big
> > packets even when GUEST_* offloads are not present on the device.
> > However, if
Hi Jason,
> From: Jason Wang
> Sent: Thursday, September 15, 2022 4:51 AM
> To: m...@redhat.com; jasow...@redhat.com
> Cc: Eli Cohen ; si-wei@oracle.com; Parav Pandit
> ; wuzongy...@linux.alibaba.com;
> virtualization@lists.linux-foundation.org; linux-ker...@vger.kernel.org;
>
> From: Si-Wei Liu
> Sent: Wednesday, September 7, 2022 5:40 PM
>
>
> On 9/7/2022 12:51 PM, Parav Pandit wrote:
> >> And I'd like commit log to include results of perf testing
> >> - with indirect feature on
> > Which device do you suggest using for this test?
> >
> You may use software
> From: Michael S. Tsirkin
> Sent: Wednesday, September 7, 2022 3:36 PM
>
> (c) replace mtu = 0 with sensibly not calling the function when mtu is
> unknown.
Even when mtu is zero, virtnet_set_big_packets() must be called to act on the
gso bits.
Currently handling by virtnet_set_big_packets()
> From: Michael S. Tsirkin
> Sent: Wednesday, September 7, 2022 3:38 PM
>
> and if possible a larger ring. 1k?
What do you expect to see here for which test report should be added to commit
log?
What is special about 1k vs 512, 128 and 2k? is 1K default for some
configuration?
> From: Michael S. Tsirkin
> Sent: Wednesday, September 7, 2022 3:36 PM
>
> On Wed, Sep 07, 2022 at 07:27:16PM +, Parav Pandit wrote:
> >
> > > From: Michael S. Tsirkin
> > > Sent: Wednesday, September 7, 2022 3:24 PM
> > >
> > > On Wed, Sep 07, 2022 at 07:18:06PM +, Parav Pandit
> From: Michael S. Tsirkin
> Sent: Wednesday, September 7, 2022 3:24 PM
>
> On Wed, Sep 07, 2022 at 07:18:06PM +, Parav Pandit wrote:
> >
> > > From: Michael S. Tsirkin
> > > Sent: Wednesday, September 7, 2022 3:12 PM
> >
> > > > Because of shallow queue of 16 entries deep.
> > >
> > >
> From: Michael S. Tsirkin
> Sent: Wednesday, September 7, 2022 3:12 PM
> > Because of shallow queue of 16 entries deep.
>
> but why is the queue just 16 entries?
I explained the calculation in [1] about 16 entries.
[1]
> From: Michael S. Tsirkin
> Sent: Wednesday, September 7, 2022 2:16 PM
>
> On Wed, Sep 07, 2022 at 04:12:47PM +, Parav Pandit wrote:
> >
> > > From: Michael S. Tsirkin
> > > Sent: Wednesday, September 7, 2022 10:40 AM
> > >
> > > On Wed, Sep 07, 2022 at 02:33:02PM +, Parav Pandit
> From: Michael S. Tsirkin
> Sent: Wednesday, September 7, 2022 10:40 AM
>
> On Wed, Sep 07, 2022 at 02:33:02PM +, Parav Pandit wrote:
> >
> > > From: Michael S. Tsirkin
> > > Sent: Wednesday, September 7, 2022 10:30 AM
> >
> > [..]
> > > > > actually how does this waste space? Is this
> From: Michael S. Tsirkin
> Sent: Wednesday, September 7, 2022 10:30 AM
[..]
> > > actually how does this waste space? Is this because your device does
> > > not have INDIRECT?
> > VQ is 256 entries deep.
> > Driver posted total of 256 descriptors.
> > Each descriptor points to a page of 4K.
> From: Michael S. Tsirkin
> Sent: Wednesday, September 7, 2022 5:27 AM
>
> On Wed, Sep 07, 2022 at 04:08:54PM +0800, Gavin Li wrote:
> >
> > On 9/7/2022 1:31 PM, Michael S. Tsirkin wrote:
> > > External email: Use caution opening links or attachments
> > >
> > >
> > > On Thu, Sep 01, 2022 at
> From: Gavin Li
> Sent: Wednesday, August 31, 2022 5:03 AM
>
> Probe routine is already several hundred lines.
> Use helper function for guest gso support check.
>
> Signed-off-by: Gavin Li
> Reviewed-by: Gavi Teitz
> Reviewed-by: Parav Pandit
You missed the review by and ack by entries
> From: Si-Wei Liu
> Sent: Friday, August 26, 2022 2:05 PM
>
> > + /* If we can receive ANY GSO packets, we must allocate large ones.
> */
> > + if (mtu > ETH_DATA_LEN || guest_gso) {
> > + vi->big_packets = true;
> > + /* if the guest offload is offered by the
From: Si-Wei Liu
Sent: Friday, August 26, 2022 4:52 AM
> Sorry for the delay. Didn't notice as this thread was not addressed to my
> work email. Please copy to my work email if it needs my immediate attention.
Can you please setup your mail client to post plain text mail as required
> From: Gavin Li
> Sent: Friday, August 19, 2022 10:49 AM
>
> This small series contains two patches that improves virtio netdevice
> performance for 9K mtu when GRO/ guest TSO is disabled.
>
> Gavin Li (2):
> virtio-net: introduce and use helper function for guest gso support
> checks
> From: Jason Wang
> Sent: Thursday, August 18, 2022 12:19 AM
> On 8/16/2022 10:32 AM, Parav Pandit wrote:
> >> From: Zhu Lingshan
> >> Sent: Monday, August 15, 2022 5:27 AM
> >>
> >> Some fields of virtio-net device config space are conditional on
> >> the feature
> From: Zhu, Lingshan
> Sent: Tuesday, August 16, 2022 12:19 AM
>
>
> On 8/16/2022 10:32 AM, Parav Pandit wrote:
> >> From: Zhu Lingshan
> >> Sent: Monday, August 15, 2022 5:27 AM
> >>
> >> Some fields of virtio-net device config space are conditional on the
> >> feature bits, the spec says:
> From: Zhu Lingshan
> Sent: Monday, August 15, 2022 5:27 AM
>
> Some fields of virtio-net device config space are conditional on the feature
> bits, the spec says:
>
> "The mac address field always exists
> (though is only valid if VIRTIO_NET_F_MAC is set)"
>
> "max_virtqueue_pairs only
> From: Zhu, Lingshan
> Sent: Monday, August 15, 2022 9:49 PM
>
> On 8/16/2022 2:15 AM, Si-Wei Liu wrote:
> >
> >
> > On 8/15/2022 2:26 AM, Zhu Lingshan wrote:
> >> This commit adds a new vDPA netlink attribution
> >> VDPA_ATTR_VDPA_DEV_SUPPORTED_FEATURES. Userspace can query
> features
> >> of
> From: Michael S. Tsirkin
> Sent: Wednesday, August 10, 2022 12:59 PM
>
> On Wed, Aug 10, 2022 at 04:22:41PM +, Parav Pandit wrote:
> >
> > > From: Michael S. Tsirkin
> > > Sent: Wednesday, August 10, 2022 12:05 PM
> > >
> > > On Wed, Aug 10, 2022 at 04:00:08PM +, Parav Pandit wrote:
> From: Michael S. Tsirkin
> Sent: Wednesday, August 10, 2022 12:05 PM
>
> On Wed, Aug 10, 2022 at 04:00:08PM +, Parav Pandit wrote:
> >
> > > From: Michael S. Tsirkin
> > > Sent: Wednesday, August 10, 2022 5:03 AM
> > > > >
> > > > > Should we make this depend on the vq reset ability
> From: Michael S. Tsirkin
> Sent: Wednesday, August 10, 2022 5:03 AM
> > >
> > > Should we make this depend on the vq reset ability maybe?
> >
> > The advantage of this is to keep TX working. Or we can use device
> > reset as a fallback if there's no vq reset.
> >
> > Thanks
>
> Device reset
> From: Michael S. Tsirkin
> Sent: Tuesday, August 9, 2022 6:26 PM
> To: Parav Pandit
> Cc: Si-Wei Liu ; Jason Wang
> ; Gavin Li ; Hemminger,
> Stephen ; davem
> ; virtualization foundation.org>; Virtio-Dev ;
> jesse.brandeb...@intel.com; alexander.h.du...@intel.com;
> kubak...@wp.pl;
> From: Michael S. Tsirkin
> Sent: Tuesday, August 9, 2022 5:38 PM
[..]
> > > I think virtio-net driver doesn't differentiate MTU and MRU, in
> > > which case the receive buffer will be reduced to fit the 1500B
> > > payload size when mtu is lowered down to 1500 from 9000.
> > How? Driver
> From: Si-Wei Liu
> Sent: Tuesday, August 9, 2022 4:33 PM
>
> On 8/9/2022 12:18 PM, Parav Pandit wrote:
> >> From: Si-Wei Liu
> >> Sent: Tuesday, August 9, 2022 3:09 PM
> From: Si-Wei Liu
> Sent: Tuesday, August 9, 2022 2:39 PM Currently it is not. Not a
> single patch nor this
> From: Michael S. Tsirkin
> Sent: Tuesday, August 9, 2022 3:36 PM
> > > After applying this commit, when MQ = 0, iproute2 output:
> > > $vdpa dev config show vdpa0
> > > vdpa0: mac 00:e8:ca:11:be:05 link up link_announce false
> > > max_vq_pairs 1 mtu 1500
> > >
> > No. We do not want to
> From: Michael S. Tsirkin
> Sent: Tuesday, August 9, 2022 3:24 PM
>
> On Fri, Jul 22, 2022 at 07:53:06PM +0800, Zhu Lingshan wrote:
> > This commit adds a new vDPA netlink attribution
> > VDPA_ATTR_VDPA_DEV_SUPPORTED_FEATURES. Userspace can query
> features of
> > vDPA devices through this new
> From: Zhu, Lingshan
> Sent: Wednesday, July 27, 2022 2:02 AM
>
>
> On 7/26/2022 7:06 PM, Parav Pandit wrote:
> >> From: Zhu, Lingshan
> >> Sent: Tuesday, July 26, 2022 7:03 AM
> >>
> >> On 7/24/2022 11:21 PM, Parav Pandit wrote:
> From: Zhu, Lingshan
> Sent: Saturday, July 23,
> From: Si-Wei Liu
> Sent: Tuesday, August 9, 2022 3:09 PM
> >> From: Si-Wei Liu
> >> Sent: Tuesday, August 9, 2022 2:39 PM Currently it is not. Not a
> >> single patch nor this patch, but the context for the eventual goal is
> >> to allow XDP on a MTU=9000 link when guest users intentionally
> From: Si-Wei Liu
> Sent: Tuesday, August 9, 2022 2:39 PM
> Currently it is not. Not a single patch nor this patch, but the context for
> the
> eventual goal is to allow XDP on a MTU=9000 link when guest users
> intentionally lower down MTU to 1500.
Which application benefit by having
> From: Zhu, Lingshan
> Sent: Tuesday, July 26, 2022 10:53 PM
>
> On 7/27/2022 10:17 AM, Parav Pandit wrote:
> >> From: Zhu, Lingshan
> >> Sent: Tuesday, July 26, 2022 10:15 PM
> >>
> >> On 7/26/2022 11:56 PM, Parav Pandit wrote:
> From: Zhu, Lingshan
> Sent: Tuesday, July 12, 2022
> From: Zhu, Lingshan
> Sent: Tuesday, July 26, 2022 10:15 PM
>
> On 7/26/2022 11:56 PM, Parav Pandit wrote:
> >> From: Zhu, Lingshan
> >> Sent: Tuesday, July 12, 2022 11:46 PM
> >>> When the user space which invokes netlink commands, detects that
> _MQ
> >> is not supported, hence it takes
> From: Michael S. Tsirkin
> Sent: Tuesday, July 26, 2022 3:49 PM
>
> On Tue, Jul 26, 2022 at 03:54:06PM +, Parav Pandit wrote:
> >
> > > From: Michael S. Tsirkin
> > > Sent: Wednesday, July 13, 2022 1:27 AM
> > >
> > > On Fri, Jul 01, 2022 at 10:07:59PM +, Parav Pandit wrote:
> > > >
> From: Michael S. Tsirkin
> Sent: Tuesday, July 26, 2022 3:52 PM
>
> On Tue, Jul 26, 2022 at 03:56:32PM +, Parav Pandit wrote:
> >
> > > From: Zhu, Lingshan
> > > Sent: Tuesday, July 12, 2022 11:46 PM
> > > > When the user space which invokes netlink commands, detects that
> > > > _MQ
> >
> From: Zhu, Lingshan
> Sent: Tuesday, July 12, 2022 11:46 PM
> > When the user space which invokes netlink commands, detects that _MQ
> is not supported, hence it takes max_queue_pair = 1 by itself.
> I think the kernel module have all necessary information and it is the only
> one which have
> From: Michael S. Tsirkin
> Sent: Wednesday, July 13, 2022 1:27 AM
>
> On Fri, Jul 01, 2022 at 10:07:59PM +, Parav Pandit wrote:
> >
> >
> > > From: Zhu Lingshan
> > > Sent: Friday, July 1, 2022 9:28 AM
> > > If VIRTIO_NET_F_MQ == 0, the virtio device should have one queue
> > > pair, so
> From: Zhu, Lingshan
> Sent: Tuesday, July 26, 2022 7:03 AM
>
> On 7/24/2022 11:21 PM, Parav Pandit wrote:
> >
> >> From: Zhu, Lingshan
> >> Sent: Saturday, July 23, 2022 7:24 AM
> >>
> >>
> >> On 7/22/2022 9:12 PM, Parav Pandit wrote:
> From: Zhu Lingshan
> Sent: Friday, July 22,
> From: Zhu, Lingshan
> Sent: Saturday, July 23, 2022 7:27 AM
>
> On 7/6/2022 10:25 AM, Zhu, Lingshan wrote:
> >
> >
> > On 7/6/2022 1:01 AM, Parav Pandit wrote:
> >>> From: Zhu, Lingshan
> >>> Sent: Tuesday, July 5, 2022 12:56 PM
> Both can be queried simultaneously. Each will return
> From: Zhu, Lingshan
> Sent: Saturday, July 23, 2022 7:24 AM
>
>
> On 7/22/2022 9:12 PM, Parav Pandit wrote:
> >> From: Zhu Lingshan
> >> Sent: Friday, July 22, 2022 7:53 AM
> >>
> >> This commit adds a new vDPA netlink attribution
> >> VDPA_ATTR_VDPA_DEV_SUPPORTED_FEATURES. Userspace can
> From: Zhu Lingshan
> Sent: Friday, July 22, 2022 7:53 AM
>
> If VIRTIO_NET_F_MQ == 0, the virtio device should have one queue pair, so
> when userspace querying queue pair numbers, it should return mq=1 than
> zero.
>
> Function vdpa_dev_net_config_fill() fills the attributions of the vDPA
> From: Zhu Lingshan
> Sent: Friday, July 22, 2022 7:53 AM
>
> This commit adds a new vDPA netlink attribution
> VDPA_ATTR_VDPA_DEV_SUPPORTED_FEATURES. Userspace can query
> features of vDPA devices through this new attr.
>
> Signed-off-by: Zhu Lingshan
> ---
> drivers/vdpa/vdpa.c |
> From: Zhu, Lingshan
> Sent: Tuesday, July 12, 2022 11:03 PM
>
>
> On 7/13/2022 12:48 AM, Parav Pandit wrote:
> >> From: Zhu, Lingshan
> >> Sent: Sunday, July 10, 2022 10:30 PM
> >>> Showing max_vq_pairs of 1 even when _MQ is not negotiated,
> >>> incorrectly
> >> says that max_vq_pairs is
> From: Zhu, Lingshan
> Sent: Sunday, July 10, 2022 10:30 PM
> > Showing max_vq_pairs of 1 even when _MQ is not negotiated, incorrectly
> says that max_vq_pairs is exposed to the guest, but it is not offered.
> >
> > So, please fix the iproute2 to not print max_vq_pairs when it is not
>
> From: Zhu, Lingshan
> Sent: Friday, July 8, 2022 2:21 AM
>
>
> On 7/2/2022 6:07 AM, Parav Pandit wrote:
> >
> >> From: Zhu Lingshan
> >> Sent: Friday, July 1, 2022 9:28 AM
> >> If VIRTIO_NET_F_MQ == 0, the virtio device should have one queue
> >> pair, so when userspace querying queue pair
> From: Zhu, Lingshan
> Sent: Friday, July 8, 2022 2:16 AM
>
> On 7/2/2022 6:02 AM, Parav Pandit wrote:
> >
> >> From: Zhu Lingshan
> >> Sent: Friday, July 1, 2022 9:28 AM
> >>
> >> This commit adds a new vDPA netlink attribution
> >> VDPA_ATTR_VDPA_DEV_SUPPORTED_FEATURES. Userspace can
> From: Zhu, Lingshan
> Sent: Friday, July 8, 2022 2:25 AM
>
>
> On 7/2/2022 6:18 AM, Parav Pandit wrote:
> >> From: Zhu Lingshan
> >> Sent: Friday, July 1, 2022 9:28 AM
> >>
> >> This commit fixes spars warnings: cast to restricted __le16 in
> >> function
> >> vdpa_dev_net_config_fill() and
> From: Zhu, Lingshan
> Sent: Tuesday, July 5, 2022 10:25 PM
> 1. When migrate the VM to a node which has a more resourceful device. If
> the source side device does not have MQ, RSS or TSO feature, the vDPA
> device assigned to the VM does not have MQ, RSS or TSO as well. When
> migrating to a
1 - 100 of 290 matches
Mail list logo
