Re: [PATCH RFC 10/17] acpi: Do not use dev->iommu within acpi_iommu_configure()

2023-11-06 Thread Rafael J. Wysocki
>iommu under a lock. > > Signed-off-by: Jason Gunthorpe Acked-by: Rafael J. Wysocki > --- > drivers/acpi/arm64/iort.c | 39 - > drivers/acpi/scan.c | 89 ++- > drivers/acpi/viot.c | 44 ++- >

Re: [PATCH RFC 04/17] acpi: Do not return struct iommu_ops from acpi_iommu_configure_id()

2023-11-06 Thread Rafael J. Wysocki
On Fri, Nov 3, 2023 at 5:45 PM Jason Gunthorpe wrote: > > Nothing needs this pointer. Return a normal error code with the usual > IOMMU semantic that ENODEV means 'there is no IOMMU driver'. > > Signed-off-by: Jason Gunthorpe Acked-by: Rafael J. Wysocki > ---

Re: [PATCH v6 2/5] ACPI: bus: Add stub acpi_sleep_state_supported() in non-ACPI cases

2023-02-13 Thread Rafael J. Wysocki
successful for !CONFIG_ACPI cases. > > Signed-off-by: Saurabh Sengar Acked-by: Rafael J. Wysocki and please feel free to toute this patch whichever way is convenient. Thanks! > --- > include/linux/acpi.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/include

Re: [PATCH 6/6] cpuidle: Fix poll_idle() noinstr annotation

2023-01-24 Thread Rafael J. Wysocki
instr, mark up the rest and let it rip. > > Fixes: 00717eb8c955 ("cpuidle: Annotate poll_idle()") > Signed-off-by: Peter Zijlstra (Intel) > Reported-by: kernel test robot > Link: > https://lore.kernel.org/oe-lkp/202301192148.58ece903-oliver.s...@intel.com Acked-by

Re: [PATCH v2 00/44] cpuidle,rcu: Clean up the mess

2022-09-19 Thread Rafael J. Wysocki
involved. > > Please all; have a look where you haven't already. > > > New since v1: > > - rebase on top of Frederic's rcu-context-tracking rename fest > - more omap goodness as per the last discusion (thanks Tony!) > - removed one more RCU_NONIDLE() from arm64

Re: [PATCH 04/36] cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE

2022-07-30 Thread Rafael J. Wysocki
On Sat, Jul 30, 2022 at 11:48 AM Michel Lespinasse wrote: > > On Fri, Jul 29, 2022 at 04:59:50PM +0200, Rafael J. Wysocki wrote: > > On Fri, Jul 29, 2022 at 12:25 PM Michel Lespinasse > > wrote: > > > > > > On Thu, Jul 28, 2022 at 10:20:53AM -0700, Paul E. Mc

Re: [PATCH 04/36] cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE

2022-07-29 Thread Rafael J. Wysocki
On Fri, Jul 29, 2022 at 12:25 PM Michel Lespinasse wrote: > > On Thu, Jul 28, 2022 at 10:20:53AM -0700, Paul E. McKenney wrote: > > On Mon, Jul 25, 2022 at 12:43:06PM -0700, Michel Lespinasse wrote: > > > On Wed, Jun 08, 2022 at 04:27:27PM +0200, Peter Zijlstra wrote: > > > > Commit c227233ad64c (

Re: [PATCH 31/36] cpuidle,acpi: Make noinstr clean

2022-07-06 Thread Rafael J. Wysocki
: warning: objtool: acpi_idle_enter+0x115: call to > acpi_idle_fallback_to_c1.isra.0() leaves .noinstr.text section > > Signed-off-by: Peter Zijlstra (Intel) Acked-by: Rafael J. Wysocki > --- > arch/x86/include/asm/shared/io.h |4 ++-- > drivers/acpi/processor_idle.c

Re: [PATCH 20/36] arch/idle: Change arch_cpu_idle() IRQ behaviour

2022-07-06 Thread Rafael J. Wysocki
at > architectures that can idle with IRQs disabled end up doing a > pointless 'enable-disable' dance. > > Therefore, push this IRQ disabling into the idle function, meaning > that those architectures can avoid the pointless IRQ state flipping. > > Signed-off-by: Pet

Re: [PATCH 18/36] cpuidle: Annotate poll_idle()

2022-07-06 Thread Rafael J. Wysocki
On Wed, Jun 8, 2022 at 4:46 PM Peter Zijlstra wrote: > > The __cpuidle functions will become a noinstr class, as such they need > explicit annotations. > > Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Rafael J. Wysocki > --- > drivers/cpuidle/poll_state.c |

Re: [PATCH 17/36] acpi_idle: Remove tracing

2022-07-06 Thread Rafael J. Wysocki
On Wed, Jun 8, 2022 at 4:47 PM Peter Zijlstra wrote: > > All the idle routines are called with RCU disabled, as such there must > not be any tracing inside. > > Signed-off-by: Peter Zijlstra (Intel) This actually does some additional code duplication cleanup which would be good to mention in the

Re: [PATCH 05/36] cpuidle: Move IRQ state validation

2022-07-06 Thread Rafael J. Wysocki
On Wed, Jun 8, 2022 at 4:47 PM Peter Zijlstra wrote: > > Make cpuidle_enter_state() consistent with the s2idle variant and > verify ->enter() always returns with interrupts disabled. > > Signed-off-by: Peter Zijlstra (Intel) > --- > drivers/cpuidle/cpuidle.c | 10 +- > 1 file changed,

Re: [PATCH 03/36] cpuidle/poll: Ensure IRQ state is invariant

2022-07-06 Thread Rafael J. Wysocki
On Wed, Jun 8, 2022 at 4:47 PM Peter Zijlstra wrote: > > cpuidle_state::enter() methods should be IRQ invariant > > Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Rafael J. Wysocki > --- > drivers/cpuidle/poll_state.c |4 +++- > 1 file changed, 3 inse

Re: [PATCH 02/36] x86/idle: Replace x86_idle with a static_call

2022-06-08 Thread Rafael J. Wysocki
On Wed, Jun 8, 2022 at 4:47 PM Peter Zijlstra wrote: > > Typical boot time setup; no need to suffer an indirect call for that. > > Signed-off-by: Peter Zijlstra (Intel) > Reviewed-by: Frederic Weisbecker Reviewed-by: Rafael J. Wysocki > --- > arch/x86/ke

Re: [PATCH 04/36] cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE

2022-06-08 Thread Rafael J. Wysocki
On Wed, Jun 8, 2022 at 5:48 PM Peter Zijlstra wrote: > > On Wed, Jun 08, 2022 at 05:01:05PM +0200, Rafael J. Wysocki wrote: > > On Wed, Jun 8, 2022 at 4:47 PM Peter Zijlstra wrote: > > > > > > Commit c227233ad64c ("intel_idle: enable interrupts before C1 on

Re: [PATCH 04/36] cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE

2022-06-08 Thread Rafael J. Wysocki
lly, it added a branch for no good reason. > > Fixes: c227233ad64c ("intel_idle: enable interrupts before C1 on Xeons") > Signed-off-by: Peter Zijlstra (Intel) Acked-by: Rafael J. Wysocki And do I think correctly that this can be applied without the rest of t

Re: [PATCH v7 01/12] driver: platform: Add helper for safer setting of driver_override

2022-04-20 Thread Rafael J. Wysocki
freed and hold newly allocated override. I would stick to one-line description here and possibly expand them in the body of the comment. Regardless, I think that the series is an improvement, so please feel free to add Reviewed-by: Rafael J. Wysocki to this patch and Acked-by: Rafael J. Wysoc

Re: [PATCH 02/17] Use memberof(T, m) instead of explicit NULL dereference

2021-11-23 Thread Rafael J. Wysocki
Len Brown > Cc: "Michael S. Tsirkin" > Cc: Miguel Ojeda > Cc: Mike Rapoport > Cc: Nick Desaulniers > Cc: "Rafael J. Wysocki" > Cc: Rasmus Villemoes > Cc: Rodrigo Vivi > Cc: Russell King > Cc: Somnath Kotur > Cc: Sriharsha Basavapatna &g

Re: [PATCH v2 1/6] driver core: Move the "authorized" attribute from USB/Thunderbolt to core

2021-09-30 Thread Rafael J. Wysocki
On Thu, Sep 30, 2021 at 6:59 AM Dan Williams wrote: > > On Wed, Sep 29, 2021 at 7:39 PM Kuppuswamy, Sathyanarayanan > wrote: > > > > > > > > On 9/29/21 6:55 PM, Dan Williams wrote: > > >> Also, you ignored the usb_[de]authorize_interface() functions and > > >> their friends. > > > Ugh, yes. > > >

Re: [RFC 0/3] cpuidle: add poll_source API and virtio vq polling

2021-07-26 Thread Rafael J. Wysocki
On Mon, Jul 26, 2021 at 6:04 PM Stefan Hajnoczi wrote: > > On Mon, Jul 26, 2021 at 05:47:19PM +0200, Rafael J. Wysocki wrote: > > On Mon, Jul 26, 2021 at 5:17 PM Stefan Hajnoczi wrote: > > > > > > On Thu, Jul 22, 2021 at 05:04:57PM +0800, Jason Wang wrote: >

Re: [RFC 0/3] cpuidle: add poll_source API and virtio vq polling

2021-07-26 Thread Rafael J. Wysocki
On Mon, Jul 26, 2021 at 5:17 PM Stefan Hajnoczi wrote: > > On Thu, Jul 22, 2021 at 05:04:57PM +0800, Jason Wang wrote: > > > > 在 2021/7/21 下午5:41, Stefan Hajnoczi 写道: > > > On Wed, Jul 21, 2021 at 11:29:55AM +0800, Jason Wang wrote: > > > > 在 2021/7/14 上午12:19, Stefan Hajnoczi 写道: > > > > > These

Re: [PATCH v2 4/4] bus: Make remove callback return void

2021-07-06 Thread Rafael J. Wysocki
álvez (For ipack) > Reviewed-by: Tom Rix (For fpga) > Acked-by: Geoff Levand (For ps3) > Signed-off-by: Uwe Kleine-König For the ACPI part: Acked-by: Rafael J. Wysocki > --- > > arch/arm/common/locomo.c | 3 +-- > arch/arm/common/sa.c

Re: [PATCH v5 3/5] ACPI: Add driver for the VIOT table

2021-06-18 Thread Rafael J. Wysocki
Eric Auger > Signed-off-by: Jean-Philippe Brucker >From the general ACPI perspective Acked-by: Rafael J. Wysocki and I'm assuming that it will be routed through a different tree. > --- > drivers/acpi/Kconfig | 3 + > drivers/iommu/Kconfig | 1 + > drivers/

Re: [PATCH v4 3/6] ACPI: Add driver for the VIOT table

2021-06-17 Thread Rafael J. Wysocki
On Thu, Jun 10, 2021 at 10:03 AM Jean-Philippe Brucker wrote: > > The ACPI Virtual I/O Translation Table describes topology of > para-virtual platforms, similarly to vendor tables DMAR, IVRS and IORT. > For now it describes the relation between virtio-iommu and the endpoints > it manages. > > Thre

Re: [PATCH v1 09/12] ACPI: memhotplug: use a single static memory group for a single memory device

2021-06-08 Thread Rafael J. Wysocki
system > (e.g., via e820) -- usually *all* memory of a memory device was already > added and we'll fail acpi_memory_enable_device(). > > Signed-off-by: David Hildenbrand Acked-by: Rafael J. Wysocki > --- > drivers/acpi/acpi_memhotplug.c | 35 +

Re: [PATCH v1 08/12] ACPI: memhotplug: memory resources cannot be enabled yet

2021-06-08 Thread Rafael J. Wysocki
On Mon, Jun 7, 2021 at 9:55 PM David Hildenbrand wrote: > > We allocate + initialize everything from scratch. In case enabling the > device fails, we free all memory resourcs. > > Signed-off-by: David Hildenbrand Acked-by: Rafael J. Wysocki > --- > drivers/acpi/

Re: [PATCH v2 2/6] ACPI: Move IOMMU setup code out of IORT

2021-05-21 Thread Rafael J. Wysocki
On Fri, Apr 23, 2021 at 1:57 PM Jean-Philippe Brucker wrote: > > Some of the IOMMU setup code in IORT is fairly generic and can be reused > by VIOT. Extract it from IORT. Except that iort_iommu_configure_id() is not really generic AFAICS. ___ Virtualiza

Re: [PATCH v2 3/6] ACPI: Add driver for the VIOT table

2021-05-21 Thread Rafael J. Wysocki
On Fri, Apr 23, 2021 at 1:57 PM Jean-Philippe Brucker wrote: > > The ACPI Virtual I/O Translation Table describes topology of > para-virtual platforms, similarly to vendor tables DMAR, IVRS and IORT. > For now it describes the relation between virtio-iommu and the endpoints > it manages. > > Three

Re: [PATCH v6 08/16] ACPI / NUMA: add a stub function for node_to_pxm()

2021-02-04 Thread Rafael J. Wysocki
On Thu, Feb 4, 2021 at 7:41 PM Wei Liu wrote: > > On Wed, Feb 03, 2021 at 03:04:27PM +, Wei Liu wrote: > > There is already a stub function for pxm_to_node but conversion to the > > other direction is missing. > > > > It will be used by Microsoft Hypervisor code later. > > > > Signed-off-by: W

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-23 Thread Rafael J. Wysocki
On Mon, Nov 23, 2020 at 4:58 PM James Bottomley wrote: > > On Mon, 2020-11-23 at 15:19 +0100, Miguel Ojeda wrote: > > On Sun, Nov 22, 2020 at 11:36 PM James Bottomley > > wrote: [cut] > > > > Maintainers routinely review 1-line trivial patches, not to mention > > internal API changes, etc. > >

Re: [RFC]: mm,power: introduce MADV_WIPEONSUSPEND

2020-07-03 Thread Rafael J. Wysocki
On Fri, Jul 3, 2020 at 1:30 PM Michal Hocko wrote: > > On Fri 03-07-20 10:34:09, Catangiu, Adrian Costin wrote: > > This patch adds logic to the kernel power code to zero out contents of > > all MADV_WIPEONSUSPEND VMAs present in the system during its transition > > to any suspend state equal or g

Re: [PATCH RFC v4 01/13] ACPI: NUMA: export pxm_to_node

2019-12-13 Thread Rafael J. Wysocki
On Fri, Dec 13, 2019 at 10:41 AM David Hildenbrand wrote: > > On 12.12.19 22:43, Rafael J. Wysocki wrote: > > On Thursday, December 12, 2019 6:11:25 PM CET David Hildenbrand wrote: > >> Will be needed by virtio-mem to identify the node from a pxm. > >> > >>

Re: [PATCH 10/10] docs: fix broken documentation links

2019-05-27 Thread Rafael J. Wysocki
On Mon, May 20, 2019 at 4:48 PM Mauro Carvalho Chehab wrote: > > Mostly due to x86 and acpi conversion, several documentation > links are still pointing to the old file. Fix them. > > Signed-off-by: Mauro Carvalho Chehab For the ACPI part: Acked-by: Ra

Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

2017-02-24 Thread Rafael J. Wysocki
On Fri, Feb 17, 2017 at 8:11 AM, Joe Perches wrote: > There are ~4300 uses of pr_warn and ~250 uses of the older > pr_warning in the kernel source tree. > > Make the use of pr_warn consistent across all kernel files. > > This excludes all files in tools/ as there is a separate > define pr_warning

Re: [Announcement] Linux Plumbers ACPI/PM, PCI Microconference

2013-07-31 Thread Rafael J. Wysocki
On Wednesday, July 31, 2013 10:35:05 AM Shuah Khan wrote: > On Wed, Jul 31, 2013 at 5:40 AM, Rafael J. Wysocki wrote: > > Hi All, > > > > The original announcement didn't go to linux-pm, so again: > > > > On Tuesday, July 16, 2013 08:21:26 PM Myron Stowe wrot

[Announcement] Linux Plumbers ACPI/PM, PCI Microconference

2013-07-31 Thread Rafael J. Wysocki
Hi All, The original announcement didn't go to linux-pm, so again: On Tuesday, July 16, 2013 08:21:26 PM Myron Stowe wrote: > Linux Plumbers has approved an ACPI/PM, PCI microconference. The > overview page is here: > > http://wiki.linuxplumbersconf.org/2013:pci_subsystem > > We would like to s

Re: Linux Plumbers ACPI/PM, PCI Microconference

2013-07-30 Thread Rafael J. Wysocki
On Wednesday, July 17, 2013 08:31:55 AM Shuah Khan wrote: > Myron, > > On Tue, Jul 16, 2013 at 8:21 PM, Myron Stowe wrote: > > > > > Shuah - You brought up the idea about "Converting drivers from Legacy > > PM ops to dev_pm_ops"; would you like to present what you have > > done/encountered so fa

Re: [PATCH v4 01/12] virtio: pci: switch to new PM API

2011-12-07 Thread Rafael J. Wysocki
On Wednesday, December 07, 2011, Amit Shah wrote: > On (Wed) 07 Dec 2011 [10:48:24], Rafael J. Wysocki wrote: > > On Wednesday, December 07, 2011, Amit Shah wrote: > > > Hi Rafael, > > > > > > On (Tue) 06 Dec 2011 [23:12:36], Rafael J. Wysocki wrote: >

Re: [PATCH v4 01/12] virtio: pci: switch to new PM API

2011-12-07 Thread Rafael J. Wysocki
On Wednesday, December 07, 2011, Amit Shah wrote: > Hi Rafael, > > On (Tue) 06 Dec 2011 [23:12:36], Rafael J. Wysocki wrote: > > Hi, > > > > On Tuesday, December 06, 2011, Amit Shah wrote: > > > The older PM API doesn't have a way to get notifications

Re: [PATCH v4 01/12] virtio: pci: switch to new PM API

2011-12-06 Thread Rafael J. Wysocki
Hi, On Tuesday, December 06, 2011, Amit Shah wrote: > The older PM API doesn't have a way to get notifications on hibernate > events. Switch to the newer one that gives us those notifications. > > Signed-off-by: Amit Shah > --- > drivers/virtio/virtio_pci.c | 16 > 1 files c

Re: 2.6.29 git, resume from ram broken on thinkpad

2009-04-02 Thread Rafael J. Wysocki
On Thursday 02 April 2009, Ingo Molnar wrote: > > * Rafael J. Wysocki wrote: > > > On Thursday 02 April 2009, Chris Wright wrote: > > > * Rafael J. Wysocki (r...@sisk.pl) wrote: > > > > Sorry for the misunderstanding, I thought the breakage might be

Re: 2.6.29 git, resume from ram broken on thinkpad

2009-04-02 Thread Rafael J. Wysocki
On Thursday 02 April 2009, Chris Wright wrote: > * Rafael J. Wysocki (r...@sisk.pl) wrote: > > Sorry for the misunderstanding, I thought the breakage might be introduced > > between 15f7176eb1cccec0a332541285ee752b935c1c85 and > > 0a0c5168df270a50e3518e4f12bddb31f8f5f38f, so

Re: 2.6.29 git, resume from ram broken on thinkpad

2009-04-01 Thread Rafael J. Wysocki
On Thursday 02 April 2009, Chris Wright wrote: > * Rafael J. Wysocki (r...@sisk.pl) wrote: > > On Wednesday 01 April 2009, Chris Wright wrote: > > > * Rafael J. Wysocki (r...@sisk.pl) wrote: > > > > This may be caused by the recent PM changes. Can you

Re: 2.6.29 git, resume from ram broken on thinkpad

2009-04-01 Thread Rafael J. Wysocki
On Wednesday 01 April 2009, Chris Wright wrote: > * Rafael J. Wysocki (r...@sisk.pl) wrote: > > This may be caused by the recent PM changes. Can you please test if commit > > 8efb8c76fcdccf5050c0ea059dac392789baaff2 is fine? > > I just tested on my t400, it's not

Re: 2.6.29 git, resume from ram broken on thinkpad

2009-04-01 Thread Rafael J. Wysocki
On Wednesday 01 April 2009, Arkadiusz Miskiewicz wrote: > > Hi, > > After some recent merge to Linus tree resume from ram on my thinkpad t400 > stopped working. My latest test was done on today Linus git master tree. > > I'm closing lid, it suspends according to "moon" led. When I open lid I se

Re: [PATCH 4/8] unify paravirt parts of system.h

2007-12-17 Thread Rafael J. Wysocki
On Saturday, 15 of December 2007, Ingo Molnar wrote: > > * Pavel Machek <[EMAIL PROTECTED]> wrote: > > > > Linux never uses that register. The only user is suspend > > > save/restore, but that' bogus because it wasn't ever initialized by > > > Linux in the first place. It could be probably all

Re: [PATCH 4/8] unify paravirt parts of system.h

2007-12-17 Thread Rafael J. Wysocki
On Monday, 17 of December 2007, Pavel Machek wrote: > On Mon 2007-12-17 01:27:29, Rafael J. Wysocki wrote: > > On Saturday, 15 of December 2007, Ingo Molnar wrote: > > > > > > * Pavel Machek <[EMAIL PROTECTED]> wrote: > > > > > > > >