Re: [PATCH] virtio: a new vcpu watchdog driver

2023-07-30 Thread Randy Dunlap
Hi-- On 7/30/23 18:25, zhanghao1 wrote: > A new virtio pci driver is added for listening to vcpus > inside guest. Each vcpu creates a corresponding thread to > periodically send data to qemu's back-end watchdog device. > If a vCPU is in the stall state, data cannot be sent to > back-end virtio

Re: [PATCH virtio] pds_vdpa: protect Makefile from unconfigured debugfs

2023-07-06 Thread Randy Dunlap
tps://lore.kernel.org/linux-next/fec68c3c-8249-7af4-5390-0495386a7...@infradead.org/ > Fixes: a16291b5bcbb ("pds_vdpa: Add new vDPA driver for AMD/Pensando DSC") > Signed-off-by: Shannon Nelson Reviewed-by: Randy Dunlap Tested-by: Randy Dunlap # build-tested Thanks. > --- &

Re: linux-next: Tree for Jul 6 [drivers/vdpa/pds/pds_vdpa.ko]

2023-07-06 Thread Randy Dunlap
On 7/5/23 18:57, Stephen Rothwell wrote: > Hi all, > > Please do *not* add any v6.6 related stuff to your linux-next included > branches until after v6.5-rc1 has been released. > > Changes since 20230705: > On loongarch, when DEBUG_FS is not set: ERROR: modpost:

[PATCH] Documentation: virt: clean up paravirt_ops doc.

2023-06-09 Thread Randy Dunlap
Clarify language. Clean up grammar. Hyphenate some words. Change "low-ops" to "low-level" since "low-ops" isn't defined or even mentioned anywhere else in the kernel source tree. Signed-off-by: Randy Dunlap Cc: Juergen Gross Cc: Ajay Kaher Cc: Alexey Makhalov C

Re: [PATCH 4/9] netfilter: h323: eliminate anonymous module_init & module_exit

2022-03-17 Thread Randy Dunlap
On 3/17/22 08:49, Pablo Neira Ayuso wrote: > On Wed, Mar 16, 2022 at 12:20:05PM -0700, Randy Dunlap wrote: >> Eliminate anonymous module_init() and module_exit(), which can lead to >> confusion or ambiguity when reading System.map, crashes/oops/bugs, >> or an initcall_debug

Re: [PATCH 2/9] virtio_console: eliminate anonymous module_init & module_exit

2022-03-17 Thread Randy Dunlap
On 3/17/22 08:47, Amit Shah wrote: > On Wed, 2022-03-16 at 12:20 -0700, Randy Dunlap wrote: >> Eliminate anonymous module_init() and module_exit(), which can lead to >> confusion or ambiguity when reading System.map, crashes/oops/bugs, >> or an initcall_debug log. >>

Re: [PATCH 6/9] usb: gadget: eliminate anonymous module_init & module_exit

2022-03-17 Thread Randy Dunlap
On 3/16/22 20:29, Ira Weiny wrote: > On Wed, Mar 16, 2022 at 12:20:07PM -0700, Randy Dunlap wrote: >> Eliminate anonymous module_init() and module_exit(), which can lead to >> confusion or ambiguity when reading System.map, crashes/oops/bugs, >> or an initcall_debug

[PATCH 1/9] virtio_blk: eliminate anonymous module_init & module_exit

2022-03-16 Thread Randy Dunlap
init+0x0/0x9a returned 0 after 74 usecs Fixes: e467cde23818 ("Block driver using virtio.") Signed-off-by: Randy Dunlap Cc: "Michael S. Tsirkin" Cc: Jason Wang Cc: Paolo Bonzini Cc: Stefan Hajnoczi Cc: virtualization@lists.linux-foundation.org Cc: Jens Axboe Cc: linux-b

[PATCH 9/9] testmmiotrace: eliminate anonymous module_init & module_exit

2022-03-16 Thread Randy Dunlap
init+0x0/0x9a returned 0 after 74 usecs Fixes: 8b7d89d02ef3 ("x86: mmiotrace - trace memory mapped IO") Signed-off-by: Randy Dunlap Cc: Thomas Gleixner Cc: Steven Rostedt Cc: Ingo Molnar Cc: Karol Herbst Cc: Pekka Paalanen Cc: Dave Hansen Cc: Andy Lutomirski Cc: Peter Zijlstra Cc

[PATCH 5/9] virtio-scsi: eliminate anonymous module_init & module_exit

2022-03-16 Thread Randy Dunlap
init+0x0/0x9a returned 0 after 74 usecs Fixes: 4fe74b1cb051 ("[SCSI] virtio-scsi: SCSI driver for QEMU based virtual machines") Signed-off-by: Randy Dunlap Cc: "Michael S. Tsirkin" Cc: Jason Wang Cc: Paolo Bonzini Cc: Stefan Hajnoczi Cc: "James E.J. Bottomley"

[PATCH 0/9] treewide: eliminate anonymous module_init & module_exit

2022-03-16 Thread Randy Dunlap
There are a number of drivers that use "module_init(init)" and "module_exit(exit)", which are anonymous names and can lead to confusion or ambiguity when reading System.map, crashes/oops/bugs, or an initcall_debug log. Give each of these init and exit functions unique driver-specific names to

[PATCH 8/9] x86/crypto: eliminate anonymous module_init & module_exit

2022-03-16 Thread Randy Dunlap
hould be static") Fixes: 8280daad436e ("crypto: twofish - add 3-way parallel x86_64 assembler implemention") Signed-off-by: Randy Dunlap Cc: Jussi Kivilinna Cc: Joachim Fritschi Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-cry...@vger.kernel.org Cc: x...@kern

[PATCH 6/9] usb: gadget: eliminate anonymous module_init & module_exit

2022-03-16 Thread Randy Dunlap
init+0x0/0x9a returned 0 after 74 usecs Fixes: bd25a14edb75 ("usb: gadget: legacy/serial: allow dynamic removal") Fixes: 7bb5ea54be47 ("usb gadget serial: use composite gadget framework") Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Randy Dunlap Cc: Felipe

[PATCH 4/9] netfilter: h323: eliminate anonymous module_init & module_exit

2022-03-16 Thread Randy Dunlap
init+0x0/0x9a returned 0 after 74 usecs Fixes: f587de0e2feb ("[NETFILTER]: nf_conntrack/nf_nat: add H.323 helper port") Signed-off-by: Randy Dunlap Cc: Pablo Neira Ayuso Cc: Jozsef Kadlecsik Cc: Florian Westphal Cc: netfilter-de...@vger.kernel.org Cc: coret...@netfilter.org Cc: "

[PATCH 2/9] virtio_console: eliminate anonymous module_init & module_exit

2022-03-16 Thread Randy Dunlap
init+0x0/0x9a returned 0 after 74 usecs Fixes: 31610434bc35 ("Virtio console driver") Fixes: 7177876fea83 ("virtio: console: Add ability to remove module") Signed-off-by: Randy Dunlap Cc: Amit Shah Cc: virtualization@lists.linux-foundation.org Cc: Arnd Bergmann Cc

[PATCH 3/9] net: mlx5: eliminate anonymous module_init & module_exit

2022-03-16 Thread Randy Dunlap
init+0x0/0x9a returned 0 after 74 usecs Fixes: e126ba97dba9 ("mlx5: Add driver for Mellanox Connect-IB adapters") Signed-off-by: Randy Dunlap Cc: Eli Cohen Cc: Saeed Mahameed Cc: net...@vger.kernel.org Cc: Leon Romanovsky Cc: linux-r...@vger.kernel.org --- drivers/net/ethernet/mel

[PATCH 7/9] usb: usbip: eliminate anonymous module_init & module_exit

2022-03-16 Thread Randy Dunlap
init+0x0/0x9a returned 0 after 74 usecs Fixes: 80fd9cd52de6 ("usbip: vudc: Add VUDC main file") Signed-off-by: Randy Dunlap Cc: Krzysztof Opasiak Cc: Igor Kotrasinski Cc: Greg Kroah-Hartman Cc: Valentina Manea Cc: Shuah Khan Cc: Shuah Khan Cc: linux-...@vger.kernel.org --- drivers

Re: [PATCH v5 8/8] eni_vdpa: add vDPA driver for Alibaba ENI

2021-10-15 Thread Randy Dunlap
On 10/15/21 12:15 AM, Wu Zongyong wrote: diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig index 3d91982d8371..c0232a2148a7 100644 --- a/drivers/vdpa/Kconfig +++ b/drivers/vdpa/Kconfig @@ -78,4 +78,12 @@ config VP_VDPA help This kernel module bridges virtio PCI device to

Re: [PATCH v5 16/16] x86/tdx: Add cmdline option to force use of ioremap_host_shared

2021-10-08 Thread Randy Dunlap
On 10/8/21 5:37 PM, Kuppuswamy Sathyanarayanan wrote: diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index 91ba391f9b32..0af19cb1a28c 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++

[PATCH] VDUSE: fix documentation underline warning

2021-10-06 Thread Randy Dunlap
Fix a VDUSE documentation build warning: Documentation/userspace-api/vduse.rst:21: WARNING: Title underline too short. Fixes: 7bc7f61897b6 ("Documentation: Add documentation for VDUSE") Signed-off-by: Randy Dunlap Cc: Xie Yongji Cc: Jason Wang Cc: Michael S. Tsirkin Cc: virt

Re: [PATCH v2 1/5] virtio-pci: introduce legacy device module

2021-09-14 Thread Randy Dunlap
On 9/14/21 5:24 AM, Wu Zongyong wrote: diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig index ce1b3f6ec325..b14768dc9e04 100644 --- a/drivers/virtio/Kconfig +++ b/drivers/virtio/Kconfig @@ -20,6 +20,15 @@ config VIRTIO_PCI_LIB PCI device with possible vendor specific

Re: [PATCH v2 5/5] eni_vdpa: add vDPA driver for Alibaba ENI

2021-09-14 Thread Randy Dunlap
On 9/14/21 5:24 AM, Wu Zongyong wrote: diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig index 3d91982d8371..9587b9177b05 100644 --- a/drivers/vdpa/Kconfig +++ b/drivers/vdpa/Kconfig @@ -78,4 +78,12 @@ config VP_VDPA help This kernel module bridges virtio PCI device to

Re: [PATCH 03/19] drivers/hv: minimal mshv module (/dev/mshv/)

2021-05-28 Thread Randy Dunlap
On 5/28/21 3:43 PM, Nuno Das Neves wrote: > Introduce a barebones module file for the mshv API. > Introduce CONFIG_HYPERV_ROOT_API for controlling compilation of mshv. > > Co-developed-by: Lillian Grassin-Drake > Signed-off-by: Lillian Grassin-Drake > Signed-off-by: Nuno Das Neves > --- Hi,

[PATCH] sound: virtio: correct the function name in kernel-doc comment

2021-04-14 Thread Randy Dunlap
Fix kernel-doc warning that the wrong function name is used in a kernel-doc comment: ../sound/virtio/virtio_ctl_msg.c:70: warning: expecting prototype for virtsnd_ctl_msg_request(). Prototype was for virtsnd_ctl_msg_response() instead Signed-off-by: Randy Dunlap Cc: Anton Yakovlev Cc

Re: linux-next: Tree for Mar 11 [drivers/vdpa/virtio_pci/vp_vdpa.ko]

2021-03-11 Thread Randy Dunlap
o_pci/vp_vdpa.ko] undefined! ERROR: modpost: "vp_modern_generation" [drivers/vdpa/virtio_pci/vp_vdpa.ko] undefined! ERROR: modpost: "vp_modern_remove" [drivers/vdpa/virtio_pci/vp_vdpa.ko] undefined! Full randconfig file is attached. -- ~Randy Reported-by:

Re: [RFC v3 08/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-01-19 Thread Randy Dunlap
Hi, Documentation comments only: On 1/18/21 9:07 PM, Xie Yongji wrote: > > Signed-off-by: Xie Yongji > --- > Documentation/driver-api/vduse.rst | 85 ++ > > diff --git a/Documentation/driver-api/vduse.rst > b/Documentation/driver-api/vduse.rst > new file mode 100644 > index

Re: [PATCH v3] drivers: gpio: add virtio-gpio guest driver

2020-12-07 Thread Randy Dunlap
On 12/7/20 12:48 PM, Enrico Weigelt, metux IT consult wrote: > Introducing new GPIO driver for virtual GPIO devices via virtio. > Oops, I missed one thing: > > diff --git a/Documentation/gpio/virtio-gpio.rst > b/Documentation/gpio/virtio-gpio.rst > new file mode 100644 > index

Re: [PATCH v3] drivers: gpio: add virtio-gpio guest driver

2020-12-07 Thread Randy Dunlap
On 12/7/20 12:48 PM, Enrico Weigelt, metux IT consult wrote: > Introducing new GPIO driver for virtual GPIO devices via virtio. Introduce > > The driver allows routing GPIO control into VM guests, eg. brigding > virtual gpios to specific host gpios, or attaching simulators for > automatic

Re: [PATCH V2 19/19] vdpa: introduce virtio pci driver

2020-12-04 Thread Randy Dunlap
On 12/4/20 7:20 AM, Stefano Garzarella wrote: > On Fri, Dec 04, 2020 at 12:03:53PM +0800, Jason Wang wrote: >> This patch introduce a vDPA driver for virtio-pci device. It bridges >> the virtio-pci control command to the vDPA bus. This will be used for >> features prototyping and testing. >> >>

Re: [PATCH V2 16/19] virtio-pci: introduce modern device module

2020-12-04 Thread Randy Dunlap
Hi Jason-- On 12/3/20 8:03 PM, Jason Wang wrote: > diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig > index 7b41130d3f35..d1a6bd2a975f 100644 > --- a/drivers/virtio/Kconfig > +++ b/drivers/virtio/Kconfig > @@ -12,6 +12,14 @@ config ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS >

Re: [PATCH v3 02/19] vdpa_sim: remove unnecessary headers inclusion

2020-12-03 Thread Randy Dunlap
On 12/3/20 9:04 AM, Stefano Garzarella wrote: > Some headers are not necessary, so let's remove them to do > some cleaning. > > Signed-off-by: Stefano Garzarella Hi, What makes you say that some of these are unnecessary? Please use Rule #1 from Documentation/process/submit-checklist.rst: 1)

Re: [PATCH v3 19/19] vdpa: split vdpasim to core and net modules

2020-12-03 Thread Randy Dunlap
Hi, On 12/3/20 9:05 AM, Stefano Garzarella wrote: > diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig > index 2c892e890b9e..b0f91ad8eb47 100644 > --- a/drivers/vdpa/Kconfig > +++ b/drivers/vdpa/Kconfig > @@ -9,15 +9,20 @@ menuconfig VDPA > if VDPA > > config VDPA_SIM > - tristate

[PATCH v4] vdpa: mlx5: fix vdpa/vhost dependencies

2020-11-28 Thread Randy Dunlap
] undefined! Fixes: 29064bfdabd5 ("vdpa/mlx5: Add support library for mlx5 VDPA implementation") Fixes: aff90770e54c ("vdpa/mlx5: Fix dependency on MLX5_CORE") Reported-by: kernel test robot Signed-off-by: Randy Dunlap Cc: Eli Cohen Cc: Parav Pandit Cc: "Michael S. Tsirkin&quo

Re: [PATCH] drivers: gpio: add virtio-gpio guest driver

2020-11-27 Thread Randy Dunlap
On 11/27/20 10:30 AM, Enrico Weigelt, metux IT consult wrote: > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > index 5d4de5cd6759..e8414d82cf75 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -1613,4 +1613,13 @@ config GPIO_MOCKUP >

Re: [PATCH] vdpasim: fix "mac_pton" undefined error

2020-11-13 Thread Randy Dunlap
On 11/13/20 10:49 AM, Randy Dunlap wrote: > On 11/13/20 7:57 AM, Laurent Vivier wrote: >>ERROR: modpost: "mac_pton" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined! >> >> mac_pton() is defined in lib/net_utils.c and is not built if NET is not set. >> &

Re: [PATCH] vdpasim: fix "mac_pton" undefined error

2020-11-13 Thread Randy Dunlap
> Reported-by: kernel test robot On Nov. 2, 2020: Reported-by: Randy Dunlap https://lore.kernel.org/lkml/d3d50a94-cdc5-572b-e9ca-3ee5638d2...@infradead.org/ > Signed-off-by: Laurent Vivier > --- > drivers/vdpa/Kconfig | 1 + > 1 file changed, 1 insertion(+) > >

Re: linux-next: Tree for Nov 2 [drivers/vdpa/vdpa_sim/vdpa_sim.ko]

2020-11-02 Thread Randy Dunlap
-- ~Randy Reported-by: Randy Dunlap ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [RFC 2/4] vduse: Introduce VDUSE - vDPA Device in Userspace

2020-10-19 Thread Randy Dunlap
On 10/19/20 8:08 AM, Michael S. Tsirkin wrote: > On Mon, Oct 19, 2020 at 10:56:21PM +0800, Xie Yongji wrote: >> diff --git a/include/uapi/linux/vduse.h b/include/uapi/linux/vduse.h >> +#define VDUSE_BASE 'V' >> + > > Could we see some documentation about the user interface of this module >

Re: [External] Re: [PATCH] mm: proc: add Sock to /proc/meminfo

2020-10-13 Thread Randy Dunlap
On 10/13/20 8:12 AM, Mike Rapoport wrote: > On Tue, Oct 13, 2020 at 07:43:59AM -0700, Randy Dunlap wrote: >> On 10/13/20 1:09 AM, Mike Rapoport wrote: >>> On Mon, Oct 12, 2020 at 05:53:01PM +0800, Muchun Song wrote: >>>> On Mon, Oct 12, 2020 at 5:24 PM Eric Dumazet

Re: [External] Re: [PATCH] mm: proc: add Sock to /proc/meminfo

2020-10-13 Thread Randy Dunlap
On 10/13/20 1:09 AM, Mike Rapoport wrote: > On Mon, Oct 12, 2020 at 05:53:01PM +0800, Muchun Song wrote: >> On Mon, Oct 12, 2020 at 5:24 PM Eric Dumazet wrote: >>> >>> On 10/12/20 10:39 AM, Muchun Song wrote: On Mon, Oct 12, 2020 at 3:42 PM Eric Dumazet wrote: > > On Mon, Oct 12,

Re: [PATCH] mm: proc: add Sock to /proc/meminfo

2020-10-10 Thread Randy Dunlap
Hi, On 10/10/20 3:38 AM, Muchun Song wrote: > The amount of memory allocated to sockets buffer can become significant. > However, we do not display the amount of memory consumed by sockets > buffer. In this case, knowing where the memory is consumed by the kernel > is very difficult. On our

Re: [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors

2020-09-24 Thread Randy Dunlap
On 9/24/20 3:24 AM, Eli Cohen wrote: > On Thu, Sep 24, 2020 at 05:30:55AM -0400, Michael S. Tsirkin wrote: --- linux-next-20200917.orig/drivers/vdpa/Kconfig +++ linux-next-20200917/drivers/vdpa/Kconfig @@ -31,7 +31,7 @@ config IFCVF config MLX5_VDPA bool "MLX5

[PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors

2020-09-17 Thread Randy Dunlap
From: Randy Dunlap drivers/vdpa/mlx5/ uses vhost_iotlb*() interfaces, so add a dependency on VHOST to eliminate build errors. ld: drivers/vdpa/mlx5/core/mr.o: in function `add_direct_chain': mr.c:(.text+0x106): undefined reference to `vhost_iotlb_itree_first' ld: mr.c:(.text+0x1cf): undefined

[PATCH v2 -next] vdpa: mlx5: change Kconfig depends to fix build errors

2020-09-17 Thread Randy Dunlap
From: Randy Dunlap drivers/vdpa/mlx5/ uses vhost_iotlb*() interfaces, so add a dependency on VHOST to eliminate build errors. ld: drivers/vdpa/mlx5/core/mr.o: in function `add_direct_chain': mr.c:(.text+0x106): undefined reference to `vhost_iotlb_itree_first' ld: mr.c:(.text+0x1cf): undefined

[PATCH -next] vdpa: mlx5: select VHOST to fix build errors

2020-09-17 Thread Randy Dunlap
From: Randy Dunlap drivers/vdpa/mlx5/ uses vhost_iotlb*() interfaces, so select VHOST to eliminate build errors. ld: drivers/vdpa/mlx5/core/mr.o: in function `add_direct_chain': mr.c:(.text+0x106): undefined reference to `vhost_iotlb_itree_first' ld: mr.c:(.text+0x1cf): undefined reference

Re: [PATCH v2] i2c: virtio: add a virtio i2c frontend driver

2020-09-10 Thread Randy Dunlap
On 9/10/20 8:48 PM, Jie Deng wrote: > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index 293e7a0..70c8e30 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -21,6 +21,17 @@ config I2C_ALI1535 > This driver can also be built as a

Re: [PATCH] vdpa/mlx5: Avoid warnings about shifts on 32-bit platforms

2020-08-21 Thread Randy Dunlap
Add VDPA driver for supported mlx5 devices") > Link: https://github.com/ClangBuiltLinux/linux/issues/1140 > Signed-off-by: Nathan Chancellor Reported-by: Randy Dunlap on 2020-AUG-10 for i386: https://lore.kernel.org/linux-next/5a7a0e6d-842a-78f6-aeac-c5b4c27b7...@infradead.org/ :( Acked-by:

Re: linux-next: Tree for Aug 10 (drivers/vdpa/mlx5/net)

2020-08-10 Thread Randy Dunlap
IO_F_ACCESS_PLATFORM) | \ ^~~ ../drivers/vdpa/mlx5/net/mlx5_vnet.c:186:18: note: in expansion of macro 'VALID_FEATURES_MASK' if (features & ~VALID_FEATURES_MASK) ^~~ -- ~Randy Reported-by: Randy Dunlap __

Re: linux-next: Tree for Apr 15 (vdpa)

2020-04-15 Thread Randy Dunlap
ERROR: modpost: "vringh_getdesc_iotlb" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined! Full randconfig file is attached. -- ~Randy Reported-by: Randy Dunlap # # Automatically generated file; DO NOT EDIT. # Linux/x86_64 5.7.0-rc1 Kernel Configuration # # # Compiler: gcc (SUSE Linu

Re: mmotm 2020-03-30-18-46 uploaded (VDPA + vhost)

2020-04-01 Thread Randy Dunlap
On 3/31/20 12:22 PM, Michael S. Tsirkin wrote: > On Tue, Mar 31, 2020 at 11:42:47AM -0700, Randy Dunlap wrote: >> On 3/31/20 11:37 AM, Michael S. Tsirkin wrote: >>> On Tue, Mar 31, 2020 at 11:27:54AM -0700, Randy Dunlap wrote: >>>> On 3/30/20 6:47 PM, a...@linux-foun

Re: [PATCH] vdpa: move to drivers/vdpa

2020-03-31 Thread Randy Dunlap
vdpa_sim.c > b/drivers/vdpa/vdpa_sim/vdpa_sim.c > similarity index 100% > rename from drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c > rename to drivers/vdpa/vdpa_sim/vdpa_sim.c > diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig > index 99e424570644..2aadf398d8cc 100644 > --- a/drivers/virtio/Kconfig > +++ b/drivers/virtio/Kconfig > @@ -109,5 +109,3 @@ config VIRTIO_MMIO_CMDLINE_DEVICES >If unsure, say 'N'. > > endif # VIRTIO_MENU > - > -source "drivers/virtio/vdpa/Kconfig" > -- ~Randy Reported-by: Randy Dunlap ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: mmotm 2020-03-30-18-46 uploaded (VDPA + vhost)

2020-03-31 Thread Randy Dunlap
On 3/31/20 11:37 AM, Michael S. Tsirkin wrote: > On Tue, Mar 31, 2020 at 11:27:54AM -0700, Randy Dunlap wrote: >> On 3/30/20 6:47 PM, a...@linux-foundation.org wrote: >>> The mm-of-the-moment snapshot 2020-03-30-18-46 has been uploaded to >>> >>>http://www.o

Re: [PATCH] vhost: make CONFIG_VHOST depend on CONFIG_EVENTFD

2020-03-30 Thread Randy Dunlap
EVENTFD. > > Reported-by: Randy Dunlap > Fixes: ec9d8449a99b ("vhost: refine vhost and vringh kconfig") > Signed-off-by: Jason Wang > --- > drivers/vhost/Kconfig | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Acked-

Re: linux-next: Tree for Mar 30 (vhost)

2020-03-30 Thread Randy Dunlap
l expression eventfp = f.fd == -1 ? NULL : eventfd_fget(f.fd); ^ -- ~Randy Reported-by: Randy Dunlap ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH V3 5/5] vdpasim: vDPA device simulator

2020-02-19 Thread Randy Dunlap
On 2/19/20 7:56 PM, Jason Wang wrote: > diff --git a/drivers/virtio/vdpa/Kconfig b/drivers/virtio/vdpa/Kconfig > index 7a99170e6c30..e3656b722654 100644 > --- a/drivers/virtio/vdpa/Kconfig > +++ b/drivers/virtio/vdpa/Kconfig > @@ -7,3 +7,21 @@ config VDPA >datapath which complies with

Re: [PATCH V3 4/5] virtio: introduce a vDPA based transport

2020-02-19 Thread Randy Dunlap
On 2/19/20 7:56 PM, Jason Wang wrote: > diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig > index 9c4fdb64d9ac..0df3676b0f4f 100644 > --- a/drivers/virtio/Kconfig > +++ b/drivers/virtio/Kconfig > @@ -43,6 +43,19 @@ config VIRTIO_PCI_LEGACY > > If unsure, say Y. > > +config

Re: [PATCH V3 3/5] vDPA: introduce vDPA bus

2020-02-19 Thread Randy Dunlap
On 2/19/20 7:56 PM, Jason Wang wrote: > diff --git a/drivers/virtio/vdpa/Kconfig b/drivers/virtio/vdpa/Kconfig > new file mode 100644 > index ..7a99170e6c30 > --- /dev/null > +++ b/drivers/virtio/vdpa/Kconfig > @@ -0,0 +1,9 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +config VDPA >

Re: [PATCH V3 1/5] vhost: factor out IOTLB

2020-02-19 Thread Randy Dunlap
On 2/19/20 7:56 PM, Jason Wang wrote: > This patch factors out IOTLB into a dedicated module in order to be > reused by other modules like vringh. User may choose to enable the > automatic retiring by specifying VHOST_IOTLB_FLAG_RETIRE flag to fit > for the case of vhost device IOTLB

Re: [PATCH] vhost: introduce vDPA based backend

2020-01-30 Thread Randy Dunlap
On 1/30/20 7:56 PM, Randy Dunlap wrote: > Hi, > > On 1/30/20 7:36 PM, Tiwei Bie wrote: >> diff --git a/drivers/vhost/Kconfig b/drivers/vhost/Kconfig >> index f21c45aa5e07..13e6a94d0243 100644 >> --- a/drivers/vhost/Kconfig >> +++ b/drivers/vhost/Kconfig >>

Re: [PATCH] vhost: introduce vDPA based backend

2020-01-30 Thread Randy Dunlap
Hi, On 1/30/20 7:36 PM, Tiwei Bie wrote: > diff --git a/drivers/vhost/Kconfig b/drivers/vhost/Kconfig > index f21c45aa5e07..13e6a94d0243 100644 > --- a/drivers/vhost/Kconfig > +++ b/drivers/vhost/Kconfig > @@ -34,6 +34,18 @@ config VHOST_VSOCK > To compile this driver as a module, choose M

Re: [PATCH 3/5] vDPA: introduce vDPA bus

2020-01-16 Thread Randy Dunlap
On 1/16/20 4:42 AM, Jason Wang wrote: > diff --git a/drivers/virtio/vdpa/Kconfig b/drivers/virtio/vdpa/Kconfig > new file mode 100644 > index ..3032727b4d98 > --- /dev/null > +++ b/drivers/virtio/vdpa/Kconfig > @@ -0,0 +1,9 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +config VDPA >

Re: [PATCH 1/5] vhost: factor out IOTLB

2020-01-16 Thread Randy Dunlap
If unsure, say "N". > + > +config VHOST_IOTLB > + tristate > +default m > +help > + Generic IOTLB implementation for vhost and vringh. Use tab + 2 spaces for Kconfig indentation. -- ~Randy Reported-by: Randy Dunlap __

Re: [PATCH 5/5] vdpasim: vDPA device simulator

2020-01-16 Thread Randy Dunlap
On 1/16/20 4:42 AM, Jason Wang wrote: > diff --git a/drivers/virtio/vdpa/Kconfig b/drivers/virtio/vdpa/Kconfig > index 3032727b4d98..12ec25d48423 100644 > --- a/drivers/virtio/vdpa/Kconfig > +++ b/drivers/virtio/vdpa/Kconfig > @@ -7,3 +7,20 @@ config VDPA >datapath which complies with

Re: [PATCH 4/5] virtio: introduce a vDPA based transport

2020-01-16 Thread Randy Dunlap
Hi, On 1/16/20 4:42 AM, Jason Wang wrote: > diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig > index 9c4fdb64d9ac..b4276999d17d 100644 > --- a/drivers/virtio/Kconfig > +++ b/drivers/virtio/Kconfig > @@ -43,6 +43,19 @@ config VIRTIO_PCI_LEGACY > > If unsure, say Y. > >

Re: [PATCH V9 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

2019-11-06 Thread Randy Dunlap
On 11/5/19 11:05 PM, Jason Wang wrote: > diff --git a/samples/Kconfig b/samples/Kconfig > index c8dacb4dda80..13a2443e18e0 100644 > --- a/samples/Kconfig > +++ b/samples/Kconfig > @@ -131,6 +131,16 @@ config SAMPLE_VFIO_MDEV_MDPY > mediated device. It is a simple framebuffer and supports

Re: [PATCH v9 2/7] virtio-pmem: Add virtio pmem driver

2019-05-14 Thread Randy Dunlap
On 5/14/19 7:54 AM, Pankaj Gupta wrote: > diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig > index 35897649c24f..94bad084ebab 100644 > --- a/drivers/virtio/Kconfig > +++ b/drivers/virtio/Kconfig > @@ -42,6 +42,17 @@ config VIRTIO_PCI_LEGACY > > If unsure, say Y. > > +config

Re: [PATCH] VMCI: Use BIT() macro for bit definitions

2019-03-11 Thread Randy Dunlap
On 3/11/19 3:09 PM, Vishnu DASA wrote: > No functional changes, cleanup only. > > Reviewed-by: Adit Ranadive > Reviewed-by: Jorgen Hansen > Signed-off-by: Vishnu Dasa > --- > include/linux/vmw_vmci_defs.h | 34 +- > 1 file changed, 17 insertions(+), 17

Re: [PATCH 1/3] [RFC V3] KVM: X86: Memory ROE documentation

2018-07-19 Thread Randy Dunlap
On 07/19/2018 02:38 PM, Ahmed Abd El Mawgood wrote: > Documentation/virtual/kvm/hypercalls.txt | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/virtual/kvm/hypercalls.txt > b/Documentation/virtual/kvm/hypercalls.txt > index a890529c63ed..a9db68adb7c9

Re: [PATCH 3/3] [RFC V3] KVM: X86: Adding skeleton for Memory ROE

2018-07-19 Thread Randy Dunlap
On 07/19/2018 02:38 PM, Ahmed Abd El Mawgood wrote: > This patch introduces a hypercall implemented for X86 that can assist > against subset of kernel rootkits, it works by place readonly protection in > shadow PTE. The end result protection is also kept in a bitmap for each > kvm_memory_slot and

Re: [PATCH v3 23/27] x86/modules: Adapt module loading for PIE support

2018-05-23 Thread Randy Dunlap
On 05/23/2018 03:01 PM, Thomas Garnier wrote: > On Wed, May 23, 2018 at 2:27 PM Randy Dunlap <rdun...@infradead.org> wrote: > >> Hi, > >> (for several patches in this series:) >> The commit message is confusing. See below. > > Thanks for the edits, I wi

Re: [PATCH v3 23/27] x86/modules: Adapt module loading for PIE support

2018-05-23 Thread Randy Dunlap
Hi, (for several patches in this series:) The commit message is confusing. See below. On 05/23/2018 12:54 PM, Thomas Garnier wrote: > Adapt module loading to support PIE relocations. Generate dynamic GOT if > a symbol requires it but no entry exist in the kernel GOT.

Re: [PATCH v3 16/27] compiler: Option to add PROVIDE_HIDDEN replacement for weak symbols

2018-05-23 Thread Randy Dunlap
On 05/23/2018 12:54 PM, Thomas Garnier wrote: > Provide an option to have a PROVIDE_HIDDEN (linker script) entry for > each weak symbol. This option solve an error in x86_64 where the linker solves > optimizes pie generate code to be non-pie because --emit-relocs

Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

2018-05-07 Thread Randy Dunlap
Hi, On 05/07/2018 03:10 PM, Sridhar Samudrala wrote: > > Signed-off-by: Sridhar Samudrala > --- > MAINTAINERS|7 + > include/linux/netdevice.h | 16 + > include/net/net_failover.h | 52 +++ > net/Kconfig| 10 + >

Re: [PATCH] fault-injection: reorder config entries

2018-04-25 Thread Randy Dunlap
On 04/25/2018 01:02 PM, Mikulas Patocka wrote: > This patch reorders Kconfig entries, so that menuconfig displays proper > indentation. > > Signed-off-by: Mikulas Patocka <mpato...@redhat.com> Acked-by: Randy Dunlap <rdun...@infradead.org> Tested-by: Randy Dunlap <rdu

Re: [PATCH v5] fault-injection: introduce kvmalloc fallback options

2018-04-25 Thread Randy Dunlap
On 04/25/2018 01:57 PM, Mikulas Patocka wrote: > > > On Wed, 25 Apr 2018, Randy Dunlap wrote: > >> On 04/25/2018 01:02 PM, Mikulas Patocka wrote: >>> >>> >>> From: Mikulas Patocka <mpato...@redhat.com> >>> Subject: [PA

Re: [PATCH v4] fault-injection: introduce kvmalloc fallback options

2018-04-25 Thread Randy Dunlap
On 04/25/2018 01:02 PM, Mikulas Patocka wrote: > > > From: Mikulas Patocka > Subject: [PATCH v4] fault-injection: introduce kvmalloc fallback options > > This patch introduces a fault-injection option "kvmalloc_fallback". This > option makes kvmalloc randomly fall back to

Re: [PATCH] headers: untangle kmemleak.h from mm.h

2018-02-13 Thread Randy Dunlap
On 02/11/2018 11:27 PM, Ingo Molnar wrote: > > * Randy Dunlap <rdun...@infradead.org> wrote: > >> From: Randy Dunlap <rdun...@infradead.org> >> >> Currently #includes for no obvious >> reason. It looks like it's only a convenience, so remove km

Re: [PATCH] headers: untangle kmemleak.h from mm.h

2018-02-13 Thread Randy Dunlap
On 02/13/2018 02:09 AM, Michael Ellerman wrote: > Randy Dunlap <rdun...@infradead.org> writes: > >> On 02/12/2018 04:28 AM, Michael Ellerman wrote: >>> Randy Dunlap <rdun...@infradead.org> writes: >>> >>>> From: Randy Dunlap <rdun...@infr

Re: [PATCH] headers: untangle kmemleak.h from mm.h

2018-02-12 Thread Randy Dunlap
On 02/12/2018 04:28 AM, Michael Ellerman wrote: > Randy Dunlap <rdun...@infradead.org> writes: > >> From: Randy Dunlap <rdun...@infradead.org> >> >> Currently #includes for no obvious >> reason. It looks like it's only a convenience, so remove kmeml

[PATCH] headers: untangle kmemleak.h from mm.h

2018-02-11 Thread Randy Dunlap
From: Randy Dunlap <rdun...@infradead.org> Currently #includes for no obvious reason. It looks like it's only a convenience, so remove kmemleak.h from slab.h and add to any users of kmemleak_* that don't already #include it. Also remove from source files that do not use it. This is

Re: [PATCH] [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all

2018-01-06 Thread Randy Dunlap
> +menuconfig VIRTIO_MENU > + bool "Virtio drivers" > + default y The 2 lines above should be indented only with 1 tab. They should not line up with the help text above (help text is indented more than other Kconfig lines). After that little style thing is fixed, you

Re: linux-next: Tree for Jul 21 (gpu/virtio)

2016-07-21 Thread Randy Dunlap
On 07/20/16 23:56, Stephen Rothwell wrote: > Hi all, > > Changes since 20160720: > on x86_64, when CONFIG_FB is not enabled: ERROR: "remove_conflicting_framebuffers" [drivers/gpu/drm/virtio/virtio-gpu.ko] undefined! -- ~Randy ___ Virtualization

Re: linux-next: Tree for Jun 26 (xen/x86)

2013-06-26 Thread Randy Dunlap
On 06/26/13 01:06, Stephen Rothwell wrote: Hi all, Changes since 20130625: CONFIG_SMP is not set CONFIG_X86_UP_APIC is not set on i386: drivers/built-in.o: In function `xen_callback_vector': (.text+0x1dc3cb): undefined reference to `first_system_vector' drivers/built-in.o: In function

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-16 Thread Randy Dunlap
that crypto/algif_skcipher.c also uses that outside net, but it actually needs sockets anyway. socket.h already include uio.h, so no callers need updating. Reported-by: Randy Dunlap rdun...@infradead.org Acked-by: David S. Miller da...@davemloft.net Acked-by: Michael S. Tsirkin m...@redhat.com

Re: linux-next: Tree for May 14 (vhost_scsi)

2013-05-14 Thread Randy Dunlap
On 05/13/13 21:17, Stephen Rothwell wrote: Hi all, Changes since 20130513: crickets :-) on x86_64: ERROR: memcpy_fromiovec [drivers/vhost/vhost_scsi.ko] undefined! It needs to depend on NET since net/core/ provides that function. -- ~Randy

[PATCH] xen: fix fbdev frontend kconfig warning

2013-03-26 Thread Randy Dunlap
From: Randy Dunlap rdun...@infradead.org Fix kconfig dependency warning for XEN_FBDEV_FRONTEND: warning: (XEN_FBDEV_FRONTEND) selects INPUT_XEN_KBDDEV_FRONTEND which has unmet direct dependencies (!UML INPUT INPUT_MISC XEN) Signed-off-by: Randy Dunlap rdun...@infradead.org Cc: Konrad

Re: linux-next: Tree for Feb 13 (virtio_console)

2013-02-14 Thread Randy Dunlap
On 02/13/13 19:00, Rusty Russell wrote: Randy Dunlap rdun...@infradead.org writes: On 02/13/13 00:35, Stephen Rothwell wrote: Hi all, Changes since 20130212: on i386: drivers/built-in.o: In function `in_intr': virtio_console.c:(.text+0x2dd31): undefined reference to `hvc_poll

Re: linux-next: Tree for Feb 13 (virtio_console)

2013-02-14 Thread Randy Dunlap
On 02/14/13 10:45, Randy Dunlap wrote: On 02/13/13 19:00, Rusty Russell wrote: Randy Dunlap rdun...@infradead.org writes: On 02/13/13 00:35, Stephen Rothwell wrote: Hi all, Changes since 20130212: on i386: drivers/built-in.o: In function `in_intr': virtio_console.c:(.text+0x2dd31

Re: linux-next: Tree for Jan 10 (vmci)

2013-01-10 Thread Randy Dunlap
On 01/10/13 11:17, Randy Dunlap wrote: On 01/09/13 19:32, Stephen Rothwell wrote: Hi all, Changes since 20130109: on i386, when CONFIG_PCI is not enabled: CC [M] drivers/misc/vmw_vmci/vmci_guest.o drivers/misc/vmw_vmci/vmci_guest.c:58:20: error: array type has incomplete element

Re: [Xen-devel] Re: linux-next: Tree for July 25 (xen)

2011-08-04 Thread Randy Dunlap
On Thu, 4 Aug 2011 15:55:39 -0400 Konrad Rzeszutek Wilk wrote: On Thu, Aug 04, 2011 at 09:35:34PM +0200, Ingo Molnar wrote: * Randy Dunlap rdun...@xenotime.net wrote: On Mon, 25 Jul 2011 16:25:42 +1000 Stephen Rothwell wrote: Hi all, xen has lots of build errors

Re: [Xen-devel] Re: linux-next: Tree for July 25 (xen)

2011-08-04 Thread Randy Dunlap
On Thu, 4 Aug 2011 18:30:18 -0400 Konrad Rzeszutek Wilk wrote: Do you have a manual of how you guys run your workflow? I just run 30-50 randconfigs per night (cron job). Ok, do you have an mailing list where you send the output too? I don't report 100% of what I see. What I do report

Re: [Xen-devel] Re: linux-next: Tree for July 25 (xen)

2011-08-04 Thread Randy Dunlap
On Thu, 4 Aug 2011 18:40:20 -0400 Konrad Rzeszutek Wilk wrote: On Thu, Aug 04, 2011 at 06:32:59PM -0400, Konrad Rzeszutek Wilk wrote: These build failures are still triggering upstream: arch/x86/xen/trace.c:44:2: error: array index in initializer not of integer type

Re: [Xen-devel] Re: linux-next: Tree for July 25 (xen)

2011-08-04 Thread Randy Dunlap
for ‘xen_hypercall_names’) Oh, that I haven't seen. Can you send me the .config for that please. You can't be trying very hard then. I see lots of these (but no, Ah, I am getting it now. Thanks for reporting it. This should do the trick: Acked-by: Randy Dunlap rdun...@xenotime.net Thanks. diff

Re: [PATCH 7/7] [v4] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Randy Dunlap
On 06/09/11 00:38, Arnd Bergmann wrote: On Thursday 09 June 2011 01:10:09 Randy Dunlap wrote: On Wed, 8 Jun 2011 17:45:54 -0500 Timur Tabi wrote: Add the drivers/virt directory, which houses drivers that support virtualization environments, and add the Freescale hypervisor management driver

Re: [PATCH 7/7] [v4] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Randy Dunlap
On 06/09/11 09:36, Timur Tabi wrote: Randy Dunlap wrote: But it sounds like virt/ needs virt/host/ and virt/guest/ to me. I'm okay with that idea, except there's a consensus that drivers should be in drivers/. Like sound/ ? but what makes it a driver? -- ~Randy *** Remember to use

Re: [PATCH 7/7] [v5] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Randy Dunlap
On Thu, 9 Jun 2011 14:13:14 -0500 Timur Tabi wrote: Add the drivers/virt directory, which houses drivers that support virtualization environments, and add the Freescale hypervisor management driver. The Freescale hypervisor management driver provides several services to drivers and

Re: [PATCH 7/7] [v5] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Randy Dunlap
On 06/09/11 12:47, Timur Tabi wrote: Randy Dunlap wrote: +enum fsl_hv_ioctl_cmd { + FSL_HV_IOCTL_PARTITION_RESTART = _IOWR(0, 1, struct fsl_hv_ioctl_restart), + FSL_HV_IOCTL_PARTITION_GET_STATUS = _IOWR(0, 2, struct fsl_hv_ioctl_status), + FSL_HV_IOCTL_PARTITION_START = _IOWR(0, 3

Re: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv Kconfig

2011-05-04 Thread Randy Dunlap
On Wed, 4 May 2011 11:53:38 -0700 Greg KH wrote: On Wed, May 04, 2011 at 01:44:27PM -0500, H Hartley Sweeten wrote: On Wednesday, May 04, 2011 11:52 AM, K. Y. Srinivasan wrote: The vmbus driver dependes on ACPI and PCI subsystems. Change Kconfig to reflect this. Signed-off-by:

Re: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv Kconfig

2011-05-04 Thread Randy Dunlap
On Wed, 4 May 2011 12:39:54 -0700 Greg KH wrote: On Wed, May 04, 2011 at 12:33:02PM -0700, Randy Dunlap wrote: On Wed, 4 May 2011 11:53:38 -0700 Greg KH wrote: On Wed, May 04, 2011 at 01:44:27PM -0500, H Hartley Sweeten wrote: On Wednesday, May 04, 2011 11:52 AM, K. Y. Srinivasan

[PATCH] xen: fix p2m section mismatches

2011-03-24 Thread Randy Dunlap
From: Randy Dunlap randy.dun...@oracle.com Fix section mismatch warnings: set_phys_range_identity() is called by __init xen_set_identity(), so also mark set_phys_range_identity() as __init. then: __early_alloc_p2m() is called set_phys_range_identity(), so also mark __early_alloc_p2m() as __init

  1   2   >