Re: [PATCH v2] mm/balloon_compaction: Fix trivial spelling

Hello! On 09.06.2020 17:34, Kieran Bingham wrote: The word 'descriptor' is misspelled throughout the tree. Fix it up accordingly: decriptors -> descriptors decriptor -> descriptor really. ;-) Signed-off-by: Kieran Bingham Reviewed-by: David Hildenbrand ---

Re: [PATCH 2/6] i915/gvt/kvm: a NULL ->mm does not mean a thread is a kthread

Hello! On 04.04.2020 12:40, Christoph Hellwig wrote: Use the proper API instead. Fixes: f440c8a572d7 ("drm/i915/gvt/kvmgt: read/write GPA via KVM API") Signed-off-by: Christoph Hellwig --- drivers/gpu/drm/i915/gvt/kvmgt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2 10/11] vsock_test: skip read() in test_stream*close tests on a VMCI host

Hello! On 08/01/2019 06:25 PM, Stefano Garzarella wrote: > When VMCI transport is used, if the guest closes a connection, > all data is gone and EOF is returned, so we should skip the read > of data written by the peer before closing the connection. > > Reported-by: Jorgen Hansen >

Re: [PATCH] vhost: correct the related warning message

On 12/13/2018 06:21 PM, Michael S. Tsirkin wrote: >>> Fixes: 'commit d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression >>> + remove tf_subsystem")' >>> 'commit cbbd26b8b1a6 ("[iov_iter] new primitives - >>> copy_from_iter_full() and friends")' >> >> Fixes: d588cf8f618d

Re: [PATCH] vhost: correct the related warning message

On 13.12.2018 4:10, wangyan wrote: Fixes: 'commit d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove tf_subsystem")' 'commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and friends")' Fixes: d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys

Re: [PATCH net] vhost-vsock: fix use after free

Hello! On 9/27/2018 11:43 AM, Jason Wang wrote: Just a couple of typos... The access of vsock is not protected by vhost_vsock_lock. This may lead use after free since vhost_vsock_dev_release() may free the Lead to use. pointer at the same time. Fix this by holding the lock during

Re: [RFC v4 5/5] virtio_ring: enable packed ring

On 05/16/2018 01:21 PM, Tiwei Bie wrote: >>> Signed-off-by: Tiwei Bie >>> --- >>> drivers/virtio/virtio_ring.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c >>> index de3839f3621a..b158692263b0

Re: [RFC v4 5/5] virtio_ring: enable packed ring

On 5/16/2018 11:37 AM, Tiwei Bie wrote: Signed-off-by: Tiwei Bie --- drivers/virtio/virtio_ring.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index de3839f3621a..b158692263b0 100644 ---

Re: [PATCH] virtio_net: lower limit on buffer size

On 06/02/2017 11:25 PM, J. Bruce Fields wrote: commit d85b758f72b0 "virtio_net: fix support for small rings" Commit d85b758f72b0 ("virtio_net: fix support for small rings") was supposed to increase the buffer size for small rings but had an unintentional side effect of decreasing it for

Re: [PATCH] virtio_net: lower limit on buffer size

Hello! On 6/2/2017 2:56 AM, Michael S. Tsirkin wrote: commit d85b758f72b0 "virtio_net: fix support for small rings" Commit d85b758f72b0 ("virtio_net: fix support for small rings") was supposed to increase the buffer size for small rings but had an unintentional side effect of decreasing

Re: [PATCH net-next 1/8] ptr_ring: introduce batch dequeuing

Hello! On 3/21/2017 7:04 AM, Jason Wang wrote: Signed-off-by: Jason Wang --- include/linux/ptr_ring.h | 65 1 file changed, 65 insertions(+) diff --git a/include/linux/ptr_ring.h b/include/linux/ptr_ring.h index

Re: [RFC v2 -next 2/2] virtio_net: Read the advised MTU

Hello. On 3/16/2016 12:04 AM, Aaron Conole wrote: This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it exists, read the advised MTU and use it. No proper error handling is provided for the case where a user changes the negotiated MTU. A future commit will add proper error

Re: [RFC -next 2/2] virtio_net: Read and use the advised MTU

Hello. On 03/10/2016 05:28 PM, Aaron Conole wrote: This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it exists, read the advised MTU and use it. No proper error handling is provided for the case where a user changes the negotiated MTU. A future commit will add proper

Re: [PATCH 01/16] drm: fixes crct set_mode when crtc mode_fixup is null.

Hello. On 02/16/2016 05:10 PM, Carlos Palminha wrote: This patch set nukes all the dummy crtc mode_fixup implementations. (made on top of Daniel topic/drm-misc branch) Signed-off-by: Carlos Palminha --- drivers/gpu/drm/drm_crtc_helper.c | 9 ++--- 1 file

Re: [PATCH 2/4] vhost: move features to core

Hello. On 09/10/2015 10:23 AM, Michael S. Tsirkin wrote: virtio 1 and any layout are core features, move them there. This fixes vhost test. Signed-off-by: Michael S. Tsirkin [...] diff --git a/drivers/vhost/test.c b/drivers/vhost/test.c index d9c501e..f2882ac 100644 ---

Re: [PATCH net] virtio-net: drop NETIF_F_FRAGLIST

Hello. On 8/4/2015 12:55 PM, Jason Wang wrote: virtio declares support for NETIF_F_FRAGLIST, but assumes that there are at most MAX_SKB_FRAGS + 2 fragments which isn't always true with a fraglist. A longer fraglist in the skb will make the call to skb_to_sgvec overflow the sg array, leading

Re: [PATCH] vhost/net: length miscalculation

Hello. On 01/07/2015 11:55 AM, Michael S. Tsirkin wrote: commit 8b38694a2dc8b18374310df50174f1e4376d6824 vhost/net: virtio 1.0 byte swap had this chunk: - heads[headcount - 1].len += datalen; + heads[headcount - 1].len = cpu_to_vhost32(vq, len - datalen); This adds datalen

Re: [PATCH 03/10] ovs: Enable handling of UFO6 packets.

Hello. On 12/17/2014 09:20 PM, Vladislav Yasevich wrote: Since UFO6 packets can now be identified by SKB_GSO_UDP6, add proper checks to handel UFO6 flows. Legacy applications may still have UFO6 packets identified by SKB_GSO_UDP, so we need to continue to handle them correclty.

Re: [PATCH v7 28/46] vhost: make features 64 bit

Hello. On 11/30/2014 6:11 PM, Michael S. Tsirkin wrote: We need to use bit 32 for virtio 1.0 Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Jason Wang jasow...@redhat.com --- drivers/vhost/vhost.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 09/16] virtio-net: drop config_mutex

Hello. On 10/5/2014 8:07 PM, Michael S. Tsirkin wrote: config_mutex served two purposes: prevent multiple concurrent config change handlers, and synchronize access to config_enable flag. Since commit dbf2576e37da0fcc7aacbfbb9fd5d3de7888a3c1 workqueue: make all workqueues non-reentrant

Re: [PATCH 09/16] virtio-net: drop config_mutex

On 10/6/2014 3:56 PM, Michael S. Tsirkin wrote: config_mutex served two purposes: prevent multiple concurrent config change handlers, and synchronize access to config_enable flag. Since commit dbf2576e37da0fcc7aacbfbb9fd5d3de7888a3c1 workqueue: make all workqueues non-reentrant all

Re: [PATCH 09/16] virtio-net: drop config_mutex

On 10/6/2014 4:22 PM, Michael S. Tsirkin wrote: config_mutex served two purposes: prevent multiple concurrent config change handlers, and synchronize access to config_enable flag. Since commit dbf2576e37da0fcc7aacbfbb9fd5d3de7888a3c1 workqueue: make all workqueues non-reentrant all

Re: [PATCH] VMXNET3: Check for map error in vmxnet3_set_mc

Hello. On 09/02/2014 08:30 PM, Andy King wrote: We should check if the map of the table actually succeeds, and also free resources accordingly. This fixes the kernel panic reported by Tetsuo Handa. There's Reported-by: line for that. Version bumped to 1.2.1.0 Acked-by: Shelley Gong

Re: [PATCH] virtio-net: free bufs correctly on invalid packet length

Hello. On 12/05/2013 11:16 PM, Michael Dalton wrote: When a packet with invalid length arrives, ensure that the packet is freed correctly if mergeable packet buffers and big packets (GUEST_TSO4) are both enabled. Looks like a similar patch have been posted by Andrey Vagin today. You also

Re: [PATCH] vhost/scsi: use vmalloc for order-10 allocation

Hello. On 09/17/2013 11:21 AM, Michael S. Tsirkin wrote: As vhost scsi device struct is large, if the device is created on a busy system, kzalloc() might fail, so this patch does a fallback to vzalloc(). As vmalloc() adds overhead on data-path, add __GFP_REPEAT to kzalloc() flags to do this

Re: [PATCH V2 4/6] vhost_net: determine whether or not to use zerocopy at one time

Hello. On 08/30/2013 08:29 AM, Jason Wang wrote: Currently, even if the packet length is smaller than VHOST_GOODCOPY_LEN, if upend_idx != done_idx we still set zcopy_used to true and rollback this choice later. This could be avoided by determine zerocopy once by checking all conditions at one

Re: [PATCH v8, part3 12/14] mm: correctly update zone-mamaged_pages

On 26-05-2013 17:38, Jiang Liu wrote: Typo in the subject: s/mamaged_pages/managed_pages/. Enhance adjust_managed_page_count() to adjust totalhigh_pages for highmem pages. And change code which directly adjusts totalram_pages to use adjust_managed_page_count() because it adjusts

Re: [PATCH 00/16] treewide: Convert dev_printk(KERN_LEVEL to dev_level(

Hello. On 28-10-2012 12:05, Joe Perches wrote: dev_level create smaller objects than dev_printk(KERN_LEVEL. Convert non-debug calls to this form. Joe Perches (16): tile: Convert dev_printk(KERN_LEVEL to dev_level( [...] tile: Convert dev_printk(KERN_LEVEL to dev_level( [...]