Re: [virtio-dev] virtio-vsock live migration

2016-04-06 Thread Stefan Hajnoczi
On Wed, Mar 16, 2016 at 05:05:19PM +0200, Michael S. Tsirkin wrote: > > > > NFS and netperf are the first two protocols I looked > > > >at and both transmit address information across the connection... > > > > > > > > > Does netperf really attempt to get local IP > > > and then send that inl

[RFC v5 5/5] VSOCK: Add Makefile and Kconfig

2016-04-01 Thread Stefan Hajnoczi
From: Asias He Enable virtio-vsock and vhost-vsock. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v4: * Make checkpatch.pl happy with longer option description * Clarify dependency on virtio rather than QEMU as suggested by Alex Bennee v3: * Don't put vhost vsock d

[RFC v5 4/5] VSOCK: Introduce vhost_vsock.ko

2016-04-01 Thread Stefan Hajnoczi
From: Asias He VM sockets vhost transport implementation. This driver runs on the host. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v5: * Only take rx/tx virtqueues, userspace handles the other virtqueues * Explicitly skip instances without a CID when transferring packets

[RFC v5 2/5] VSOCK: Introduce virtio_vsock_common.ko

2016-04-01 Thread Stefan Hajnoczi
From: Asias He This module contains the common code and header files for the following virtio_transporto and vhost_vsock kernel modules. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v5: * Add event virtqueue, struct virtio_vsock_event, and transport reset event * Reorder

[RFC v5 3/5] VSOCK: Introduce virtio_transport.ko

2016-04-01 Thread Stefan Hajnoczi
From: Asias He VM sockets virtio transport implementation. This driver runs in the guest. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v5: * Add transport reset event handling * Drop ctrl virtqueue v4: * Add MAINTAINERS file entry * Drop short/long rx packets

[RFC v5 0/5] Add virtio transport for AF_VSOCK

2016-04-01 Thread Stefan Hajnoczi
mon.ko VSOCK: Introduce virtio_transport.ko VSOCK: Introduce vhost_vsock.ko VSOCK: Add Makefile and Kconfig Stefan Hajnoczi (1): VSOCK: transport-specific vsock_transport functions MAINTAINERS| 13 + drivers/vhost/Kconfig

[RFC v5 1/5] VSOCK: transport-specific vsock_transport functions

2016-04-01 Thread Stefan Hajnoczi
function pointers. The virtio transport will use this. Signed-off-by: Stefan Hajnoczi --- include/net/af_vsock.h | 3 +++ net/vmw_vsock/af_vsock.c | 9 + 2 files changed, 12 insertions(+) diff --git a/include/net/af_vsock.h b/include/net/af_vsock.h index e9eb2d6..23f5525 100644 --- a

Re: [virtio-dev] virtio-vsock live migration

2016-03-19 Thread Stefan Hajnoczi
On Tue, Mar 15, 2016 at 06:12:55PM +0200, Michael S. Tsirkin wrote: > On Tue, Mar 15, 2016 at 03:15:29PM +0000, Stefan Hajnoczi wrote: > > On Mon, Mar 14, 2016 at 01:13:24PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Mar 03, 2016 at 03:37:37PM +0000, Stefan Hajnoczi wrot

Re: [virtio-dev] virtio-vsock live migration

2016-03-15 Thread Stefan Hajnoczi
On Mon, Mar 14, 2016 at 01:13:24PM +0200, Michael S. Tsirkin wrote: > On Thu, Mar 03, 2016 at 03:37:37PM +0000, Stefan Hajnoczi wrote: > > Michael pointed out that the virtio-vsock draft specification does not > > address live migration and in fact currently precludes migration. >

Re: virtio-vsock live migration

2016-03-15 Thread Stefan Hajnoczi
On Fri, Mar 11, 2016 at 01:56:05AM +0200, Michael S. Tsirkin wrote: > On Thu, Mar 03, 2016 at 03:37:37PM +0000, Stefan Hajnoczi wrote: > > Michael pointed out that the virtio-vsock draft specification does not > > address live migration and in fact currently precludes migration. >

virtio-vsock live migration

2016-03-03 Thread Stefan Hajnoczi
Michael pointed out that the virtio-vsock draft specification does not address live migration and in fact currently precludes migration. Migration is fundamental so the device specification at least mustn't preclude it. Having brainstormed migration with Matthew Benjamin and Michael Tsirkin, I am

Re: [RFC v4 0/5] Add virtio transport for AF_VSOCK

2016-01-28 Thread Stefan Hajnoczi
On Tue, Dec 22, 2015 at 05:07:33PM +0800, Stefan Hajnoczi wrote: > This series is based on v4.4-rc2 and the "virtio: make find_vqs() > checkpatch.pl-friendly" patch I recently submitted. > > v4: > * Addressed code review comments from Alex Bennee > * MAINTAINER

[RFC v4 4/5] VSOCK: Introduce vhost_vsock.ko

2015-12-22 Thread Stefan Hajnoczi
From: Asias He VM sockets vhost transport implementation. This driver runs on the host. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v4: * Add MAINTAINERS file entry * virtqueue used len is now sizeof(pkt->hdr) + pkt->len instead of just pkt->len * checkpatch.pl

[RFC v4 5/5] VSOCK: Add Makefile and Kconfig

2015-12-22 Thread Stefan Hajnoczi
From: Asias He Enable virtio-vsock and vhost-vsock. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v4: * Make checkpatch.pl happy with longer option description * Clarify dependency on virtio rather than QEMU as suggested by Alex Bennee v3: * Don't put vhost vsock d

[RFC v4 3/5] VSOCK: Introduce virtio_transport.ko

2015-12-22 Thread Stefan Hajnoczi
From: Asias He VM sockets virtio transport implementation. This driver runs in the guest. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v4: * Add MAINTAINERS file entry * Drop short/long rx packets * checkpatch.pl cleanups * Clarify locking in struct virtio_vsock * Narrow

[RFC v4 2/5] VSOCK: Introduce virtio_vsock_common.ko

2015-12-22 Thread Stefan Hajnoczi
From: Asias He This module contains the common code and header files for the following virtio_transporto and vhost_vsock kernel modules. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v4: * Add MAINTAINERS file entry * checkpatch.pl cleanups * linux_vsock.h: drop wrong copy

[RFC v4 0/5] Add virtio transport for AF_VSOCK

2015-12-22 Thread Stefan Hajnoczi
example above). Status -- This patch series implements the latest draft specification. Please review. Asias He (4): VSOCK: Introduce virtio_vsock_common.ko VSOCK: Introduce virtio_transport.ko VSOCK: Introduce vhost_vsock.ko VSOCK: Add Makefile and Kconfig Stefan Hajnoczi (1): VSO

[RFC v4 1/5] VSOCK: transport-specific vsock_transport functions

2015-12-22 Thread Stefan Hajnoczi
function pointers. The virtio transport will use this. Signed-off-by: Stefan Hajnoczi --- include/net/af_vsock.h | 3 +++ net/vmw_vsock/af_vsock.c | 9 + 2 files changed, 12 insertions(+) diff --git a/include/net/af_vsock.h b/include/net/af_vsock.h index e9eb2d6..23f5525 100644 --- a

[PATCH] virtio: make find_vqs() checkpatch.pl-friendly

2015-12-17 Thread Stefan Hajnoczi
a compiler error due to losing the second const. This patch adjusts the find_vqs() prototype and updates all virtio transports. This makes it possible for virtio_balloon.c, virtio_input.c, virtgpu_kms.c, and virtio_rpmsg_bus.c to use the checkpatch.pl-friendly type. Signed-off-by: Stefan Hajnoczi

Re: [PATCH v3 4/4] VSOCK: Add Makefile and Kconfig

2015-12-15 Thread Stefan Hajnoczi
On Fri, Dec 11, 2015 at 05:19:08PM +, Alex Bennée wrote: > > +config VHOST_VSOCK > > + tristate "vhost virtio-vsock driver" > > + depends on VSOCKETS && EVENTFD > > + select VIRTIO_VSOCKETS_COMMON > > + select VHOST > > + select VHOST_RING > > + default n > > + ---help--- > > +

Re: [PATCH v3 3/4] VSOCK: Introduce vhost-vsock.ko

2015-12-15 Thread Stefan Hajnoczi
On Fri, Dec 11, 2015 at 01:45:29PM +, Alex Bennée wrote: > > + if (head == vq->num) { > > + if (unlikely(vhost_enable_notify(&vsock->dev, vq))) { > > + vhost_disable_notify(&vsock->dev, vq); > > + continue; > > Why

Re: [PATCH v3 2/4] VSOCK: Introduce virtio-vsock.ko

2015-12-10 Thread Stefan Hajnoczi
On Thu, Dec 10, 2015 at 09:23:25PM +, Alex Bennée wrote: > Stefan Hajnoczi writes: > > > From: Asias He > > > > VM sockets virtio transport implementation. This module runs in guest > > kernel. > > checkpatch warns on a bunch of whitespace/tab i

Re: [PATCH v3 1/4] VSOCK: Introduce virtio-vsock-common.ko

2015-12-10 Thread Stefan Hajnoczi
On Thu, Dec 10, 2015 at 10:17:07AM +, Alex Bennée wrote: > Stefan Hajnoczi writes: > > > From: Asias He > > > > This module contains the common code and header files for the following > > virtio-vsock and virtio-vhost kernel modules. > > General commen

[PATCH v3 4/4] VSOCK: Add Makefile and Kconfig

2015-12-09 Thread Stefan Hajnoczi
From: Asias He Enable virtio-vsock and vhost-vsock. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v3: * Don't put vhost vsock driver into staging * Add missing Kconfig dependencies (Arnd Bergmann ) --- drivers/vhost/Kconfig | 10 ++ drivers/vhost/Makefile

[PATCH v3 3/4] VSOCK: Introduce vhost-vsock.ko

2015-12-09 Thread Stefan Hajnoczi
From: Asias He VM sockets vhost transport implementation. This module runs in host kernel. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v3: * Remove unneeded variable used to store return value (Fengguang Wu and Julia Lawall ) v2: * Add missing total_tx_buf decrement

[PATCH v3 0/4] Add virtio transport for AF_VSOCK

2015-12-09 Thread Stefan Hajnoczi
Note: the virtio-vsock device specification is currently under review but not yet finalized. Please review this code but don't merge until I send an update when the spec is finalized. Thanks! v3: * Remove unnecessary 3-way handshake, just do REQUEST/RESPONSE instead of REQUEST/RESPONSE/ACK

[PATCH v3 2/4] VSOCK: Introduce virtio-vsock.ko

2015-12-09 Thread Stefan Hajnoczi
From: Asias He VM sockets virtio transport implementation. This module runs in guest kernel. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v2: * Fix total_tx_buf accounting * Add virtio_transport global mutex to prevent races --- net/vmw_vsock/virtio_transport.c | 466

[PATCH v3 1/4] VSOCK: Introduce virtio-vsock-common.ko

2015-12-09 Thread Stefan Hajnoczi
From: Asias He This module contains the common code and header files for the following virtio-vsock and virtio-vhost kernel modules. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v3: * Remove unnecessary 3-way handshake, just do REQUEST/RESPONSE instead of REQUEST/RESPONSE

[PATCH v2] Revert "Merge branch 'vsock-virtio'"

2015-12-08 Thread Stefan Hajnoczi
this code when the hardware interface (and possibly the userspace interface) could still change. Signed-off-by: Stefan Hajnoczi --- v2: * Revert merge commit and coccinelle fixup in a single patch drivers/vhost/Kconfig |4 - drivers/vhost/Kconfig.vsock |7

Re: [PATCH 0/6] VSOCK: revert virtio-vsock until device spec is finalized

2015-12-08 Thread Stefan Hajnoczi
On Tue, Dec 08, 2015 at 11:26:55AM -0500, David Miller wrote: > From: Stefan Hajnoczi > Date: Tue, 8 Dec 2015 19:57:30 +0800 > > > Please revert for now. > > Please don't revert it piece by piece like this. > > Instead, send me one big revert commit that und

Re: [PATCH v2 0/5] Add virtio transport for AF_VSOCK

2015-12-08 Thread Stefan Hajnoczi
On Fri, Dec 04, 2015 at 09:45:04AM +0200, Michael S. Tsirkin wrote: > On Wed, Dec 02, 2015 at 02:43:58PM +0800, Stefan Hajnoczi wrote: > > 1. The 3-way handshake isn't necessary over a reliable transport > > (virtqueue). > >Spoofing packets is also impossible so the

[PATCH 4/6] Revert "VSOCK: Introduce virtio-vsock.ko"

2015-12-08 Thread Stefan Hajnoczi
This reverts commit 32e61b06b6946ba137723c5b1de2a1fdb2e0e0a5. Keep virtio-vsock out-of-tree until the device specification is finalized. Signed-off-by: Stefan Hajnoczi --- net/vmw_vsock/virtio_transport.c | 466 --- 1 file changed, 466 deletions(-) delete

[PATCH 5/6] Revert "VSOCK: Introduce virtio-vsock-common.ko"

2015-12-08 Thread Stefan Hajnoczi
This reverts commit 80a19e338d458abb5a700df3fd00795c51361f06. Keep virtio-vsock out-of-tree until the device specification is finalized. Signed-off-by: Stefan Hajnoczi --- include/linux/virtio_vsock.h| 209 - include/uapi/linux/virtio_ids.h |1 - include/uapi/linux

[PATCH 6/6] Revert "VSOCK: Introduce vsock_find_unbound_socket and vsock_bind_dgram_generic"

2015-12-08 Thread Stefan Hajnoczi
This reverts commit 357ab2234d57f6c74386f64ded42dff8e3c0500b. Keep virtio-vsock out-of-tree until the device specification is finalized. Signed-off-by: Stefan Hajnoczi --- include/net/af_vsock.h | 2 -- net/vmw_vsock/af_vsock.c | 70 2 files

[PATCH 3/6] Revert "VSOCK: Introduce vhost-vsock.ko"

2015-12-08 Thread Stefan Hajnoczi
This reverts commit 98bb892821c1ad3781b8c7daec2fc8a8de3390c9. Keep virtio-vsock out-of-tree until the device specification is finalized. Signed-off-by: Stefan Hajnoczi --- drivers/vhost/vsock.c | 631 -- drivers/vhost/vsock.h | 4 - 2 files

[PATCH 2/6] Revert "VSOCK: Add Makefile and Kconfig"

2015-12-08 Thread Stefan Hajnoczi
This reverts commit 8a2a2029893b4c35d1aba2932111a1a164b9c948. Keep virtio-vsock out-of-tree until the device specification is finalized. Signed-off-by: Stefan Hajnoczi --- drivers/vhost/Kconfig | 4 drivers/vhost/Kconfig.vsock | 7 --- drivers/vhost/Makefile | 4

[PATCH 1/6] Revert "VSOCK: fix returnvar.cocci warnings"

2015-12-08 Thread Stefan Hajnoczi
This reverts commit 0d76d6e8b2507983a2cae4c09880798079007421. Keep virtio-vsock out-of-tree until the virtio-vsock device specification is finalized. Signed-off-by: Stefan Hajnoczi --- drivers/vhost/vsock.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/vhost

[PATCH 0/6] VSOCK: revert virtio-vsock until device spec is finalized

2015-12-08 Thread Stefan Hajnoczi
at that point the interfaces will be stable. Stefan Hajnoczi (6): Revert "VSOCK: fix returnvar.cocci warnings" Revert "VSOCK: Add Makefile and Kconfig" Revert "VSOCK: Introduce vhost-vsock.ko" Revert "VSOCK: Introduce virtio-vsock.ko" Revert

Re: [PATCH] VSOCK: fix returnvar.cocci warnings

2015-12-06 Thread Stefan Hajnoczi
T_VSOCK_DEFAULT_HOST_CID; > - return cid; > + return VHOST_VSOCK_DEFAULT_HOST_CID; > } > > static struct vhost_vsock *vhost_vsock_get(u32 guest_cid) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature ___

[PATCH v2 5/5] VSOCK: Add Makefile and Kconfig

2015-12-01 Thread Stefan Hajnoczi
From: Asias He Enable virtio-vsock and vhost-vsock. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- drivers/vhost/Kconfig | 4 drivers/vhost/Kconfig.vsock | 7 +++ drivers/vhost/Makefile | 4 net/vmw_vsock/Kconfig | 18 ++ net

[PATCH v2 4/5] VSOCK: Introduce vhost-vsock.ko

2015-12-01 Thread Stefan Hajnoczi
From: Asias He VM sockets vhost transport implementation. This module runs in host kernel. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v2: * Add missing total_tx_buf decrement * Support flexible rx/tx descriptor layout * Refuse to assign reserved CIDs * Refuse guest CID if

[PATCH v2 3/5] VSOCK: Introduce virtio-vsock.ko

2015-12-01 Thread Stefan Hajnoczi
From: Asias He VM sockets virtio transport implementation. This module runs in guest kernel. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v2: * Fix total_tx_buf accounting * Add virtio_transport global mutex to prevent races --- net/vmw_vsock/virtio_transport.c | 466

[PATCH v2 2/5] VSOCK: Introduce virtio-vsock-common.ko

2015-12-01 Thread Stefan Hajnoczi
From: Asias He This module contains the common code and header files for the following virtio-vsock and virtio-vhost kernel modules. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v2: * Fix peer_buf_alloc inheritance on child socket * Notify other side of SOCK_STREAM disconnect

[PATCH v2 1/5] VSOCK: Introduce vsock_find_unbound_socket and vsock_bind_dgram_generic

2015-12-01 Thread Stefan Hajnoczi
From: Asias He Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- include/net/af_vsock.h | 2 ++ net/vmw_vsock/af_vsock.c | 70 2 files changed, 72 insertions(+) diff --git a/include/net/af_vsock.h b/include/net/af_vsock.h index

[PATCH v2 0/5] Add virtio transport for AF_VSOCK

2015-12-01 Thread Stefan Hajnoczi
v2: * Rebased onto Linux v4.4-rc2 * vhost: Refuse to assign reserved CIDs * vhost: Refuse guest CID if already in use * vhost: Only accept correctly addressed packets (no spoofing!) * vhost: Support flexible rx/tx descriptor layout * vhost: Add missing total_tx_buf decrement * virtio_transpo

Re: vhost-blk and qemu

2015-11-23 Thread Stefan Hajnoczi
On Tue, Nov 17, 2015 at 9:23 PM, Mohan G via Virtualization wrote: > I am looking to experiment the vhost-blk stack. Can some one point me to the > latest code version and the corresponding qemu version location. > I am on centos 7 (3.10 ) kernel. I am hoping using the vhost-blk.ko and > correspon

[PATCH] VSOCK: define VSOCK_SS_LISTEN once only

2015-10-29 Thread Stefan Hajnoczi
way it is clear that the constant is vsock-specific. The big text reflow in af_vsock.c was necessary to keep to the maximum line length. Text is unchanged except for s/SS_LISTEN/VSOCK_SS_LISTEN/. Signed-off-by: Stefan Hajnoczi --- include/net/af_vsock.h | 3 +++ net/vmw_vsock/af_vsock.c

Re: [virtio-dev] rfc: vhost user enhancements for vm2vm communication

2015-09-14 Thread Stefan Hajnoczi
On Mon, Aug 31, 2015 at 05:11:02PM +0300, Michael S. Tsirkin wrote: > The resulting channel might look something like the following: > > +-- VM1 --+ +---VM2---+ > | virtio-pci -- iommu +--+ vhost-pci -- VF | -- VFIO -- IOMMU -- NIC > +-+ +-

Re: [RFC PATCH 0/2] virtio nvme

2015-09-11 Thread Stefan Hajnoczi
On Fri, Sep 11, 2015 at 6:21 PM, Ming Lin wrote: > On Fri, 2015-09-11 at 08:48 +0100, Stefan Hajnoczi wrote: >> On Thu, Sep 10, 2015 at 6:28 PM, Ming Lin wrote: >> > On Thu, 2015-09-10 at 15:38 +0100, Stefan Hajnoczi wrote: >> >> On Thu, Sep 10, 2015 at 6:48 AM, Mi

Re: [RFC PATCH 0/2] virtio nvme

2015-09-11 Thread Stefan Hajnoczi
On Thu, Sep 10, 2015 at 6:28 PM, Ming Lin wrote: > On Thu, 2015-09-10 at 15:38 +0100, Stefan Hajnoczi wrote: >> On Thu, Sep 10, 2015 at 6:48 AM, Ming Lin wrote: >> > These 2 patches added virtio-nvme to kernel and qemu, >> > basically modified from virtio-blk and nv

Re: [RFC PATCH 0/2] virtio nvme

2015-09-10 Thread Stefan Hajnoczi
On Thu, Sep 10, 2015 at 6:48 AM, Ming Lin wrote: > These 2 patches added virtio-nvme to kernel and qemu, > basically modified from virtio-blk and nvme code. > > As title said, request for your comments. > > Play it in Qemu with: > -drive file=disk.img,format=raw,if=none,id=D22 \ > -device virtio-n

Re: [virtio-dev] [PATCH] virtio_net: don't require ANY_LAYOUT with VERSION_1

2015-07-16 Thread Stefan Hajnoczi
> --- > drivers/net/virtio_net.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi pgp9USZoClAkv.pgp Description: PGP signature ___ Virtualization mailing list Virtualization@lists.linux-foundation.org http

[RFC 3/6] VSOCK: Introduce virtio-vsock-common.ko

2015-05-27 Thread Stefan Hajnoczi
From: Asias He This module contains the common code and header files for the following virtio-vsock and virtio-vhost kernel modules. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- include/linux/virtio_vsock.h| 207 + include/uapi/linux/virtio_ids.h |1

[RFC 6/6] VSOCK: Add Makefile and Kconfig

2015-05-27 Thread Stefan Hajnoczi
From: Asias He Enable virtio-vsock and vhost-vsock. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- drivers/vhost/Kconfig | 4 drivers/vhost/Kconfig.vsock | 7 +++ drivers/vhost/Makefile | 4 net/vmw_vsock/Kconfig | 18 ++ net

[RFC 5/6] VSOCK: Introduce vhost-vsock.ko

2015-05-27 Thread Stefan Hajnoczi
From: Asias He VM sockets vhost transport implementation. This module runs in host kernel. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- drivers/vhost/vsock.c | 596 ++ drivers/vhost/vsock.h | 4 + 2 files changed, 600 insertions

[RFC 4/6] VSOCK: Introduce virtio-vsock.ko

2015-05-27 Thread Stefan Hajnoczi
From: Asias He VM sockets virtio transport implementation. This module runs in guest kernel. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- net/vmw_vsock/virtio_transport.c | 450 +++ 1 file changed, 450 insertions(+) create mode 100644 net

[RFC 1/6] VSOCK: Introduce vsock_find_unbound_socket and vsock_bind_dgram_generic

2015-05-27 Thread Stefan Hajnoczi
From: Asias He Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- include/net/af_vsock.h | 2 ++ net/vmw_vsock/af_vsock.c | 70 2 files changed, 72 insertions(+) diff --git a/include/net/af_vsock.h b/include/net/af_vsock.h index

[RFC 0/6] Add virtio transport for AF_VSOCK

2015-05-27 Thread Stefan Hajnoczi
This patch series adds a virtio transport for AF_VSOCK (net/vmw_vsock/). AF_VSOCK is designed for communication between virtual machines and hypervisors. It is currently only implemented for VMware's VMCI transport. This series implements the proposed virtio-vsock device specification from here:

[RFC 2/6] Add dgram_skb to vsock_sock

2015-05-27 Thread Stefan Hajnoczi
From: Asias He This list will be used to match received packets when multiple packets are used because datagram size is larger than the receive buffer size. Signed-off-by: Stefan Hajnoczi --- include/net/af_vsock.h | 1 + net/vmw_vsock/af_vsock.c | 1 + 2 files changed, 2 insertions

Re: [virtio-dev] Zerocopy VM-to-VM networking using virtio-net

2015-04-27 Thread Stefan Hajnoczi
On Mon, Apr 27, 2015 at 1:55 PM, Jan Kiszka wrote: > Am 2015-04-27 um 14:35 schrieb Jan Kiszka: >> Am 2015-04-27 um 12:17 schrieb Stefan Hajnoczi: >>> On Sun, Apr 26, 2015 at 2:24 PM, Luke Gorrie wrote: >>>> On 24 April 2015 at 15:22, Stefan Hajnoczi wrote: >>

Re: [virtio-dev] Zerocopy VM-to-VM networking using virtio-net

2015-04-27 Thread Stefan Hajnoczi
On Mon, Apr 27, 2015 at 1:35 PM, Jan Kiszka wrote: > Am 2015-04-27 um 12:17 schrieb Stefan Hajnoczi: >> On Sun, Apr 26, 2015 at 2:24 PM, Luke Gorrie wrote: >>> On 24 April 2015 at 15:22, Stefan Hajnoczi wrote: >>>> >>>> The motivation for m

Re: [virtio-dev] Zerocopy VM-to-VM networking using virtio-net

2015-04-27 Thread Stefan Hajnoczi
On Sun, Apr 26, 2015 at 2:24 PM, Luke Gorrie wrote: > On 24 April 2015 at 15:22, Stefan Hajnoczi wrote: >> >> The motivation for making VM-to-VM fast is that while software >> switches on the host are efficient today (thanks to vhost-user), there >> is no efficie

Re: [virtio-dev] Zerocopy VM-to-VM networking using virtio-net

2015-04-24 Thread Stefan Hajnoczi
On Fri, Apr 24, 2015 at 2:10 PM, Luke Gorrie wrote: > On 24 April 2015 at 14:17, Luke Gorrie wrote: >> >> For what it is worth, I think > > > Erm, sorry about ranting with my pre-existing ideas without having examined > the proposed specification in detail. My experience with DPDK and SDN/NFV is

Re: [virtio-dev] Zerocopy VM-to-VM networking using virtio-net

2015-04-24 Thread Stefan Hajnoczi
On Fri, Apr 24, 2015 at 1:17 PM, Luke Gorrie wrote: > On 24 April 2015 at 11:47, Stefan Hajnoczi wrote: >> >> My concern is the overhead of the vhost_net component copying >> descriptors between NICs. > > > I see. So you would not have to reserve CPU resources for

Re: [virtio-dev] Zerocopy VM-to-VM networking using virtio-net

2015-04-24 Thread Stefan Hajnoczi
On Fri, Apr 24, 2015 at 10:47 AM, Stefan Hajnoczi wrote: > At this level it's compared to vhost-user, but it's not programmable > in userspace! s/compared/comparable/ ___ Virtualization mailing list Virtualization@lists.linux-foun

Re: [virtio-dev] Zerocopy VM-to-VM networking using virtio-net

2015-04-24 Thread Stefan Hajnoczi
On Fri, Apr 24, 2015 at 9:12 AM, Luke Gorrie wrote: > - How fast would the new design likely be? This proposal eliminates two things in the path: 1. Compared to vhost_net, it bypasses the host tun driver and network stack, replacing it with direct vhost_net <-> vhost_net data transfer. At this l

Re: Zerocopy VM-to-VM networking using virtio-net

2015-04-22 Thread Stefan Hajnoczi
On Wed, Apr 22, 2015 at 6:46 PM, Cornelia Huck wrote: > On Wed, 22 Apr 2015 18:01:38 +0100 > Stefan Hajnoczi wrote: > >> [It may be necessary to remove virtio-...@lists.oasis-open.org from CC >> if you are a non-TC member.] >> >> Hi, >> Some modern ne

Zerocopy VM-to-VM networking using virtio-net

2015-04-22 Thread Stefan Hajnoczi
[It may be necessary to remove virtio-...@lists.oasis-open.org from CC if you are a non-TC member.] Hi, Some modern networking applications bypass the kernel network stack so that rx/tx rings and DMA buffers can be directly mapped. This is typical in DPDK applications where virtio-net currently i

[PATCH] virtio: fix typo in vring_need_event() doc comment

2015-04-15 Thread Stefan Hajnoczi
Here the "other side" refers to the guest or host. Signed-off-by: Stefan Hajnoczi --- include/uapi/linux/virtio_ring.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/virtio_ring.h b/include/uapi/linux/virtio_ring.h index a3318f3..915980a 10

Re: [PATCH RFC v6 08/20] dataplane: allow virtio-1 devices

2015-01-20 Thread Stefan Hajnoczi
On Tue, Jan 20, 2015 at 12:56 PM, Cornelia Huck wrote: > On Tue, 20 Jan 2015 10:43:31 + > Stefan Hajnoczi wrote: >> On Thu, Dec 11, 2014 at 02:25:10PM +0100, Cornelia Huck wrote: >> > @@ -154,15 +157,18 @@ bool vring_should_notify(VirtIODevice *vde

Re: [PATCH RFC v6 16/20] virtio-net: support longer header

2015-01-20 Thread Stefan Hajnoczi
On Thu, Dec 11, 2014 at 02:25:18PM +0100, Cornelia Huck wrote: > diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c > index ebbea60..7ee2bd6 100644 > --- a/hw/net/virtio-net.c > +++ b/hw/net/virtio-net.c > @@ -373,15 +373,21 @@ static int peer_has_ufo(VirtIONet *n) > return n->has_ufo; >

Re: [PATCH RFC v6 15/20] virtio-net: no writeable mac for virtio-1

2015-01-20 Thread Stefan Hajnoczi
onfig_size); > > if (!virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_MAC_ADDR) && I don't see VIRTIO_NET_F_CTRL_MAC_ADDR (23) in the VIRTIO 1.0 "5.1.3.1 Legacy Interface: Feature bits" section. Should it be there just so people don't try to reuse bit

Re: [PATCH RFC v6 14/20] s390x/virtio-ccw: enable virtio 1.0

2015-01-20 Thread Stefan Hajnoczi
1 insertion(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi pgpjnoE2ulxcN.pgp Description: PGP signature ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH RFC v6 12/20] virtio: disallow late feature changes for virtio-1

2015-01-20 Thread Stefan Hajnoczi
On Fri, Dec 12, 2014 at 12:25:47PM +0100, Thomas Huth wrote: > On Fri, 12 Dec 2014 12:18:25 +0100 > Cornelia Huck wrote: > > > On Fri, 12 Dec 2014 11:55:38 +0100 > > Thomas Huth wrote: > > > > > On Thu, 11 Dec 2014 14:25:14 +0100 > > > Cornelia Huck wrote: > > > > > > > For virtio-1 devices,

Re: [PATCH RFC v6 10/20] s390x/virtio-ccw: add virtio set-revision call

2015-01-20 Thread Stefan Hajnoczi
On Thu, Dec 11, 2014 at 02:25:12PM +0100, Cornelia Huck wrote: > @@ -608,6 +631,25 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw) > } > } > break; > +case CCW_CMD_SET_VIRTIO_REV: > +len = sizeof(revinfo); > +if (ccw.count < len || (check_len

Re: [PATCH RFC v6 11/20] s390x/virtio-ccw: support virtio-1 set_vq format

2015-01-20 Thread Stefan Hajnoczi
: Thomas Huth > Signed-off-by: Cornelia Huck > --- > hw/s390x/virtio-ccw.c | 114 > ++--- > 1 file changed, 80 insertions(+), 34 deletions(-) Reviewed-by: Stefan Hajnoczi pgpKff

Re: [PATCH RFC v6 10/20] s390x/virtio-ccw: add virtio set-revision call

2015-01-20 Thread Stefan Hajnoczi
sabled. > > Signed-off-by: Thomas Huth > Signed-off-by: Cornelia Huck > --- > hw/s390x/virtio-ccw.c | 52 > + > hw/s390x/virtio-ccw.h |8 ++++ > 2 files changed, 60 insertions(+) Reviewed-by:

Re: [PATCH RFC v6 09/20] s390x/css: Add a callback for when subchannel gets disabled

2015-01-20 Thread Stefan Hajnoczi
t; --- > hw/s390x/css.c | 12 > hw/s390x/css.h |1 + > 2 files changed, 13 insertions(+) Reviewed-by: Stefan Hajnoczi pgpeupBNkDDpj.pgp Description: PGP signature ___ Virtualization mailing list Virtualization

Re: [PATCH RFC v6 08/20] dataplane: allow virtio-1 devices

2015-01-20 Thread Stefan Hajnoczi
On Thu, Dec 11, 2014 at 02:25:10PM +0100, Cornelia Huck wrote: > Handle endianness conversion for virtio-1 virtqueues correctly. > > Note that dataplane now needs to be built per-target. > > Signed-off-by: Cornelia Huck > --- > hw/block/dataplane/virtio-blk.c |4 +- > hw/scsi/

Re: [PATCH RFC v6 06/20] virtio: endianness checks for virtio 1.0 devices

2015-01-20 Thread Stefan Hajnoczi
- > hw/virtio/virtio.c|6 +- > include/hw/virtio/virtio-access.h |4 > include/hw/virtio/virtio.h|8 ++-- > 3 files changed, 15 insertions(+), 3 deletions(-) Reviewed-by: Stefan Hajnoczi pgpds9Rfh

Re: [PATCH net] Revert "drivers/net: Disable UFO through virtio" in macvtap and tun

2014-11-12 Thread Stefan Hajnoczi
On Tue, Nov 11, 2014 at 05:12:58PM +, Ben Hutchings wrote: > This reverts commit 88e0e0e5aa722b193c8758c8b45d041de5316924 for > the tap drivers, but leaves UFO disabled in virtio_net. > > libvirt at least assumes that tap features will never be dropped > in new kernel versions, and doing so pr

TUN_F_UFO change breaks live migration

2014-11-11 Thread Stefan Hajnoczi
Commit 3d0ad09412ffe00c9afa201d01effdb6023d09b4 ("drivers/net: Disable UFO through virtio") breaks live migration of KVM guests from older to newer host kernels: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=3d0ad09412ffe00c9afa201d01effdb6023d09b4 The problem occurs

Re: [virtio-dev] [PATCH 2/2] virtio-gpu/2d: add docs/specs/virtio-gpu.txt

2014-09-12 Thread Stefan Hajnoczi
On Thu, Sep 11, 2014 at 05:09:33PM +0200, Gerd Hoffmann wrote: > diff --git a/docs/specs/virtio-gpu.txt b/docs/specs/virtio-gpu.txt > new file mode 100644 > index 000..9455383 > --- /dev/null > +++ b/docs/specs/virtio-gpu.txt > @@ -0,0 +1,165 @@ > +virtio-gpu specification > +==

Re: [PATCH 0/3] virtio: Clean up scatterlists and use the DMA API

2014-08-27 Thread Stefan Hajnoczi
On Wed, Aug 27, 2014 at 6:27 PM, Konrad Rzeszutek Wilk wrote: > On Wed, Aug 27, 2014 at 07:46:46AM +0100, Stefan Hajnoczi wrote: >> On Tue, Aug 26, 2014 at 10:16 PM, Andy Lutomirski >> wrote: >> > There are two outstanding issues. virtio_net warns if DMA debugging &g

Re: [PATCH 0/3] virtio: Clean up scatterlists and use the DMA API

2014-08-26 Thread Stefan Hajnoczi
On Tue, Aug 26, 2014 at 10:16 PM, Andy Lutomirski wrote: > There are two outstanding issues. virtio_net warns if DMA debugging > is on because it does DMA from the stack. (The warning is correct.) > This also is likely to do something unpleasant to s390. > (Maintainers are cc'd -- I don't know w

Re: help? looking for limits on in-flight write operations for virtio-blk

2014-08-26 Thread Stefan Hajnoczi
On Mon, Aug 25, 2014 at 8:42 PM, Chris Friesen wrote: > I'm trying to figure out what controls the number if in-flight virtio block > operations when running linux in qemu on top of a linux host. > > The problem is that we're trying to run as many VMs as possible, using > ceph/rbd for the rootfs.

Re: [Qemu-devel] Why I advise against using ivshmem

2014-06-21 Thread Stefan Hajnoczi
On Wed, Jun 18, 2014 at 10:57 PM, David Marchand wrote: > On 06/18/2014 12:48 PM, Stefan Hajnoczi wrote: >> >> One more thing to add to the list: >> >> static void ivshmem_read(void *opaque, const uint8_t * buf, int flags) >> >> The "flags" a

Re: [Qemu-devel] Why I advise against using ivshmem

2014-06-18 Thread Stefan Hajnoczi
On Tue, Jun 17, 2014 at 11:03:32AM +0200, David Marchand wrote: > On 06/17/2014 04:54 AM, Stefan Hajnoczi wrote: > >ivshmem has a performance disadvantage for guest-to-host > >communication. Since the shared memory is exposed as PCI BARs, the > >guest has to memcpy i

Re: [Qemu-devel] Why I advise against using ivshmem

2014-06-18 Thread Stefan Hajnoczi
On Tue, Jun 17, 2014 at 11:44:11AM +0200, Paolo Bonzini wrote: > Il 17/06/2014 11:03, David Marchand ha scritto: > >>Unless someone steps up and maintains ivshmem, I think it should be > >>deprecated and dropped from QEMU. > > > >Then I can maintain ivshmem for QEMU. > >If this is ok, I will send a

Re: [Qemu-devel] Why I advise against using ivshmem

2014-06-16 Thread Stefan Hajnoczi
On Fri, Jun 13, 2014 at 10:10 PM, Paolo Bonzini wrote: > Il 13/06/2014 15:41, Vincent JARDIN ha scritto: >> I do repeat this use case that you had removed because vhost-user does >> not solve it yet: >> - ivshmem -> framework to be generic to have shared memory for many use cases (HPC,

Re: [RFC PATCH 2/2] block: virtio-blk: support multi virt queues per virtio-blk device

2014-06-16 Thread Stefan Hajnoczi
On Sat, Jun 14, 2014 at 1:29 AM, Ming Lei wrote: > Firstly this patch supports more than one virtual queues for virtio-blk > device. > > Secondly this patch maps the virtual queue to blk-mq's hardware queue. > > With this approach, both scalability and performance problem can be improved. > > Sign

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-04-01 Thread Stefan Hajnoczi
On Tue, Apr 1, 2014 at 4:27 AM, Theodore Ts'o wrote: > On Mon, Mar 31, 2014 at 02:22:50PM +1030, Rusty Russell wrote: >> >> It's head of my virtio-next tree. > > Hey Rusty, > > While we have your attention --- what's your opinion about adding TRIM > support to virtio-blk. I understand that you're

Re: updated: kvm networking todo wiki

2013-05-29 Thread Stefan Hajnoczi
On Thu, May 30, 2013 at 7:23 AM, Rusty Russell wrote: > Anthony Liguori writes: >> Rusty Russell writes: >>> On Fri, May 24, 2013 at 08:47:58AM -0500, Anthony Liguori wrote: FWIW, I think what's more interesting is using vhost-net as a networking backend with virtio-net in QEMU being w

Re: 2013 Linux Plumbers Virtualization Microconference proposal call for participation

2013-05-17 Thread Stefan Hajnoczi
On Thu, May 16, 2013 at 02:32:30PM -0600, Alex Williamson wrote: > We'd like to hold another virtualization microconference as part of this > year's Linux Plumbers Conference. To do so, we need to show that > there's enough interest, materials, and people willing to attend. Convenience info: Se

Re: [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-03-19 Thread Stefan Hajnoczi
On Tue, Mar 19, 2013 at 08:34:45AM +0800, Asias He wrote: > --- > hw/vhost.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/vhost.c b/hw/vhost.c > index 4d6aee3..0c52ec4 100644 > --- a/hw/vhost.c > +++ b/hw/vhost.c > @@ -421,10 +421,12 @@ static void vhost_set_memory(MemoryListener

Re: [PATCH V3 WIP 2/3] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-03-19 Thread Stefan Hajnoczi
On Tue, Mar 19, 2013 at 08:34:44AM +0800, Asias He wrote: > +static void vhost_scsi_stop(VHostSCSI *vs, VirtIODevice *vdev) > +{ > +int ret = 0; > + > +if (!vdev->binding->set_guest_notifiers) { > +ret = vdev->binding->set_guest_notifiers(vdev->binding_opaque, > +

Re: [PATCH V2 WIP 2/2] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-03-12 Thread Stefan Hajnoczi
On Tue, Mar 12, 2013 at 02:29:42PM +0800, Asias He wrote: > diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c > index 39c1966..4a97ca1 100644 > --- a/hw/virtio-pci.c > +++ b/hw/virtio-pci.c These changes break the build for non-Linux hosts. Please introduce a CONFIG_VHOST_SCSI and #ifdef appropriate

Re: [PATCH V2 0/6] tcm_vhost hotplug/hotunplug support and locking/flushing fix

2013-03-08 Thread Stefan Hajnoczi
) > > drivers/vhost/tcm_vhost.c | 243 > -- > drivers/vhost/tcm_vhost.h | 10 ++ > 2 files changed, 247 insertions(+), 6 deletions(-) > > -- > 1.8.1.4 > Reviewed-by: Stefan Hajnoczi

Re: [PATCH 5/5] tcm_vhost: Add hotplug/hotunplug support

2013-03-07 Thread Stefan Hajnoczi
On Thu, Mar 07, 2013 at 05:47:26PM +0800, Asias He wrote: > On Thu, Mar 07, 2013 at 09:58:04AM +0100, Stefan Hajnoczi wrote: > > On Thu, Mar 07, 2013 at 08:26:20AM +0800, Asias He wrote: > > > On Wed, Mar 06, 2013 at 10:21:09AM +0100, Stefan Hajnoczi wrote: > > > >

Re: [PATCH 5/5] tcm_vhost: Add hotplug/hotunplug support

2013-03-07 Thread Stefan Hajnoczi
On Thu, Mar 07, 2013 at 08:26:20AM +0800, Asias He wrote: > On Wed, Mar 06, 2013 at 10:21:09AM +0100, Stefan Hajnoczi wrote: > > On Wed, Mar 06, 2013 at 02:16:30PM +0800, Asias He wrote: > > > +static struct tcm_vhost_evt *tcm_vhost_allocate_evt(struct vhost_scsi > > >

<    2   3   4   5   6   7   8   9   >