Re: [net-next v2] virtio_net: replace netdev_alloc_skb_ip_align() with napi_alloc_skb()

2016-03-20 Thread Venkatesh Srinivas via Virtualization
align() invocation in > add_recvbuf_small(), suggested by Venkatesh Srinivas > --- > drivers/net/virtio_net.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index fb0eae4..100e039 100644 > --- a/drivers/net/

Re: [PATCH net-next] virtio_net: replace netdev_alloc_skb_ip_align() with napi_alloc_skb()

2016-03-19 Thread Venkatesh Srinivas via Virtualization
- +1% bandwidth). What tests did you see a 2-3% win on? Do you think its worth modifying add_recvbuf_small() to use napi_alloc_skb() when called from Rx NAPI (virtnet_receive)? Tested-by: Venkatesh Srinivas Thanks, -- vs; ___ Virtualization mailing list

Re: [PATCH net-next] virtio_net: replace netdev_alloc_skb_ip_align() with napi_alloc_skb()

2016-03-19 Thread Venkatesh Srinivas via Virtualization
noise (+0.6% - +1% bandwidth). What tests did you see a 2-3% win on? Do you think its worth modifying add_recvbuf_small() to use napi_alloc_skb() when called from Rx NAPI (virtnet_receive)? Tested-by: Venkatesh Srinivas Thanks, -- vs; ___ Virtualiz

Re: [PATCH v2] vhost: replace % with & on data path

2015-12-04 Thread Venkatesh Srinivas via Virtualization
On Mon, Nov 30, 2015 at 11:15:23AM +0200, Michael S. Tsirkin wrote: > We know vring num is a power of 2, so use & > to mask the high bits. > > Signed-off-by: Michael S. Tsirkin > --- The generated code switches from DIV -> masking, source is clearer as well. Tested-

Re: [PATCH] tools/virtio: fix byteswap logic

2015-12-04 Thread Venkatesh Srinivas via Virtualization
> > static inline __virtio64 cpu_to_virtio64(struct virtio_device *vdev, u64 val) > { > - return __cpu_to_virtio64(virtio_has_feature(vdev, VIRTIO_F_VERSION_1), > val); > + return __cpu_to_virtio64(virtio_is_little_endian(vdev), val); > } Tested patch with vring-bench. (I did somet

Re: [PATCH] virtio_ring: Shadow available ring flags & index

2015-11-20 Thread Venkatesh Srinivas via Virtualization
On Thu, Nov 19, 2015 at 04:15:48PM +, Xie, Huawei wrote: > On 11/18/2015 12:28 PM, Venkatesh Srinivas wrote: > > On Tue, Nov 17, 2015 at 08:08:18PM -0800, Venkatesh Srinivas wrote: > >> On Mon, Nov 16, 2015 at 7:46 PM, Xie, Huawei wrote: > >> > >>> On

Re: [PATCH] virtio_ring: Shadow available ring flags & index

2015-11-17 Thread Venkatesh Srinivas via Virtualization
On Tue, Nov 17, 2015 at 08:08:18PM -0800, Venkatesh Srinivas wrote: > On Mon, Nov 16, 2015 at 7:46 PM, Xie, Huawei wrote: > > > On 11/14/2015 7:41 AM, Venkatesh Srinivas wrote: > > > On Wed, Nov 11, 2015 at 02:34:33PM +0200, Michael S. Tsirkin wrote: > > >> O

Re: [PATCH] virtio_ring: Shadow available ring flags & index

2015-11-17 Thread Venkatesh Srinivas via Virtualization
On Mon, Nov 16, 2015 at 7:46 PM, Xie, Huawei wrote: > On 11/14/2015 7:41 AM, Venkatesh Srinivas wrote: > > On Wed, Nov 11, 2015 at 02:34:33PM +0200, Michael S. Tsirkin wrote: > >> On Tue, Nov 10, 2015 at 04:21:07PM -0800, Venkatesh Srinivas wrote: > >>> Impro

Re: [PATCH] virtio_ring: Shadow available ring flags & index

2015-11-13 Thread Venkatesh Srinivas via Virtualization
On Wed, Nov 11, 2015 at 02:34:33PM +0200, Michael S. Tsirkin wrote: > On Tue, Nov 10, 2015 at 04:21:07PM -0800, Venkatesh Srinivas wrote: > > Improves cacheline transfer flow of available ring header. > > > > Virtqueues are implemented as a pair of rings, one producer->con

[PATCH] virtio_ring: Shadow available ring flags & index

2015-11-10 Thread Venkatesh Srinivas via Virtualization
1-dcache-loads ... 2.168405376 seconds time elapsed The further away (in a NUMA sense) virtio producers and consumers are from each other, the more we expect to benefit. Physical implementations of virtio devices and implementations of virtio where the consumer polls vring a

[PATCH] virtio-scsi: Implement change_queue_depth for virtscsi targets

2014-05-23 Thread Venkatesh Srinivas
has resolved. Signed-off-by: Venkatesh Srinivas --- drivers/scsi/virtio_scsi.c | 33 + 1 file changed, 33 insertions(+) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index db3b494..6cd39cd 100644 --- a/drivers/scsi/virtio_scsi.c +++ b

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-03-25 Thread Venkatesh Srinivas
On Wed, Mar 19, 2014 at 10:48 AM, Venkatesh Srinivas wrote: >> And I rewrote it substantially, mainly to take >> VIRTIO_RING_F_INDIRECT_DESC into account. >> >> As QEMU sets the vq size for PCI to 128, Venkatash's patch wouldn't >> have made a change. T

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-03-19 Thread Venkatesh Srinivas
ivide-by-2 produced the same queue depth as the prior computation in QEMU was deliberate -- but raising it to 128 seems pretty reasonable. Signed-off-by: Venkatesh Srinivas -- vs; ___ Virtualization mailing list Virtualization@list

[PATCH] virtio-blk: Initialize blkqueue depth from virtqueue size

2014-03-14 Thread Venkatesh Srinivas
virtio-blk set the default queue depth to 64 requests, which was insufficient for high-IOPS devices. Instead set the blk-queue depth to the device's virtqueue depth divided by two (each I/O requires at least two VQ entries). Signed-off-by: Venkatesh Srinivas --- drivers/block/virtio_blk.

Re: [PATCH] perf/x86/intel: Use rdmsrl_safe when initializing RAPL PMU.

2014-03-14 Thread Venkatesh Srinivas
On Fri, Mar 14, 2014 at 10:57:58AM -0600, David Ahern wrote: On 3/14/14, 10:17 AM, Andi Kleen wrote: The Intel ISR section for RDMSR seems to say: "Specifying a reserved or unimplemented MSR address in ECX will also cause a general protection exception". From a guest's perspective, MSR_RAPL_POW

Possible bug in KVM arch/x86/kvm/emulate.c:check_cr_write()?

2013-05-20 Thread Venkatesh Srinivas
Hi, When KVM's check_cr_write() is invoked to write to %cr3, it tests that the lower three bits of %cr3 are set to zero. On real h/w (tested on Core2, K10), these bits are ignored; the AMD64 documentation describes the bits as 'should', but not 'must' be zero. The Intel documentation seems to indi

Re: [PATCH V6 4/5] virtio-scsi: introduce multiqueue support

2013-03-20 Thread Venkatesh Srinivas
the hint fast enough. Looks good! Tested as V5. Tested-by: Venkatesh Srinivas -- vs; ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH V5 4/5] virtio-scsi: introduce multiqueue support

2013-03-19 Thread Venkatesh Srinivas
Engine's virtio-scsi device. Reviewed-and-tested-by: Venkatesh Srinivas Thanks, -- vs; ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization