Re: [PATCH][RESEND] Relax BUG_ON()s when enabling/disabling virt_ring interrupts

2008-01-06 Thread Rusty Russell
On Monday 07 January 2008 14:27:31 Rusty Russell wrote: > + /* Other side may have missed us turning off the interrupt, > + * but we should preserve disable semantic for virtio users. */ > + if (unlikely(!(vq->vring.avail->flags & VRING_AVAIL_F_NO_INTERRUPT))) { > + pr_debu

Re: [PATCH][RESEND] Relax BUG_ON()s when enabling/disabling virt_ring interrupts

2008-01-06 Thread Rusty Russell
On Sunday 06 January 2008 13:43:51 Anthony Liguori wrote: > Currently, the virt_ring->enable_cb and virt_ring->disable_cb functions > enforce that they were called only when callbacks were disabled and enabled > respectively. However, in the current vring implementation, this isn't > actually a bu

[PATCH][RESEND] Relax BUG_ON()s when enabling/disabling virt_ring interrupts

2008-01-05 Thread Anthony Liguori
Currently, the virt_ring->enable_cb and virt_ring->disable_cb functions enforce that they were called only when callbacks were disabled and enabled respectively. However, in the current vring implementation, this isn't actually a bug. What's more, the virtio_net driver does not guard against doub