Here's the latest. Hope this works for everyone (putting in a oom handler or
shrinker requires a lock, but can be done quite easily).
Untested.
===
After discussions with Anthony Liguori, it seems that the virtio
balloon can be made even simpler. Here's my attempt.
Signed-off-by: Rusty Russell
Marcelo Tosatti wrote:
On Sat, Jan 19, 2008 at 04:37:43PM -0600, Anthony Liguori wrote:
Avi Kivity wrote:
Rusty Russell wrote:
After discussions with Anthony Liguori, it seems that the virtio
balloon can be made even simpler. Here's my attempt.
Since the balloon requires Guest
On Sat, Jan 19, 2008 at 04:37:43PM -0600, Anthony Liguori wrote:
> Avi Kivity wrote:
> >Rusty Russell wrote:
> >>After discussions with Anthony Liguori, it seems that the virtio
> >>balloon can be made even simpler. Here's my attempt.
> >>
> >>Since the balloon requires Guest cooperation anyway, t
Avi Kivity wrote:
Rusty Russell wrote:
After discussions with Anthony Liguori, it seems that the virtio
balloon can be made even simpler. Here's my attempt.
Since the balloon requires Guest cooperation anyway, there seems
little reason to force it to tell the Host when it wants to reuse a
page
Anthony Liguori wrote:
It would be very useful too to write vb->num_pages into the config space
whenever it was updated. This way, the host can easily keep track of
where the guest is at in terms of ballooning.
OTOH it's currently pretty obvious (and usually fatal) if the gue
Rusty Russell wrote:
After discussions with Anthony Liguori, it seems that the virtio
balloon can be made even simpler. Here's my attempt.
Since the balloon requires Guest cooperation anyway, there seems
little reason to force it to tell the Host when it wants to reuse a
page. It can simply fa
Dor Laor wrote:
On Thu, 2008-01-17 at 07:56 -0600, Anthony Liguori wrote:
Dor Laor wrote:
On Thu, 2008-01-17 at 11:25 +0100, Martin Schwidefsky wrote:
Another idea: Martin added an oom notifier to the cmm driver. Before the
oom-killer kicks in cmm will try to free 256 pages.
On Thu, 2008-01-17 at 07:56 -0600, Anthony Liguori wrote:
> Dor Laor wrote:
> > On Thu, 2008-01-17 at 11:25 +0100, Martin Schwidefsky wrote:
> >
> >>> Another idea: Martin added an oom notifier to the cmm driver. Before the
> >>> oom-killer kicks in cmm will try to free 256 pages. I think your
On Thu, 2008-01-17 at 10:32 +0100, Christian Borntraeger wrote:
> Am Donnerstag, 17. Januar 2008 schrieb Rusty Russell:
> > Since the balloon requires Guest cooperation anyway, there seems
> > little reason to force it to tell the Host when it wants to reuse a
> > page. It can simply fault it in.
Dor Laor wrote:
On Thu, 2008-01-17 at 11:25 +0100, Martin Schwidefsky wrote:
Another idea: Martin added an oom notifier to the cmm driver. Before the
oom-killer kicks in cmm will try to free 256 pages. I think your virtio
balloon driver should do the same - it seems to be the correct tradeof
On Thu, 2008-01-17 at 11:25 +0100, Martin Schwidefsky wrote:
> >
> > Another idea: Martin added an oom notifier to the cmm driver. Before the
> > oom-killer kicks in cmm will try to free 256 pages. I think your virtio
> > balloon driver should do the same - it seems to be the correct tradeoff.
Am Donnerstag, 17. Januar 2008 schrieb Rusty Russell:
> Since the balloon requires Guest cooperation anyway, there seems
> little reason to force it to tell the Host when it wants to reuse a
> page. It can simply fault it in.
Yes, thats what we do in the s390 cmm driver.
All in all the driver has
On Thursday 17 January 2008 15:01:46 Anthony Liguori wrote:
> Rusty Russell wrote:
> > OTOH it's currently pretty obvious (and usually fatal) if the guest has
> > trouble meeting the balloon requirements. A serious host needs a way of
> > detecting stress in the guest anyway, which this doesn't of
Rusty Russell wrote:
On Thursday 17 January 2008 13:14:58 Anthony Liguori wrote:
Rusty Russell wrote:
+static struct virtio_device_id id_table[] = {
+ { VIRTIO_ID_BALLOON, VIRTIO_DEV_ANY_ID},
Could use a space after VIRTIO_DEV_ANY_ID
Thanks, fixed.
+
On Thursday 17 January 2008 13:14:58 Anthony Liguori wrote:
> Rusty Russell wrote:
> > +static struct virtio_device_id id_table[] = {
> > + { VIRTIO_ID_BALLOON, VIRTIO_DEV_ANY_ID},
>
> Could use a space after VIRTIO_DEV_ANY_ID
Thanks, fixed.
> > + __free_page(page);
> > + vb
Rusty Russell wrote:
After discussions with Anthony Liguori, it seems that the virtio
balloon can be made even simpler. Here's my attempt.
Since the balloon requires Guest cooperation anyway, there seems
little reason to force it to tell the Host when it wants to reuse a
page. It can simply fa
After discussions with Anthony Liguori, it seems that the virtio
balloon can be made even simpler. Here's my attempt.
Since the balloon requires Guest cooperation anyway, there seems
little reason to force it to tell the Host when it wants to reuse a
page. It can simply fault it in.
Moreover, t
17 matches
Mail list logo