Re: [PATCH] docs: driver-api: virtio: virtio on Linux

2022-08-03 Thread Matthew Wilcox
On Wed, Aug 03, 2022 at 09:24:49AM +0200, Ricardo Cañuelo wrote: > Hi Matthew, > > On mar, ago 02 2022 at 16:56:48, Matthew Wilcox wrote: > > You don't need to use :c:func:`foo`. You can just write foo() and the > > tooling will convert it into :c:func:`foo` for you. > > Thanks for the tip. How

Re: [PATCH] docs: driver-api: virtio: virtio on Linux

2022-08-03 Thread Cornelia Huck
On Wed, Aug 03 2022, Ricardo Cañuelo wrote: >> v1.2 is out now :) >> >> (I think it would be better to refer to the base spec directory?) > > Do you mean this? https://docs.oasis-open.org/virtio/virtio/ > Or should I link the source repo instead? > https://github.com/oasis-tcs/virtio-spec Hm...

Re: [PATCH] docs: driver-api: virtio: virtio on Linux

2022-08-03 Thread Ricardo Cañuelo
Hi Michael, thanks for reviewing the patch. Comments below: On mié, ago 03 2022 at 02:54:28, "Michael S. Tsirkin" wrote: > So I'm okay with a high level overview up to this point. > Below starts getting into details and they are not up to date > and I don't think we want to maintain a copy here.

Re: [PATCH] docs: driver-api: virtio: virtio on Linux

2022-08-03 Thread Ricardo Cañuelo
Hi Cornelia, Thanks for the review. This is my first approach to virtio and I had to make some assumptions myself from reading the code and the spec, so I expected lots of corrections. On mar, ago 02 2022 at 17:55:43, Cornelia Huck wrote: > I think kerneldoc updates should be split out into a se

Re: [PATCH] docs: driver-api: virtio: virtio on Linux

2022-08-03 Thread Ricardo Cañuelo
Hi Matthew, On mar, ago 02 2022 at 16:56:48, Matthew Wilcox wrote: > You don't need to use :c:func:`foo`. You can just write foo() and the > tooling will convert it into :c:func:`foo` for you. Thanks for the tip. However, I did some tests and the results aren't quite the same. For functions wit

Re: [PATCH] docs: driver-api: virtio: virtio on Linux

2022-08-03 Thread Ricardo Cañuelo
Matthew Wilcox writes: > On Tue, Aug 02, 2022 at 02:42:22PM +0200, Ricardo Cañuelo wrote: >> +In this case, when the interrupt arrives :c:func:`vp_interrupt` will be >> +called and it will ultimately lead to a call to >> +:c:func:`vring_interrupt`, which ends up calling the virtqueue callback >>

Re: [PATCH] docs: driver-api: virtio: virtio on Linux

2022-08-02 Thread Michael S. Tsirkin
On Tue, Aug 02, 2022 at 02:42:22PM +0200, Ricardo Cañuelo wrote: > Basic doc about Virtio on Linux and a short tutorial on Virtio drivers. > Minor fixes to existing virtio kerneldocs. > > Signed-off-by: Ricardo Cañuelo > --- > Documentation/driver-api/index.rst| 1 + > Documentatio

Re: [PATCH] docs: driver-api: virtio: virtio on Linux

2022-08-02 Thread Ricardo Cañuelo
Hi Bagas, Thanks for reviewing Bagas Sanjaya writes: > I can't apply this patch on top of mainline. On what commit (and what > tree) was it based from? The patch applies cleanly on recent tags of linux-next (tested on next-20220802). If this needs to be tested on a different tree/commit let me

Re: [PATCH] docs: driver-api: virtio: virtio on Linux

2022-08-02 Thread Matthew Wilcox
On Tue, Aug 02, 2022 at 02:42:22PM +0200, Ricardo Cañuelo wrote: > +In this case, when the interrupt arrives :c:func:`vp_interrupt` will be > +called and it will ultimately lead to a call to > +:c:func:`vring_interrupt`, which ends up calling the virtqueue callback > +function:: You don't need to

Re: [PATCH] docs: driver-api: virtio: virtio on Linux

2022-08-02 Thread Cornelia Huck
On Tue, Aug 02 2022, Ricardo Cañuelo wrote: > Basic doc about Virtio on Linux and a short tutorial on Virtio drivers. > Minor fixes to existing virtio kerneldocs. I think kerneldoc updates should be split out into a separate patch. [No proper review, just some things I noticed below.] > > Sign

[PATCH] docs: driver-api: virtio: virtio on Linux

2022-08-02 Thread Ricardo Cañuelo
Basic doc about Virtio on Linux and a short tutorial on Virtio drivers. Minor fixes to existing virtio kerneldocs. Signed-off-by: Ricardo Cañuelo --- Documentation/driver-api/index.rst| 1 + Documentation/driver-api/virtio/index.rst | 11 + Documentation/driver-api/virtio/virt