Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-12-20 Thread Michael S. Tsirkin
On Wed, Dec 07, 2011 at 01:52:35PM -0500, David Miller wrote: From: Michael S. Tsirkin m...@redhat.com Date: Wed, 7 Dec 2011 18:10:02 +0200 On Fri, Nov 25, 2011 at 01:35:52AM -0500, David Miller wrote: From: Krishna Kumar2 krkum...@in.ibm.com Date: Fri, 25 Nov 2011 09:39:11 +0530

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-12-20 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Tue, 20 Dec 2011 13:15:12 +0200 On Wed, Dec 07, 2011 at 01:52:35PM -0500, David Miller wrote: Once you sort this out, reply with an Acked-by: for me, thanks. Acked-by: Michael S. Tsirkin m...@redhat.com Applied.

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-12-08 Thread Jason Wang
On 12/08/2011 12:10 AM, Michael S. Tsirkin wrote: On Fri, Nov 25, 2011 at 01:35:52AM -0500, David Miller wrote: From: Krishna Kumar2krkum...@in.ibm.com Date: Fri, 25 Nov 2011 09:39:11 +0530 Jason Wangjasow...@redhat.com wrote on 11/25/2011 08:51:57 AM: My description is not clear again :( I

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-12-07 Thread Michael S. Tsirkin
On Fri, Nov 25, 2011 at 01:35:52AM -0500, David Miller wrote: From: Krishna Kumar2 krkum...@in.ibm.com Date: Fri, 25 Nov 2011 09:39:11 +0530 Jason Wang jasow...@redhat.com wrote on 11/25/2011 08:51:57 AM: My description is not clear again :( I mean the same vhost thead: vhost

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-12-07 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Wed, 7 Dec 2011 18:10:02 +0200 On Fri, Nov 25, 2011 at 01:35:52AM -0500, David Miller wrote: From: Krishna Kumar2 krkum...@in.ibm.com Date: Fri, 25 Nov 2011 09:39:11 +0530 Jason Wang jasow...@redhat.com wrote on 11/25/2011 08:51:57 AM: My

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-28 Thread Stephen Hemminger
On Mon, 28 Nov 2011 12:25:15 +0800 Jason Wang jasow...@redhat.com wrote: I'm using ixgbe for testing also, for host, its driver seems provide irq affinity hint, so no binding or irqbalance is needed. The hint is for irqbalance to use. You need to still do manual affinity or use irqbalance.

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-27 Thread Michael S. Tsirkin
On Fri, Nov 25, 2011 at 09:39:11AM +0530, Krishna Kumar2 wrote: Jason Wang jasow...@redhat.com wrote on 11/25/2011 08:51:57 AM: My description is not clear again :( I mean the same vhost thead: vhost thread #0 transmits packets of flow A on processor M ... vhost thread #0 move to

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-27 Thread Michael S. Tsirkin
On Fri, Nov 25, 2011 at 01:35:52AM -0500, David Miller wrote: From: Krishna Kumar2 krkum...@in.ibm.com Date: Fri, 25 Nov 2011 09:39:11 +0530 Jason Wang jasow...@redhat.com wrote on 11/25/2011 08:51:57 AM: My description is not clear again :( I mean the same vhost thead: vhost

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-27 Thread Jason Wang
On 11/25/2011 12:09 PM, Krishna Kumar2 wrote: Jason Wangjasow...@redhat.com wrote on 11/25/2011 08:51:57 AM: My description is not clear again :( I mean the same vhost thead: vhost thread #0 transmits packets of flow A on processor M ... vhost thread #0 move to another process N and start to

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-27 Thread Jason Wang
On 11/28/2011 01:23 AM, Michael S. Tsirkin wrote: On Fri, Nov 25, 2011 at 01:35:52AM -0500, David Miller wrote: From: Krishna Kumar2krkum...@in.ibm.com Date: Fri, 25 Nov 2011 09:39:11 +0530 Jason Wangjasow...@redhat.com wrote on 11/25/2011 08:51:57 AM: My description is not clear again :( I

[PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-24 Thread Krishna Kumar
It was reported that the macvtap device selects a different vhost (when used with multiqueue feature) for incoming packets of a single connection. Use packet hash first. Patch tested on MQ virtio_net. Signed-off-by: Krishna Kumar krkum...@in.ibm.com --- drivers/net/macvtap.c | 16

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-24 Thread jasowang
On 11/24/2011 04:17 PM, Krishna Kumar wrote: It was reported that the macvtap device selects a different vhost (when used with multiqueue feature) for incoming packets of a single connection. Use packet hash first. Patch tested on MQ virtio_net. Signed-off-by: Krishna Kumarkrkum...@in.ibm.com

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-24 Thread Michael S. Tsirkin
On Thu, Nov 24, 2011 at 01:47:14PM +0530, Krishna Kumar wrote: It was reported that the macvtap device selects a different vhost (when used with multiqueue feature) for incoming packets of a single connection. Use packet hash first. Patch tested on MQ virtio_net. So this is sure to address

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-24 Thread jasowang
On 11/24/2011 05:59 PM, Michael S. Tsirkin wrote: On Thu, Nov 24, 2011 at 01:47:14PM +0530, Krishna Kumar wrote: It was reported that the macvtap device selects a different vhost (when used with multiqueue feature) for incoming packets of a single connection. Use packet hash first. Patch tested

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-24 Thread Michael S. Tsirkin
On Thu, Nov 24, 2011 at 06:13:41PM +0800, jasowang wrote: On 11/24/2011 05:59 PM, Michael S. Tsirkin wrote: On Thu, Nov 24, 2011 at 01:47:14PM +0530, Krishna Kumar wrote: It was reported that the macvtap device selects a different vhost (when used with multiqueue feature) for incoming packets

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-24 Thread Krishna Kumar2
Michael S. Tsirkin m...@redhat.com wrote on 11/24/2011 03:29:03 PM: Subject Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first On Thu, Nov 24, 2011 at 01:47:14PM +0530, Krishna Kumar wrote: It was reported that the macvtap device selects a different vhost (when used

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-24 Thread jasowang
On 11/24/2011 06:34 PM, Michael S. Tsirkin wrote: On Thu, Nov 24, 2011 at 06:13:41PM +0800, jasowang wrote: On 11/24/2011 05:59 PM, Michael S. Tsirkin wrote: On Thu, Nov 24, 2011 at 01:47:14PM +0530, Krishna Kumar wrote: It was reported that the macvtap device selects a different vhost (when

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-24 Thread jasowang
On 11/24/2011 07:14 PM, Krishna Kumar2 wrote: Michael S. Tsirkinm...@redhat.com wrote on 11/24/2011 03:29:03 PM: Subject Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first On Thu, Nov 24, 2011 at 01:47:14PM +0530, Krishna Kumar wrote: It was reported that the macvtap device

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-24 Thread Michael S. Tsirkin
On Thu, Nov 24, 2011 at 09:00:52PM +0800, jasowang wrote: On 11/24/2011 07:14 PM, Krishna Kumar2 wrote: Michael S. Tsirkinm...@redhat.com wrote on 11/24/2011 03:29:03 PM: Subject Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first On Thu, Nov 24, 2011 at 01:47:14PM +0530

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-24 Thread Michael S. Tsirkin
On Thu, Nov 24, 2011 at 08:56:45PM +0800, jasowang wrote: On 11/24/2011 06:34 PM, Michael S. Tsirkin wrote: On Thu, Nov 24, 2011 at 06:13:41PM +0800, jasowang wrote: On 11/24/2011 05:59 PM, Michael S. Tsirkin wrote: On Thu, Nov 24, 2011 at 01:47:14PM +0530, Krishna Kumar wrote: It was

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-24 Thread Krishna Kumar2
jasowang jasow...@redhat.com wrote on 11/24/2011 06:30:52 PM: On Thu, Nov 24, 2011 at 01:47:14PM +0530, Krishna Kumar wrote: It was reported that the macvtap device selects a different vhost (when used with multiqueue feature) for incoming packets of a single connection. Use packet

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-24 Thread Jason Wang
On 11/25/2011 12:14 AM, Michael S. Tsirkin wrote: On Thu, Nov 24, 2011 at 08:56:45PM +0800, jasowang wrote: On 11/24/2011 06:34 PM, Michael S. Tsirkin wrote: On Thu, Nov 24, 2011 at 06:13:41PM +0800, jasowang wrote: On 11/24/2011 05:59 PM, Michael S. Tsirkin wrote: On Thu, Nov 24,

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-24 Thread Krishna Kumar2
Michael S. Tsirkin m...@redhat.com wrote on 11/24/2011 09:44:31 PM: As far as I can see, ixgbe binds queues to physical cpu, so let consider: vhost thread transmits packets of flow A on processor M during packet transmission, ixgbe driver programs the card to deliver the packet of flow

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-24 Thread Jason Wang
On 11/25/2011 10:58 AM, Krishna Kumar2 wrote: jasowangjasow...@redhat.com wrote on 11/24/2011 06:30:52 PM: On Thu, Nov 24, 2011 at 01:47:14PM +0530, Krishna Kumar wrote: It was reported that the macvtap device selects a different vhost (when used with multiqueue feature) for incoming packets

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-24 Thread Jason Wang
On 11/25/2011 11:07 AM, Krishna Kumar2 wrote: Michael S. Tsirkinm...@redhat.com wrote on 11/24/2011 09:44:31 PM: As far as I can see, ixgbe binds queues to physical cpu, so let consider: vhost thread transmits packets of flow A on processor M during packet transmission, ixgbe driver

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-24 Thread Krishna Kumar2
Jason Wang jasow...@redhat.com wrote on 11/25/2011 08:51:57 AM: My description is not clear again :( I mean the same vhost thead: vhost thread #0 transmits packets of flow A on processor M ... vhost thread #0 move to another process N and start to transmit packets of flow A Thanks for

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-24 Thread David Miller
From: Krishna Kumar2 krkum...@in.ibm.com Date: Fri, 25 Nov 2011 09:39:11 +0530 Jason Wang jasow...@redhat.com wrote on 11/25/2011 08:51:57 AM: My description is not clear again :( I mean the same vhost thead: vhost thread #0 transmits packets of flow A on processor M ... vhost thread #0