Re: [PATCH] vdpa_sim: fix vringh initialization in vdpasim_queue_ready()

2022-11-14 Thread Stefano Garzarella
On Mon, Nov 14, 2022 at 10:13:51AM +0100, Eugenio Perez Martin wrote: On Fri, Nov 11, 2022 at 5:30 PM Stefano Garzarella wrote: On Fri, Nov 11, 2022 at 04:40:33PM +0100, Eugenio Perez Martin wrote: >On Thu, Nov 10, 2022 at 3:13 PM Stefano Garzarella wrote: >> >> When we initialize vringh, we

Re: [PATCH] vdpa_sim: fix vringh initialization in vdpasim_queue_ready()

2022-11-11 Thread Stefano Garzarella
On Fri, Nov 11, 2022 at 04:40:33PM +0100, Eugenio Perez Martin wrote: On Thu, Nov 10, 2022 at 3:13 PM Stefano Garzarella wrote: When we initialize vringh, we should pass the features and the number of elements in the virtqueue negotiated with the driver, otherwise operations with vringh may fa

Re: [PATCH] vdpa_sim: fix vringh initialization in vdpasim_queue_ready()

2022-11-10 Thread Jason Wang
On Thu, Nov 10, 2022 at 10:13 PM Stefano Garzarella wrote: > > When we initialize vringh, we should pass the features and the > number of elements in the virtqueue negotiated with the driver, > otherwise operations with vringh may fail. > > This was discovered in a case where the driver sets a num

[PATCH] vdpa_sim: fix vringh initialization in vdpasim_queue_ready()

2022-11-10 Thread Stefano Garzarella
When we initialize vringh, we should pass the features and the number of elements in the virtqueue negotiated with the driver, otherwise operations with vringh may fail. This was discovered in a case where the driver sets a number of elements in the virtqueue different from the value returned by .