Re: [PATCH] vhost: validate range size before adding to iotlb

2022-02-23 Thread Michael S. Tsirkin
On Wed, Feb 23, 2022 at 10:19:23PM +0530, Anirudh Rayabharam wrote: > On Wed, Feb 23, 2022 at 10:15:01AM -0500, Michael S. Tsirkin wrote: > > On Wed, Feb 23, 2022 at 07:48:18PM +0530, Anirudh Rayabharam wrote: > > > On Tue, Feb 22, 2022 at 06:21:50PM -0500, Michael S. Tsirkin wrote: > > > > On

Re: [PATCH] vhost: validate range size before adding to iotlb

2022-02-23 Thread Michael S. Tsirkin
On Wed, Feb 23, 2022 at 07:48:18PM +0530, Anirudh Rayabharam wrote: > On Tue, Feb 22, 2022 at 06:21:50PM -0500, Michael S. Tsirkin wrote: > > On Tue, Feb 22, 2022 at 10:57:41PM +0530, Anirudh Rayabharam wrote: > > > On Tue, Feb 22, 2022 at 10:02:29AM -0500, Michael S. Tsirkin wrote: > > > > On

Re: [PATCH] vhost: validate range size before adding to iotlb

2022-02-22 Thread Jason Wang
On Tue, Feb 22, 2022 at 11:02 PM Michael S. Tsirkin wrote: > > On Tue, Feb 22, 2022 at 03:11:07PM +0800, Jason Wang wrote: > > On Tue, Feb 22, 2022 at 12:57 PM Anirudh Rayabharam > > wrote: > > > > > > On Tue, Feb 22, 2022 at 10:50:20AM +0800, Jason Wang wrote: > > > > On Tue, Feb 22, 2022 at

Re: [PATCH] vhost: validate range size before adding to iotlb

2022-02-22 Thread Michael S. Tsirkin
On Tue, Feb 22, 2022 at 10:57:41PM +0530, Anirudh Rayabharam wrote: > On Tue, Feb 22, 2022 at 10:02:29AM -0500, Michael S. Tsirkin wrote: > > On Tue, Feb 22, 2022 at 03:11:07PM +0800, Jason Wang wrote: > > > On Tue, Feb 22, 2022 at 12:57 PM Anirudh Rayabharam > > > wrote: > > > > > > > > On Tue,

Re: [PATCH] vhost: validate range size before adding to iotlb

2022-02-22 Thread Michael S. Tsirkin
On Tue, Feb 22, 2022 at 03:11:07PM +0800, Jason Wang wrote: > On Tue, Feb 22, 2022 at 12:57 PM Anirudh Rayabharam > wrote: > > > > On Tue, Feb 22, 2022 at 10:50:20AM +0800, Jason Wang wrote: > > > On Tue, Feb 22, 2022 at 3:53 AM Anirudh Rayabharam > > > wrote: > > > > > > > > In

Re: [PATCH] vhost: validate range size before adding to iotlb

2022-02-22 Thread Michael S. Tsirkin
On Tue, Feb 22, 2022 at 01:23:03AM +0530, Anirudh Rayabharam wrote: > In vhost_iotlb_add_range_ctx(), validate the range size is non-zero > before proceeding with adding it to the iotlb. > > Range size can overflow to 0 when start is 0 and last is (2^64 - 1). > One instance where it can happen is

Re: [PATCH] vhost: validate range size before adding to iotlb

2022-02-21 Thread Jason Wang
On Tue, Feb 22, 2022 at 12:57 PM Anirudh Rayabharam wrote: > > On Tue, Feb 22, 2022 at 10:50:20AM +0800, Jason Wang wrote: > > On Tue, Feb 22, 2022 at 3:53 AM Anirudh Rayabharam > > wrote: > > > > > > In vhost_iotlb_add_range_ctx(), validate the range size is non-zero > > > before proceeding

Re: [PATCH] vhost: validate range size before adding to iotlb

2022-02-21 Thread Jason Wang
On Tue, Feb 22, 2022 at 3:53 AM Anirudh Rayabharam wrote: > > In vhost_iotlb_add_range_ctx(), validate the range size is non-zero > before proceeding with adding it to the iotlb. > > Range size can overflow to 0 when start is 0 and last is (2^64 - 1). > One instance where it can happen is when