Re: [PATCH] vhost-vdpa: print error when vhost_vdpa_alloc_domain fails

2023-02-01 Thread Alvaro Karsz
> > dev_warn then? > > dev_warn_once is ok. Ok, thanks I'll send a new version tomorrow. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH] vhost-vdpa: print error when vhost_vdpa_alloc_domain fails

2023-02-01 Thread Michael S. Tsirkin
On Wed, Feb 01, 2023 at 05:54:53PM +0200, Alvaro Karsz wrote: > > I'm not sure this is a good idea. Userspace is not supposed to be > > able to trigger dev_err. > > dev_warn then? dev_warn_once is ok. -- MST ___ Virtualization mailing list Virtualiza

Re: [PATCH] vhost-vdpa: print error when vhost_vdpa_alloc_domain fails

2023-02-01 Thread Alvaro Karsz
> I'm not sure this is a good idea. Userspace is not supposed to be > able to trigger dev_err. dev_warn then? ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH] vhost-vdpa: print error when vhost_vdpa_alloc_domain fails

2023-02-01 Thread Michael S. Tsirkin
On Wed, Feb 01, 2023 at 05:20:18PM +0200, Alvaro Karsz wrote: > Add a print explaining why vhost_vdpa_alloc_domain failed if the device > is not IOMMU cache coherent capable. > > Without this print, we have no hint why the operation failed. > > For example: > > $ virsh start > error: Fail

[PATCH] vhost-vdpa: print error when vhost_vdpa_alloc_domain fails

2023-02-01 Thread Alvaro Karsz
Add a print explaining why vhost_vdpa_alloc_domain failed if the device is not IOMMU cache coherent capable. Without this print, we have no hint why the operation failed. For example: $ virsh start error: Failed to start domain error: Unable to open '/dev/vhost-vdpa-' for vdpa