On 20/12/22 11:25, Michael S. Tsirkin wrote:
This doesn't matter I think, what Fixes tag does is tell tools
if you have commit A you want this one on top.
Ok, thanks for clarifying. v3 submitted.
Cheers,
Ricardo
___
Virtualization mailing list
On Tue, Dec 20, 2022 at 10:54:17AM +0100, Ricardo Cañuelo wrote:
> Hi Bagas,
>
> Thanks for the review, some comments below:
>
> On 20/12/22 10:12, Bagas Sanjaya wrote:> On Tue, Dec 20, 2022 at 08:37:09AM
> +0100, Ricardo Cañuelo wrote:
> > Describe the steps needed to fix both warnings above.
On 20/12/22 10:48, AngeloGioacchino Del Regno wrote:
To avoid getting the same warning in the future (developer mistake and/or other
reasons), what about dropping this instance of "Note:" entirely?
I think that something like...
the dev->feature bits if it wants. Note that despite the
Hi Bagas,
Thanks for the review, some comments below:
On 20/12/22 10:12, Bagas Sanjaya wrote:> On Tue, Dec 20, 2022 at 08:37:09AM
+0100, Ricardo Cañuelo wrote:
Describe the steps needed to fix both warnings above. I see in the diff that:
* move vq_callback_t() declaration above;
*
Fixes two warning messages when building htmldocs:
warning: duplicate section name 'Note'
warning: expecting prototype for virtio_config_ops().
Prototype was for vq_callback_t() instead
Signed-off-by: Ricardo Cañuelo
---
include/linux/virtio_config.h | 9 +
1 file
