Re: [PATCH] virtio_net/virtio_ring: fix race in enable_cb

2008-03-17 Thread Christian Borntraeger
Am Montag, 17. März 2008 schrieb Rusty Russell: > > > Are you seeing the "Unlikely: restart svq failed" message in the logs? [...] > Interesting you don't see this. Or is it just on that load that you don't > see it? Dont know. I have never seen it under my test load. Christian ___

Re: [PATCH] virtio_net/virtio_ring: fix race in enable_cb

2008-03-17 Thread Rusty Russell
On Monday 17 March 2008 17:30:44 Christian Borntraeger wrote: > > Are you seeing the "Unlikely: restart svq failed" message in the logs? > > If not, I don't think it can be this race. > > No, I dont see the message, but this message only happens for guest->host > traffic in the xmit function. Int

Re: [PATCH] virtio_net/virtio_ring: fix race in enable_cb

2008-03-16 Thread Christian Borntraeger
> Are you seeing the "Unlikely: restart svq failed" message in the logs? If > not, I don't think it can be this race. No, I dont see the message, but this message only happens for guest->host traffic in the xmit function. I was fixing the poll function - which has no printk. I added the disabl

Re: [PATCH] virtio_net/virtio_ring: fix race in enable_cb

2008-03-16 Thread Rusty Russell
On Saturday 15 March 2008 00:17:05 Christian Borntraeger wrote: > There is a race in virtio_net, dealing with disabling/enabling the > callback. I saw the following oops: > > kernel BUG at /space/kvm/drivers/virtio/virtio_ring.c:218! > illegal operation: 0001 [#1] SMP > Modules linked in: sunrpc dm

[PATCH] virtio_net/virtio_ring: fix race in enable_cb

2008-03-14 Thread Christian Borntraeger
There is a race in virtio_net, dealing with disabling/enabling the callback. I saw the following oops: kernel BUG at /space/kvm/drivers/virtio/virtio_ring.c:218! illegal operation: 0001 [#1] SMP Modules linked in: sunrpc dm_mod CPU: 2 Not tainted 2.6.25-rc1zlive-host-10623-gd358142-dirty #99 Proce