Re: [PATCH] virtio_ring: Fix mem leak with vring_new_virtqueue()

2020-03-07 Thread Michael S. Tsirkin
On Thu, Mar 05, 2020 at 06:27:53PM -0600, Suman Anna wrote: > On 2/25/20 9:13 PM, Jason Wang wrote: > > > > On 2020/2/26 上午12:51, Suman Anna wrote: > >> Hi Jason, > >> > >> On 2/24/20 11:39 PM, Jason Wang wrote: > >>> On 2020/2/25 上午5:26, Suman Anna wrote: > The functions

Re: [PATCH] virtio_ring: Fix mem leak with vring_new_virtqueue()

2020-03-05 Thread Suman Anna via Virtualization
On 2/25/20 9:13 PM, Jason Wang wrote: > > On 2020/2/26 上午12:51, Suman Anna wrote: >> Hi Jason, >> >> On 2/24/20 11:39 PM, Jason Wang wrote: >>> On 2020/2/25 上午5:26, Suman Anna wrote: The functions vring_new_virtqueue() and __vring_new_virtqueue() are used with split rings, and any

Re: [PATCH] virtio_ring: Fix mem leak with vring_new_virtqueue()

2020-02-26 Thread Suman Anna via Virtualization
On 2/25/20 9:13 PM, Jason Wang wrote: > > On 2020/2/26 上午12:51, Suman Anna wrote: >> Hi Jason, >> >> On 2/24/20 11:39 PM, Jason Wang wrote: >>> On 2020/2/25 上午5:26, Suman Anna wrote: The functions vring_new_virtqueue() and __vring_new_virtqueue() are used with split rings, and any

Re: [PATCH] virtio_ring: Fix mem leak with vring_new_virtqueue()

2020-02-25 Thread Jason Wang
On 2020/2/26 上午12:51, Suman Anna wrote: Hi Jason, On 2/24/20 11:39 PM, Jason Wang wrote: On 2020/2/25 上午5:26, Suman Anna wrote: The functions vring_new_virtqueue() and __vring_new_virtqueue() are used with split rings, and any allocations within these functions are managed outside of the

Re: [PATCH] virtio_ring: Fix mem leak with vring_new_virtqueue()

2020-02-25 Thread Suman Anna via Virtualization
Hi Jason, On 2/24/20 11:39 PM, Jason Wang wrote: > > On 2020/2/25 上午5:26, Suman Anna wrote: >> The functions vring_new_virtqueue() and __vring_new_virtqueue() are used >> with split rings, and any allocations within these functions are managed >> outside of the .we_own_ring flag. The commit

Re: [PATCH] virtio_ring: Fix mem leak with vring_new_virtqueue()

2020-02-24 Thread Jason Wang
On 2020/2/25 上午5:26, Suman Anna wrote: The functions vring_new_virtqueue() and __vring_new_virtqueue() are used with split rings, and any allocations within these functions are managed outside of the .we_own_ring flag. The commit cbeedb72b97a ("virtio_ring: allocate desc state for split ring

[PATCH] virtio_ring: Fix mem leak with vring_new_virtqueue()

2020-02-24 Thread Suman Anna via Virtualization
The functions vring_new_virtqueue() and __vring_new_virtqueue() are used with split rings, and any allocations within these functions are managed outside of the .we_own_ring flag. The commit cbeedb72b97a ("virtio_ring: allocate desc state for split ring separately") allocates the desc state within