Re: [PATCH] virtio_ring: fix packed ring event may missing

2019-10-27 Thread Michael S. Tsirkin
> To: Liu, Yong ; m...@redhat.com; Bie, Tiwei > > > > > > Cc: virtualization@lists.linux-foundation.org > > > Subject: Re: [PATCH] virtio_ring: fix packed ring event may missing > > > > > > > > > On 2019/10/22 下午2:48, Liu, Yong wrote: > &g

Re: [PATCH] virtio_ring: fix packed ring event may missing

2019-10-27 Thread Michael S. Tsirkin
On Tue, Oct 22, 2019 at 01:10:04AM +0800, Marvin Liu wrote: > When callback is delayed, virtio expect that vhost will kick when > rolling over event offset. Recheck should be taken as used index may > exceed event offset between status check and driver event update. > > However, it is possible tha

Re: [PATCH] virtio_ring: fix packed ring event may missing

2019-10-27 Thread Michael S. Tsirkin
On Fri, Oct 25, 2019 at 06:53:55AM -0400, Michael S. Tsirkin wrote: > On Tue, Oct 22, 2019 at 01:10:04AM +0800, Marvin Liu wrote: > > When callback is delayed, virtio expect that vhost will kick when > > rolling over event offset. Recheck should be taken as used index may > > exceed event offset be

Re: [PATCH] virtio_ring: fix packed ring event may missing

2019-10-27 Thread Michael S. Tsirkin
On Fri, Oct 25, 2019 at 05:32:49AM -0400, Michael S. Tsirkin wrote: > On Tue, Oct 22, 2019 at 01:10:04AM +0800, Marvin Liu wrote: > > When callback is delayed, virtio expect that vhost will kick when > > rolling over event offset. Recheck should be taken as used index may > > exceed event offset be

Re: [PATCH] virtio_ring: fix packed ring event may missing

2019-10-25 Thread Michael S. Tsirkin
On Tue, Oct 22, 2019 at 01:10:04AM +0800, Marvin Liu wrote: > When callback is delayed, virtio expect that vhost will kick when > rolling over event offset. Recheck should be taken as used index may > exceed event offset between status check and driver event update. > > However, it is possible tha

Re: [PATCH] virtio_ring: fix packed ring event may missing

2019-10-25 Thread Michael S. Tsirkin
On Tue, Oct 22, 2019 at 01:10:04AM +0800, Marvin Liu wrote: > When callback is delayed, virtio expect that vhost will kick when > rolling over event offset. Recheck should be taken as used index may > exceed event offset between status check and driver event update. > > However, it is possible tha

Re: [PATCH] virtio_ring: fix packed ring event may missing

2019-10-23 Thread Jason Wang
Subject: Re: [PATCH] virtio_ring: fix packed ring event may missing On 2019/10/22 上午1:10, Marvin Liu wrote: When callback is delayed, virtio expect that vhost will kick when rolling over event offset. Recheck should be taken as used index may exceed event offset between status check and driver

Re: [PATCH] virtio_ring: fix packed ring event may missing

2019-10-22 Thread Jason Wang
: [PATCH] virtio_ring: fix packed ring event may missing On 2019/10/22 上午1:10, Marvin Liu wrote: When callback is delayed, virtio expect that vhost will kick when rolling over event offset. Recheck should be taken as used index may exceed event offset between status check and driver event update

Re: [PATCH] virtio_ring: fix packed ring event may missing

2019-10-21 Thread Jason Wang
On 2019/10/22 上午1:10, Marvin Liu wrote: When callback is delayed, virtio expect that vhost will kick when rolling over event offset. Recheck should be taken as used index may exceed event offset between status check and driver event update. However, it is possible that flags was not modified if