Re: [PATCH] virtio_ring: validate used buffer length

2023-05-31 Thread Michael S. Tsirkin
On Thu, Jun 01, 2023 at 09:27:08AM +0800, Jason Wang wrote: > On Wed, May 31, 2023 at 6:25 PM Michael S. Tsirkin wrote: > > > > On Wed, May 31, 2023 at 04:26:38PM +0800, Jason Wang wrote: > > > On Wed, May 31, 2023 at 3:36 PM Jason Wang wrote: > > > > > > > > On Wed, May 31, 2023 at 1:50 PM Micha

Re: [PATCH] virtio_ring: validate used buffer length

2023-05-31 Thread Michael S. Tsirkin
On Thu, Jun 01, 2023 at 09:12:53AM +0800, Jason Wang wrote: > On Wed, May 31, 2023 at 5:55 PM Michael S. Tsirkin wrote: > > > > On Wed, May 31, 2023 at 03:36:51PM +0800, Jason Wang wrote: > > > On Wed, May 31, 2023 at 1:50 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Wed, May 31, 2023 a

Re: [PATCH] virtio_ring: validate used buffer length

2023-05-31 Thread Jason Wang
On Wed, May 31, 2023 at 6:25 PM Michael S. Tsirkin wrote: > > On Wed, May 31, 2023 at 04:26:38PM +0800, Jason Wang wrote: > > On Wed, May 31, 2023 at 3:36 PM Jason Wang wrote: > > > > > > On Wed, May 31, 2023 at 1:50 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Wed, May 31, 2023 at 09:

Re: [PATCH] virtio_ring: validate used buffer length

2023-05-31 Thread Jason Wang
On Wed, May 31, 2023 at 5:55 PM Michael S. Tsirkin wrote: > > On Wed, May 31, 2023 at 03:36:51PM +0800, Jason Wang wrote: > > On Wed, May 31, 2023 at 1:50 PM Michael S. Tsirkin wrote: > > > > > > On Wed, May 31, 2023 at 09:05:00AM +0800, Jason Wang wrote: > > > > On Mon, May 29, 2023 at 6:03 PM M

Re: [PATCH] virtio_ring: validate used buffer length

2023-05-31 Thread Michael S. Tsirkin
On Wed, May 31, 2023 at 04:26:38PM +0800, Jason Wang wrote: > On Wed, May 31, 2023 at 3:36 PM Jason Wang wrote: > > > > On Wed, May 31, 2023 at 1:50 PM Michael S. Tsirkin wrote: > > > > > > On Wed, May 31, 2023 at 09:05:00AM +0800, Jason Wang wrote: > > > > On Mon, May 29, 2023 at 6:03 PM Michael

Re: [PATCH] virtio_ring: validate used buffer length

2023-05-31 Thread Michael S. Tsirkin
On Wed, May 31, 2023 at 03:36:51PM +0800, Jason Wang wrote: > On Wed, May 31, 2023 at 1:50 PM Michael S. Tsirkin wrote: > > > > On Wed, May 31, 2023 at 09:05:00AM +0800, Jason Wang wrote: > > > On Mon, May 29, 2023 at 6:03 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, May 29, 2023 a

Re: [PATCH] virtio_ring: validate used buffer length

2023-05-31 Thread Jason Wang
On Wed, May 31, 2023 at 3:36 PM Jason Wang wrote: > > On Wed, May 31, 2023 at 1:50 PM Michael S. Tsirkin wrote: > > > > On Wed, May 31, 2023 at 09:05:00AM +0800, Jason Wang wrote: > > > On Mon, May 29, 2023 at 6:03 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, May 29, 2023 at 09:18

Re: [PATCH] virtio_ring: validate used buffer length

2023-05-31 Thread Jason Wang
On Wed, May 31, 2023 at 1:50 PM Michael S. Tsirkin wrote: > > On Wed, May 31, 2023 at 09:05:00AM +0800, Jason Wang wrote: > > On Mon, May 29, 2023 at 6:03 PM Michael S. Tsirkin wrote: > > > > > > On Mon, May 29, 2023 at 09:18:10AM +0800, Jason Wang wrote: > > > > On Sun, May 28, 2023 at 3:57 PM M

Re: [PATCH] virtio_ring: validate used buffer length

2023-05-30 Thread Michael S. Tsirkin
On Wed, May 31, 2023 at 09:05:00AM +0800, Jason Wang wrote: > On Mon, May 29, 2023 at 6:03 PM Michael S. Tsirkin wrote: > > > > On Mon, May 29, 2023 at 09:18:10AM +0800, Jason Wang wrote: > > > On Sun, May 28, 2023 at 3:57 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Fri, May 26, 2023 a

Re: [PATCH] virtio_ring: validate used buffer length

2023-05-30 Thread Jason Wang
On Mon, May 29, 2023 at 6:03 PM Michael S. Tsirkin wrote: > > On Mon, May 29, 2023 at 09:18:10AM +0800, Jason Wang wrote: > > On Sun, May 28, 2023 at 3:57 PM Michael S. Tsirkin wrote: > > > > > > On Fri, May 26, 2023 at 02:30:41PM +0800, Jason Wang wrote: > > > > This patch validate > > > > > > v

Re: [PATCH] virtio_ring: validate used buffer length

2023-05-29 Thread Michael S. Tsirkin
On Mon, May 29, 2023 at 09:18:10AM +0800, Jason Wang wrote: > On Sun, May 28, 2023 at 3:57 PM Michael S. Tsirkin wrote: > > > > On Fri, May 26, 2023 at 02:30:41PM +0800, Jason Wang wrote: > > > This patch validate > > > > validates > > > > > the used buffer length provided by the device > > > befo

Re: [PATCH] virtio_ring: validate used buffer length

2023-05-28 Thread Jason Wang
On Sun, May 28, 2023 at 3:57 PM Michael S. Tsirkin wrote: > > On Fri, May 26, 2023 at 02:30:41PM +0800, Jason Wang wrote: > > This patch validate > > validates > > > the used buffer length provided by the device > > before trying to use it. > > before returning it to caller > > > This is done by r

Re: [PATCH] virtio_ring: validate used buffer length

2023-05-28 Thread Michael S. Tsirkin
On Fri, May 26, 2023 at 02:30:41PM +0800, Jason Wang wrote: > This patch validate validates > the used buffer length provided by the device > before trying to use it. before returning it to caller > This is done by remembering the in buffer > length in a dedicated array during virtqueue_add(),

[PATCH] virtio_ring: validate used buffer length

2023-05-25 Thread Jason Wang
This patch validate the used buffer length provided by the device before trying to use it. This is done by remembering the in buffer length in a dedicated array during virtqueue_add(), then we can fail the virtqueue_get_buf() when we find the device is trying to give us a used buffer length which i