Re: [PATCH] xen/events: xen/events: fix RCU warning

2012-11-07 Thread 邱模炯
Thanks Konrad. You are right, commit 98ad1cc14 missed the xen case. And before merging, please modify the title a bit. one redundant xen/events there. xen/events: xen/events: fix RCU warning - xen/events: fix RCU warning Cc: sta...@kernel.org (at least to 3.0.y) ^^^-

[PATCH] xen/events: xen/events: fix RCU warning

2012-11-06 Thread Mojiong Qiu
exit_idle() should be called after irq_enter(), otherwise it throws: [2.513020] [ INFO: suspicious RCU usage. ] [2.513076] 3.6.5 #1 Not tainted [2.513128] --- [2.513183] include/linux/rcupdate.h:725 rcu_read_lock() used illegally while idle! [

Re: [PATCH] xen/events: xen/events: fix RCU warning

2012-11-06 Thread Konrad Rzeszutek Wilk
On Tue, Nov 06, 2012 at 04:08:15PM +0800, Mojiong Qiu wrote: exit_idle() should be called after irq_enter(), otherwise it throws: That seems odd - wouldn't smp_x86_platform_ipi also need the same treatment [edit: I was looking at 3.0 kernel code] ? Ah, this is caused by commit