Re: [Pv-drivers] [PATCH 04/10] VMCI: device driver implementaton.

2012-10-26 Thread Greg KH
On Fri, Oct 26, 2012 at 01:02:53PM -0700, Andy King wrote: Hi Greg, in the next few days with that change along with any modifications necessary after a sparse sanity check. We have a change that fixes things, but I wanted to check if you had any additional comments before we send out

Re: [PATCH 04/10] VMCI: device driver implementaton.

2012-10-25 Thread Greg KH
On Mon, Oct 15, 2012 at 05:28:47PM -0700, George Zhang wrote: +/* + * vmci_device_get() - Checks for VMCI device. + * @api_version:The API version to use + * @device_shutdown_cb: Callback used when shutdown happens (Unused) + * @user_data: Data to be passed to the callback (Unused)

Re: [Pv-drivers] [PATCH 04/10] VMCI: device driver implementaton.

2012-10-25 Thread Andy King
Hi Greg, +EXPORT_SYMBOL(vmci_device_get); EXPORT_SYMBOL_GPL() for this, and all other exports? We'd prefer to leave them as vanilla exports. While we're committed to open-sourcing everything, including our non-upstreamed drivers, we don't really have a strong opinion regarding consuming

Re: [Pv-drivers] [PATCH 04/10] VMCI: device driver implementaton.

2012-10-25 Thread Greg KH
On Thu, Oct 25, 2012 at 01:16:00PM -0700, Andy King wrote: Hi Greg, +EXPORT_SYMBOL(vmci_device_get); EXPORT_SYMBOL_GPL() for this, and all other exports? We'd prefer to leave them as vanilla exports. While we're committed to open-sourcing everything, including our non-upstreamed

Re: [Pv-drivers] [PATCH 04/10] VMCI: device driver implementaton.

2012-10-25 Thread Bhavesh Davda
Hi Greg, You can't just say general GPL issues aside. Honestly, given your company's prior actions in regards to Linux kernel drivers and the licenses of them, I don't trust them at all. To help gain that trust back, marking the exports in this manner will be a great improvement. You

Re: [Pv-drivers] [PATCH 04/10] VMCI: device driver implementaton.

2012-10-25 Thread Dmitry Torokhov
On Thursday, October 25, 2012 01:31:48 PM Greg KH wrote: On Thu, Oct 25, 2012 at 01:16:00PM -0700, Andy King wrote: Hi Greg, +EXPORT_SYMBOL(vmci_device_get); EXPORT_SYMBOL_GPL() for this, and all other exports? We'd prefer to leave them as vanilla exports. While we're

Re: [Pv-drivers] [PATCH 04/10] VMCI: device driver implementaton.

2012-10-25 Thread Greg KH
On Thu, Oct 25, 2012 at 01:43:50PM -0700, Bhavesh Davda wrote: Hi Greg, You can't just say general GPL issues aside. Honestly, given your company's prior actions in regards to Linux kernel drivers and the licenses of them, I don't trust them at all. To help gain that trust back,

Re: [Pv-drivers] [PATCH 04/10] VMCI: device driver implementaton.

2012-10-25 Thread Greg KH
On Thu, Oct 25, 2012 at 01:45:39PM -0700, Dmitry Torokhov wrote: On Thursday, October 25, 2012 01:31:48 PM Greg KH wrote: On Thu, Oct 25, 2012 at 01:16:00PM -0700, Andy King wrote: Hi Greg, +EXPORT_SYMBOL(vmci_device_get); EXPORT_SYMBOL_GPL() for this, and all other

Re: [Pv-drivers] [PATCH 04/10] VMCI: device driver implementaton.

2012-10-25 Thread Andy King
Hi Greg, You can't just say general GPL issues aside. Honestly, given your company's prior actions in regards to Linux kernel drivers and the licenses of them, I don't trust them at all. To help gain that trust back, marking the exports in this manner will be a great improvement. To

Re: [Pv-drivers] [PATCH 04/10] VMCI: device driver implementaton.

2012-10-25 Thread Dmitry Torokhov
On Thursday, October 25, 2012 02:04:48 PM Greg KH wrote: On Thu, Oct 25, 2012 at 01:45:39PM -0700, Dmitry Torokhov wrote: On Thursday, October 25, 2012 01:31:48 PM Greg KH wrote: On Thu, Oct 25, 2012 at 01:16:00PM -0700, Andy King wrote: Hi Greg,

Re: [Pv-drivers] [PATCH 04/10] VMCI: device driver implementaton.

2012-10-25 Thread Dmitry Torokhov
On Thursday, October 25, 2012 02:03:20 PM Greg KH wrote: On Thu, Oct 25, 2012 at 01:43:50PM -0700, Bhavesh Davda wrote: Hi Greg, You can't just say general GPL issues aside. Honestly, given your company's prior actions in regards to Linux kernel drivers and the licenses of them, I

Re: [Pv-drivers] [PATCH 04/10] VMCI: device driver implementaton.

2012-10-25 Thread Bhavesh Davda
For many many years, you shipped closed source Linux kernel drivers for your products. Only recently has this changed. and all our Linux drivers, even if not all are upstream [yet], are GPL. That's nice to hear, although without proof of that, we have to take your word :) The