On (Mon) 22 Jul 2013 [15:07:52], Rusty Russell wrote:
> Amit Shah writes:
> > Mateusz Guzik points out that we update the 'file' struct's private_data
> > field before we've successfully done all our checks. This means we can
> > return an error with the private_data field updated. This could le
Amit Shah writes:
> Mateusz Guzik points out that we update the 'file' struct's private_data
> field before we've successfully done all our checks. This means we can
> return an error with the private_data field updated. This could lead to
> problems.
>
> Fix by moving the assignment after all c
Mateusz Guzik points out that we update the 'file' struct's private_data
field before we've successfully done all our checks. This means we can
return an error with the private_data field updated. This could lead to
problems.
Fix by moving the assignment after all checks are done.
CC:
Reported
