Re: [PATCH 1/2] virito: introduce methods of fixing device features

2014-11-25 Thread Jason Wang
- Original Message - > Jason Wang writes: > > Buggy host may advertised buggy host features (a usual case is that host > > advertise a feature whose dependencies were missed). In this case, driver > > should detect and disable the buggy features by itself. > > Sorry, I've been focussing

Re: [PATCH 1/2] virito: introduce methods of fixing device features

2014-11-25 Thread Rusty Russell
Jason Wang writes: > Buggy host may advertised buggy host features (a usual case is that host > advertise a feature whose dependencies were missed). In this case, driver > should detect and disable the buggy features by itself. Sorry, I've been focussing elsewhere. I would really prefer that dri

Re: [PATCH 1/2] virito: introduce methods of fixing device features

2014-11-13 Thread Jason Wang
On 11/13/2014 05:14 PM, Cornelia Huck wrote: > On Thu, 13 Nov 2014 17:11:30 +0800 > Jason Wang wrote: > >> On 11/13/2014 04:46 PM, Cornelia Huck wrote: >>> On Thu, 13 Nov 2014 13:52:53 +0800 >>> Jason Wang wrote: +static inline void virtio_disable_feature(struct virtio_device *vdev, +

Re: [PATCH 1/2] virito: introduce methods of fixing device features

2014-11-13 Thread Cornelia Huck
On Thu, 13 Nov 2014 17:11:30 +0800 Jason Wang wrote: > On 11/13/2014 04:46 PM, Cornelia Huck wrote: > > On Thu, 13 Nov 2014 13:52:53 +0800 > > Jason Wang wrote: > >> +static inline void virtio_disable_feature(struct virtio_device *vdev, > >> + unsigned i

Re: [PATCH 1/2] virito: introduce methods of fixing device features

2014-11-13 Thread Jason Wang
On 11/13/2014 04:46 PM, Cornelia Huck wrote: > On Thu, 13 Nov 2014 13:52:53 +0800 > Jason Wang wrote: > > typo in subject-prefix: s/virito/virtio/ > Will correct this. >> Buggy host may advertised buggy host features (a usual case is that host >> advertise a feature whose dependencies were missed

Re: [PATCH 1/2] virito: introduce methods of fixing device features

2014-11-13 Thread Cornelia Huck
On Thu, 13 Nov 2014 13:52:53 +0800 Jason Wang wrote: typo in subject-prefix: s/virito/virtio/ > Buggy host may advertised buggy host features (a usual case is that host > advertise a feature whose dependencies were missed). In this case, driver > should detect and disable the buggy features by i

[PATCH 1/2] virito: introduce methods of fixing device features

2014-11-12 Thread Jason Wang
Buggy host may advertised buggy host features (a usual case is that host advertise a feature whose dependencies were missed). In this case, driver should detect and disable the buggy features by itself. This patch introduces driver specific fix_features() method which is called just before feature

[PATCH 1/2] virito: introduce methods of fixing device features

2014-11-12 Thread Jason Wang
Buggy host may advertised buggy host features (a usual case is that host advertise a feature whose dependencies were missed). In this case, driver should detect and disable the buggy features by itself. This patch introduces driver specific fix_features() method which is called just before feature