Re: [PATCH 1/3] virtio: change to_vp_device to an inlined definition

2012-12-05 Thread Michael S. Tsirkin
On Wed, Dec 05, 2012 at 03:03:27PM +0800, Wanlong Gao wrote: to_vp_device is worth changing to inlined definition. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com I don't think it's worth it. The oldest gcc I happened to have around is 4.3.3 which is already smart enough to generate

Re: [PATCH 1/3] virtio: change to_vp_device to an inlined definition

2012-12-05 Thread Stephen Hemminger
On Wed, 5 Dec 2012 15:03:27 +0800 Wanlong Gao gaowanl...@cn.fujitsu.com wrote: to_vp_device is worth changing to inlined definition. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- drivers/virtio/virtio_pci.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff

Re: [PATCH 1/3] virtio: change to_vp_device to an inlined definition

2012-12-05 Thread Rusty Russell
Wanlong Gao gaowanl...@cn.fujitsu.com writes: to_vp_device is worth changing to inlined definition. Why? Thanks, Rusty. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org

Re: [PATCH 1/3] virtio: change to_vp_device to an inlined definition

2012-12-05 Thread Rusty Russell
Stephen Hemminger shemmin...@vyatta.com writes: On Wed, 5 Dec 2012 15:03:27 +0800 Wanlong Gao gaowanl...@cn.fujitsu.com wrote: to_vp_device is worth changing to inlined definition. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- drivers/virtio/virtio_pci.c | 6 +- 1 file

Re: [PATCH 1/3] virtio: change to_vp_device to an inlined definition

2012-12-05 Thread Wanlong Gao
On 12/06/2012 07:21 AM, Rusty Russell wrote: Wanlong Gao gaowanl...@cn.fujitsu.com writes: to_vp_device is worth changing to inlined definition. Why? OK, I saw your comments, and I dropped this patch already. Thanks, Wanlong Gao Thanks, Rusty.

[PATCH 1/3] virtio: change to_vp_device to an inlined definition

2012-12-04 Thread Wanlong Gao
to_vp_device is worth changing to inlined definition. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- drivers/virtio/virtio_pci.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c index e3ecc94..7681fe3