Re: [PATCH 1/4] virtio: wean net driver off NETDEV_TX_BUSY

2008-04-28 Thread Herbert Xu
On Tue, Apr 29, 2008 at 01:16:05AM +1000, Rusty Russell wrote: > > + /* If we has a buffer left over from last time, send it now. */ > + if (vi->last_xmit_skb) { > + if (xmit_skb(vi, vi->last_xmit_skb) != 0) { > + /* Drop this skb: we only queue one. */ > +

[PATCH 1/4] virtio: wean net driver off NETDEV_TX_BUSY

2008-04-28 Thread Rusty Russell
Herbert tells me that returning NETDEV_TX_BUSY from hard_start_xmit is seen as a poor thing to do; we should cache the packet and stop the queue. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> --- drivers/net/virtio_net.c | 58 --- 1 file changed, 4