Re: [PATCH 1/4] virtio_blk: deprecate the 1024-byte ID field.

2009-10-07 Thread john cooper
Rusty Russell wrote: Also, I've been convinced to just hand over the 20 byte serial number since we're revisiting this. It's simple, and there's no clear consensus. I'm fine with this approach as it is where I originally started with this Sisyphus Patch. My bias toward pressing the ATA

Re: [PATCH 1/4] virtio_blk: deprecate the 1024-byte ID field.

2009-10-06 Thread Rusty Russell
On Tue, 6 Oct 2009 02:50:12 am john cooper wrote: It seems simply retiring use of the VIRTIO_BLK_F_IDENTIFY binary value should be sufficient. The patch which implemented the cooperating logic in qemu was dropped due to the config space issue. OK, I'll just remove it then. Also, I've been

Re: [PATCH 1/4] virtio_blk: deprecate the 1024-byte ID field.

2009-10-05 Thread john cooper
Christian Borntraeger wrote: Am Dienstag 29 September 2009 19:18:09 schrieb Rusty Russell: PCI, lguest and s390 can all only support 256-byte configuration space. So, this giant field broke just about everyone. Unfortunately, removing it is not so simple: we don't want to break old

Re: [PATCH 1/4] virtio_blk: deprecate the 1024-byte ID field.

2009-09-30 Thread Christian Borntraeger
Am Dienstag 29 September 2009 19:18:09 schrieb Rusty Russell: PCI, lguest and s390 can all only support 256-byte configuration space. So, this giant field broke just about everyone. Unfortunately, removing it is not so simple: we don't want to break old userspace, but we're going to want to

[PATCH 1/4] virtio_blk: deprecate the 1024-byte ID field.

2009-09-29 Thread Rusty Russell
PCI, lguest and s390 can all only support 256-byte configuration space. So, this giant field broke just about everyone. Unfortunately, removing it is not so simple: we don't want to break old userspace, but we're going to want to re-use that part of the struct. So, modern users can #define