Re: [PATCH 1/5] virtio: move queue_index and num_free fields into core struct virtqueue.

2012-10-16 Thread Michael S. Tsirkin
On Wed, Oct 17, 2012 at 12:00:48AM +1030, Rusty Russell wrote: > They're generic concepts, so hoist them. This also avoids accessor > functions. > > This goes even further than Jason Wang's 17bb6d4088 patch > ("virtio-ring: move queue_index to vring_virtqueue") which moved the > queue_index from

Re: [PATCH 1/5] virtio: move queue_index and num_free fields into core struct virtqueue.

2012-10-16 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Wed, Oct 17, 2012 at 12:00:48AM +1030, Rusty Russell wrote: >> * @priv: a pointer for the virtqueue implementation to use. >> + * @index: the zero-based ordinal number for this queue. >> + * @num_free: number of buffers we expect to be able to fit. > > Only it's

Re: [PATCH 1/5] virtio: move queue_index and num_free fields into core struct virtqueue.

2012-10-16 Thread Michael S. Tsirkin
On Wed, Oct 17, 2012 at 12:00:48AM +1030, Rusty Russell wrote: > They're generic concepts, so hoist them. This also avoids accessor > functions. > > This goes even further than Jason Wang's 17bb6d4088 patch > ("virtio-ring: move queue_index to vring_virtqueue") which moved the > queue_index from

[PATCH 1/5] virtio: move queue_index and num_free fields into core struct virtqueue.

2012-10-16 Thread Rusty Russell
They're generic concepts, so hoist them. This also avoids accessor functions. This goes even further than Jason Wang's 17bb6d4088 patch ("virtio-ring: move queue_index to vring_virtqueue") which moved the queue_index from the specific transport. Signed-off-by: Rusty Russell --- drivers/virtio/