Re: [PATCH 1/6] virtio: Initialize vq->data entries to NULL

2010-02-12 Thread Rusty Russell
On Fri, 12 Feb 2010 03:32:14 pm Amit Shah wrote: > vq operations depend on vq->data[i] being NULL to figure out if the vq > entry is in use. > > We have to initialize them to NULL to ensure we don't work with junk > data and trigger false BUG_ONs. Not really. We wouldn't detect some bogus get_bu

[PATCH 1/6] virtio: Initialize vq->data entries to NULL

2010-02-11 Thread Amit Shah
vq operations depend on vq->data[i] being NULL to figure out if the vq entry is in use. We have to initialize them to NULL to ensure we don't work with junk data and trigger false BUG_ONs. Signed-off-by: Amit Shah --- drivers/virtio/virtio_ring.c |5 - 1 files changed, 4 insertions(+),