Re: [PATCH 1/9] virtio_blk: eliminate anonymous module_init & module_exit

2022-03-20 Thread Michael S. Tsirkin
On Wed, Mar 16, 2022 at 12:20:02PM -0700, Randy Dunlap wrote: > Eliminate anonymous module_init() and module_exit(), which can lead to > confusion or ambiguity when reading System.map, crashes/oops/bugs, > or an initcall_debug log. > > Give each of these init and exit functions unique

Re: [PATCH 1/9] virtio_blk: eliminate anonymous module_init & module_exit

2022-03-17 Thread Stefan Hajnoczi
On Wed, Mar 16, 2022 at 12:20:02PM -0700, Randy Dunlap wrote: > Eliminate anonymous module_init() and module_exit(), which can lead to > confusion or ambiguity when reading System.map, crashes/oops/bugs, > or an initcall_debug log. > > Give each of these init and exit functions unique

Re: [PATCH 1/9] virtio_blk: eliminate anonymous module_init & module_exit

2022-03-16 Thread Jason Wang
On Thu, Mar 17, 2022 at 3:25 AM Randy Dunlap wrote: > > Eliminate anonymous module_init() and module_exit(), which can lead to > confusion or ambiguity when reading System.map, crashes/oops/bugs, > or an initcall_debug log. > > Give each of these init and exit functions unique driver-specific >

[PATCH 1/9] virtio_blk: eliminate anonymous module_init & module_exit

2022-03-16 Thread Randy Dunlap
Eliminate anonymous module_init() and module_exit(), which can lead to confusion or ambiguity when reading System.map, crashes/oops/bugs, or an initcall_debug log. Give each of these init and exit functions unique driver-specific names to eliminate the anonymous names. Example 1: (System.map)