Re: [PATCH 18/31] virtio: console: Buffer data that comes from the host

2010-01-16 Thread Rusty Russell
On Thu, 14 Jan 2010 01:47:53 pm Amit Shah wrote: On (Thu) Jan 14 2010 [09:45:12], Rusty Russell wrote: On Wed, 13 Jan 2010 09:54:52 pm Amit Shah wrote: On (Wed) Jan 13 2010 [21:43:32], Rusty Russell wrote: On Wed, 13 Jan 2010 04:41:48 pm Amit Shah wrote: On (Mon) Jan 04 2010

Re: [PATCH 18/31] virtio: console: Buffer data that comes from the host

2010-01-13 Thread Rusty Russell
On Wed, 13 Jan 2010 04:41:48 pm Amit Shah wrote: On (Mon) Jan 04 2010 [15:17:17], Amit Shah wrote: On (Mon) Jan 04 2010 [19:45:30], Rusty Russell wrote: On Wed, 23 Dec 2009 01:04:28 am Amit Shah wrote: The console could be flooded with data from the host; handle this situation by

Re: [PATCH 18/31] virtio: console: Buffer data that comes from the host

2010-01-13 Thread Rusty Russell
On Wed, 13 Jan 2010 09:54:52 pm Amit Shah wrote: On (Wed) Jan 13 2010 [21:43:32], Rusty Russell wrote: On Wed, 13 Jan 2010 04:41:48 pm Amit Shah wrote: On (Mon) Jan 04 2010 [15:17:17], Amit Shah wrote: On (Mon) Jan 04 2010 [19:45:30], Rusty Russell wrote: On Wed, 23 Dec 2009

Re: [PATCH 18/31] virtio: console: Buffer data that comes from the host

2010-01-13 Thread Amit Shah
On (Thu) Jan 14 2010 [09:45:12], Rusty Russell wrote: On Wed, 13 Jan 2010 09:54:52 pm Amit Shah wrote: On (Wed) Jan 13 2010 [21:43:32], Rusty Russell wrote: On Wed, 13 Jan 2010 04:41:48 pm Amit Shah wrote: On (Mon) Jan 04 2010 [15:17:17], Amit Shah wrote: On (Mon) Jan 04 2010

Re: [PATCH 18/31] virtio: console: Buffer data that comes from the host

2010-01-12 Thread Amit Shah
On (Mon) Jan 04 2010 [15:17:17], Amit Shah wrote: On (Mon) Jan 04 2010 [19:45:30], Rusty Russell wrote: On Wed, 23 Dec 2009 01:04:28 am Amit Shah wrote: The console could be flooded with data from the host; handle this situation by buffering the data. Is this still true? If we only

Re: [PATCH 18/31] virtio: console: Buffer data that comes from the host

2010-01-04 Thread Rusty Russell
On Wed, 23 Dec 2009 01:04:28 am Amit Shah wrote: The console could be flooded with data from the host; handle this situation by buffering the data. Is this still true? If we only add_buf when we're ready, surely the host can't flood us with one virtqueue per port? Thanks, Rusty.

Re: [PATCH 18/31] virtio: console: Buffer data that comes from the host

2010-01-04 Thread Amit Shah
On (Mon) Jan 04 2010 [19:45:30], Rusty Russell wrote: On Wed, 23 Dec 2009 01:04:28 am Amit Shah wrote: The console could be flooded with data from the host; handle this situation by buffering the data. Is this still true? If we only add_buf when we're ready, surely the host can't flood

[PATCH 18/31] virtio: console: Buffer data that comes from the host

2009-12-22 Thread Amit Shah
The console could be flooded with data from the host; handle this situation by buffering the data. We use the virtio queue ring to maintain our buffer. This buffer length is set by the host while initializing the queue. Signed-off-by: Amit Shah amit.s...@redhat.com ---