Re: [PATCH 2/3] S390: Add virtio hotplug add support

2010-09-13 Thread Martin Schwidefsky
On Mon, 13 Sep 2010 13:05:57 +0930 Rusty Russell ru...@rustcorp.com.au wrote: On Sun, 12 Sep 2010 06:30:43 pm Avi Kivity wrote: On 09/12/2010 02:42 AM, Alexander Graf wrote: On 24.08.2010, at 15:48, Alexander Graf wrote: The one big missing feature in s390-virtio was hotplugging.

Re: [PATCH 2/3] S390: Add virtio hotplug add support

2010-09-13 Thread Avi Kivity
On 09/13/2010 09:41 AM, Martin Schwidefsky wrote: Actually Marcelo applied it. But the natural place for it is Rusty's virtio tree. Rusty, if you want to take it, let me know and I'll drop it from kvm.git. I thought it would be in the s390 tree, which is why I didn't take it... But I'm

Re: [PATCH 2/3] S390: Add virtio hotplug add support

2010-09-12 Thread Avi Kivity
On 09/12/2010 02:42 AM, Alexander Graf wrote: On 24.08.2010, at 15:48, Alexander Graf wrote: The one big missing feature in s390-virtio was hotplugging. This is no more. This patch implements hotplug add support, so you can on the fly add new devices in the guest. Keep in mind that this

Re: [PATCH 2/3] S390: Add virtio hotplug add support

2010-09-12 Thread Rusty Russell
On Sun, 12 Sep 2010 06:30:43 pm Avi Kivity wrote: On 09/12/2010 02:42 AM, Alexander Graf wrote: On 24.08.2010, at 15:48, Alexander Graf wrote: The one big missing feature in s390-virtio was hotplugging. This is no more. This patch implements hotplug add support, so you can on the fly

Re: [PATCH 2/3] S390: Add virtio hotplug add support

2010-09-11 Thread Alexander Graf
On 24.08.2010, at 15:48, Alexander Graf wrote: The one big missing feature in s390-virtio was hotplugging. This is no more. This patch implements hotplug add support, so you can on the fly add new devices in the guest. Keep in mind that this needs a patch for qemu to actually leverage

Re: [PATCH 2/3] S390: Add virtio hotplug add support

2010-08-25 Thread Heiko Carstens
On Tue, Aug 24, 2010 at 03:48:51PM +0200, Alexander Graf wrote: +static void hotplug_devices(struct work_struct *dummy) +{ + unsigned int i; + struct kvm_device_desc *d; + struct device *dev; + + for (i = 0; i PAGE_SIZE; i += desc_size(d)) { This should be for (i

Re: [PATCH 2/3] S390: Add virtio hotplug add support

2010-08-25 Thread Alexander Graf
On 25.08.2010, at 10:16, Heiko Carstens wrote: On Tue, Aug 24, 2010 at 03:48:51PM +0200, Alexander Graf wrote: +static void hotplug_devices(struct work_struct *dummy) +{ +unsigned int i; +struct kvm_device_desc *d; +struct device *dev; + +for (i = 0; i PAGE_SIZE; i +=

Re: [PATCH 2/3] S390: Add virtio hotplug add support

2010-08-25 Thread Heiko Carstens
On Wed, Aug 25, 2010 at 10:20:03AM +0200, Alexander Graf wrote: On 25.08.2010, at 10:16, Heiko Carstens wrote: On Tue, Aug 24, 2010 at 03:48:51PM +0200, Alexander Graf wrote: +static void hotplug_devices(struct work_struct *dummy) +{ + unsigned int i; + struct kvm_device_desc *d; +

Re: [PATCH 2/3] S390: Add virtio hotplug add support

2010-08-25 Thread Alexander Graf
On 25.08.2010, at 10:35, Heiko Carstens wrote: On Wed, Aug 25, 2010 at 10:20:03AM +0200, Alexander Graf wrote: On 25.08.2010, at 10:16, Heiko Carstens wrote: On Tue, Aug 24, 2010 at 03:48:51PM +0200, Alexander Graf wrote: +static void hotplug_devices(struct work_struct *dummy) +{ +

Re: [PATCH 2/3] S390: Add virtio hotplug add support

2010-08-25 Thread Alexander Graf
On 25.08.2010, at 10:48, Heiko Carstens wrote: On Wed, Aug 25, 2010 at 10:34:29AM +0200, Alexander Graf wrote: On 25.08.2010, at 10:35, Heiko Carstens wrote: On Wed, Aug 25, 2010 at 10:20:03AM +0200, Alexander Graf wrote: On 25.08.2010, at 10:16, Heiko Carstens wrote: On Tue, Aug 24, 2010