Re: [PATCH 4/4] tun: indicate support for USO feature

2021-05-14 Thread Willem de Bruijn
On Fri, May 14, 2021 at 3:39 AM Yuri Benditovich wrote: > > On Fri, May 14, 2021 at 10:16 AM Jason Wang wrote: > > > > On Fri, May 14, 2021 at 4:35 AM Willem de Bruijn > > wrote: > > > > > > > > But surprisingly when TUN receives TUN_F_UFO it does not propagate it > > > > > anywhere, there is

Re: [PATCH 4/4] tun: indicate support for USO feature

2021-05-14 Thread Yuri Benditovich
On Fri, May 14, 2021 at 10:16 AM Jason Wang wrote: > > On Fri, May 14, 2021 at 4:35 AM Willem de Bruijn > wrote: > > > > > > But surprisingly when TUN receives TUN_F_UFO it does not propagate it > > > > anywhere, there is no corresponding NETIF flag. > > > > > > (It looks like I drop the

Re: [PATCH 4/4] tun: indicate support for USO feature

2021-05-14 Thread Jason Wang
On Fri, May 14, 2021 at 4:35 AM Willem de Bruijn wrote: > > > > But surprisingly when TUN receives TUN_F_UFO it does not propagate it > > > anywhere, there is no corresponding NETIF flag. > > > > (It looks like I drop the community and other ccs accidentally, adding > > them back and sorry) > > >

Re: [PATCH 4/4] tun: indicate support for USO feature

2021-05-13 Thread Yuri Benditovich
On Thu, May 13, 2021 at 11:43 PM Willem de Bruijn wrote: > > > > > > > So the question is what to do now: > > > > > > A) > > > > > > Finalize patches for guest TX and respective QEMU patches > > > > > > Prepare RFC patches for guest RX, get ack on them > > > > > > Change the spec > > > > > >

Re: [PATCH 4/4] tun: indicate support for USO feature

2021-05-13 Thread Willem de Bruijn
> > > > > So the question is what to do now: > > > > > A) > > > > > Finalize patches for guest TX and respective QEMU patches > > > > > Prepare RFC patches for guest RX, get ack on them > > > > > Change the spec > > > > > Finalize patches for guest RX according to the spec > > > > > > > > > > B) >

Re: [PATCH 4/4] tun: indicate support for USO feature

2021-05-13 Thread Willem de Bruijn
> > But surprisingly when TUN receives TUN_F_UFO it does not propagate it > > anywhere, there is no corresponding NETIF flag. > > (It looks like I drop the community and other ccs accidentally, adding > them back and sorry) > > Actually, there is one, NETIF_F_GSO_UDP. > > Kernel used to have

Re: [PATCH 4/4] tun: indicate support for USO feature

2021-05-13 Thread Yuri Benditovich
On Thu, May 13, 2021 at 10:05 AM Jason Wang wrote: > > On Thu, May 13, 2021 at 12:36 PM Yuri Benditovich > wrote: > > > > On Thu, May 13, 2021 at 5:07 AM Jason Wang wrote: > > > > > > On Wed, May 12, 2021 at 6:37 PM Yuri Benditovich > > > wrote: > > > > > > > > On Wed, May 12, 2021 at 12:10 PM

Re: [PATCH 4/4] tun: indicate support for USO feature

2021-05-13 Thread Jason Wang
On Thu, May 13, 2021 at 12:36 PM Yuri Benditovich wrote: > > On Thu, May 13, 2021 at 5:07 AM Jason Wang wrote: > > > > On Wed, May 12, 2021 at 6:37 PM Yuri Benditovich > > wrote: > > > > > > On Wed, May 12, 2021 at 12:10 PM Jason Wang wrote: > > > > > > > > On Wed, May 12, 2021 at 4:32 PM Yuri

Re: [PATCH 4/4] tun: indicate support for USO feature

2021-05-11 Thread Yuri Benditovich
On Wed, May 12, 2021 at 4:33 AM Jason Wang wrote: > > > 在 2021/5/11 下午4:33, Yuri Benditovich 写道: > > On Tue, May 11, 2021 at 9:50 AM Jason Wang wrote: > >> > >> 在 2021/5/11 下午12:42, Yuri Benditovich 写道: > >>> Signed-off-by: Yuri Benditovich > >>> --- > >>>drivers/net/tun.c | 2 +- > >>>1

Re: [PATCH 4/4] tun: indicate support for USO feature

2021-05-11 Thread Jason Wang
在 2021/5/11 下午4:33, Yuri Benditovich 写道: On Tue, May 11, 2021 at 9:50 AM Jason Wang wrote: 在 2021/5/11 下午12:42, Yuri Benditovich 写道: Signed-off-by: Yuri Benditovich --- drivers/net/tun.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/tun.c

Re: [PATCH 4/4] tun: indicate support for USO feature

2021-05-11 Thread Yuri Benditovich
On Tue, May 11, 2021 at 11:33 AM Yuri Benditovich wrote: > > On Tue, May 11, 2021 at 9:50 AM Jason Wang wrote: > > > > > > 在 2021/5/11 下午12:42, Yuri Benditovich 写道: > > > Signed-off-by: Yuri Benditovich > > > --- > > > drivers/net/tun.c | 2 +- > > > 1 file changed, 1 insertion(+), 1

Re: [PATCH 4/4] tun: indicate support for USO feature

2021-05-11 Thread Yuri Benditovich
On Tue, May 11, 2021 at 9:50 AM Jason Wang wrote: > > > 在 2021/5/11 下午12:42, Yuri Benditovich 写道: > > Signed-off-by: Yuri Benditovich > > --- > > drivers/net/tun.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/tun.c b/drivers/net/tun.c > > index

Re: [PATCH 4/4] tun: indicate support for USO feature

2021-05-11 Thread Jason Wang
在 2021/5/11 下午12:42, Yuri Benditovich 写道: Signed-off-by: Yuri Benditovich --- drivers/net/tun.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index 84f832806313..a35054f9d941 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c

[PATCH 4/4] tun: indicate support for USO feature

2021-05-10 Thread Yuri Benditovich
Signed-off-by: Yuri Benditovich --- drivers/net/tun.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index 84f832806313..a35054f9d941 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c @@ -2812,7 +2812,7 @@ static int