RE: [PATCH 41/46] Staging: hv: vmbus: Fix a bug in error handling in vmbus_bus_init()

2011-08-31 Thread KY Srinivasan
sdl.org > Subject: Re: [PATCH 41/46] Staging: hv: vmbus: Fix a bug in error handling in > vmbus_bus_init() > > On Tue, Aug 30, 2011 at 01:29:49PM +0300, Dan Carpenter wrote: > > > err3: > > > free_irq(irq, hv_acpi_dev); > > > err2: > > > bus_unregiste

RE: [PATCH 41/46] Staging: hv: vmbus: Fix a bug in error handling in vmbus_bus_init()

2011-08-31 Thread KY Srinivasan
[PATCH 41/46] Staging: hv: vmbus: Fix a bug in error handling in > vmbus_bus_init() > > On Sat, Aug 27, 2011 at 11:31:40AM -0700, K. Y. Srinivasan wrote: > > Fix a bug in error handling in vmbus_bus_init(). > > > > Signed-off-by: K. Y. Srinivasan > > Signed-

Re: [PATCH 41/46] Staging: hv: vmbus: Fix a bug in error handling in vmbus_bus_init()

2011-08-30 Thread Greg KH
On Tue, Aug 30, 2011 at 01:29:49PM +0300, Dan Carpenter wrote: > > err3: > > free_irq(irq, hv_acpi_dev); > > err2: > > bus_unregister(&hv_bus); > > err1: > > hv_cleanup(); > > Also here is an oldbie trick. You could use multiples of ten like > err30, err20, and err10. That way if you

Re: [PATCH 41/46] Staging: hv: vmbus: Fix a bug in error handling in vmbus_bus_init()

2011-08-30 Thread Dan Carpenter
> err3: > free_irq(irq, hv_acpi_dev); > err2: > bus_unregister(&hv_bus); > err1: > hv_cleanup(); Also here is an oldbie trick. You could use multiples of ten like err30, err20, and err10. That way if you can add more error handling in the middle without changing the numbering.

Re: [PATCH 41/46] Staging: hv: vmbus: Fix a bug in error handling in vmbus_bus_init()

2011-08-29 Thread Greg KH
On Sat, Aug 27, 2011 at 11:31:40AM -0700, K. Y. Srinivasan wrote: > Fix a bug in error handling in vmbus_bus_init(). > > Signed-off-by: K. Y. Srinivasan > Signed-off-by: Haiyang Zhang > --- > drivers/staging/hv/vmbus_drv.c | 21 ++--- > 1 files changed, 10 insertions(+), 11 de

[PATCH 41/46] Staging: hv: vmbus: Fix a bug in error handling in vmbus_bus_init()

2011-08-27 Thread K. Y. Srinivasan
Fix a bug in error handling in vmbus_bus_init(). Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang --- drivers/staging/hv/vmbus_drv.c | 21 ++--- 1 files changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmb