Re: [PATCH 5/9] virtio-scsi: eliminate anonymous module_init & module_exit

2022-03-29 Thread Martin K. Petersen
Randy, > Eliminate anonymous module_init() and module_exit(), which can lead to > confusion or ambiguity when reading System.map, crashes/oops/bugs, or > an initcall_debug log. Applied to 5.18/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering __

Re: [PATCH 5/9] virtio-scsi: eliminate anonymous module_init & module_exit

2022-03-20 Thread Michael S. Tsirkin
On Wed, Mar 16, 2022 at 12:20:06PM -0700, Randy Dunlap wrote: > Eliminate anonymous module_init() and module_exit(), which can lead to > confusion or ambiguity when reading System.map, crashes/oops/bugs, > or an initcall_debug log. > > Give each of these init and exit functions unique driver-speci

Re: [PATCH 5/9] virtio-scsi: eliminate anonymous module_init & module_exit

2022-03-17 Thread Stefan Hajnoczi
On Wed, Mar 16, 2022 at 12:20:06PM -0700, Randy Dunlap wrote: > Eliminate anonymous module_init() and module_exit(), which can lead to > confusion or ambiguity when reading System.map, crashes/oops/bugs, > or an initcall_debug log. > > Give each of these init and exit functions unique driver-speci

Re: [PATCH 5/9] virtio-scsi: eliminate anonymous module_init & module_exit

2022-03-16 Thread Jason Wang
On Thu, Mar 17, 2022 at 3:24 AM Randy Dunlap wrote: > > Eliminate anonymous module_init() and module_exit(), which can lead to > confusion or ambiguity when reading System.map, crashes/oops/bugs, > or an initcall_debug log. > > Give each of these init and exit functions unique driver-specific > na

[PATCH 5/9] virtio-scsi: eliminate anonymous module_init & module_exit

2022-03-16 Thread Randy Dunlap
Eliminate anonymous module_init() and module_exit(), which can lead to confusion or ambiguity when reading System.map, crashes/oops/bugs, or an initcall_debug log. Give each of these init and exit functions unique driver-specific names to eliminate the anonymous names. Example 1: (System.map) ff