Re: [PATCH 8/8] virtio: console: struct ports for multiple ports per device.

2009-11-10 Thread Amit Shah
On (Tue) Nov 10 2009 [16:57:30], Rusty Russell wrote: Rather than assume a single port, add a 'struct ports' with an array of ports. Currently, there's always only one, but that will change. Hey Rusty, static void virtcons_apply_config(struct virtio_device *dev) { - struct port

Re: [PATCH 8/8] virtio: console: struct ports for multiple ports per device.

2009-11-10 Thread Rusty Russell
On Tue, 10 Nov 2009 08:03:28 pm Amit Shah wrote: On (Tue) Nov 10 2009 [16:57:30], Rusty Russell wrote: Rather than assume a single port, add a 'struct ports' with an array of ports. Currently, there's always only one, but that will change. Hey Rusty, Hi Amit, -static struct port

Re: [PATCH 8/8] virtio: console: struct ports for multiple ports per device.

2009-11-10 Thread Rusty Russell
On Tue, 10 Nov 2009 05:54:14 pm Amit Shah wrote: 2) Do we really need more than input buffer at a time? If not, it's easy to generalize the input callback. This will be slow, but shouldn't be a problem. In my testing of a vnc clipboard copy/paste, the vnc client only sent the

Re: [PATCH 8/8] virtio: console: struct ports for multiple ports per device.

2009-11-09 Thread Rusty Russell
On Tue, 10 Nov 2009 04:57:30 pm Rusty Russell wrote: Rather than assume a single port, add a 'struct ports' with an array of ports. Currently, there's always only one, but that will change. Now, from here we need several more patches. At least: 1) Generalize the output path so we can

Re: [PATCH 8/8] virtio: console: struct ports for multiple ports per device.

2009-11-09 Thread Amit Shah
On (Tue) Nov 10 2009 [17:27:03], Rusty Russell wrote: On Tue, 10 Nov 2009 04:57:30 pm Rusty Russell wrote: Rather than assume a single port, add a 'struct ports' with an array of ports. Currently, there's always only one, but that will change. Now, from here we need several more