Re: [PATCH V5 0/9] Fixes for vhost metadata acceleration

2019-09-01 Thread Michael S. Tsirkin
On Tue, Aug 20, 2019 at 10:29:32AM +0800, Jason Wang wrote: > > On 2019/8/20 上午5:08, Michael S. Tsirkin wrote: > > On Tue, Aug 13, 2019 at 04:12:49PM +0800, Jason Wang wrote: > > > On 2019/8/12 下午5:49, Michael S. Tsirkin wrote: > > > > On Mon, Aug 12, 2019 at 10:44:51AM +0800, Jason Wang wrote: >

Re: [PATCH V5 0/9] Fixes for vhost metadata acceleration

2019-08-19 Thread Jason Wang
On 2019/8/20 上午5:08, Michael S. Tsirkin wrote: On Tue, Aug 13, 2019 at 04:12:49PM +0800, Jason Wang wrote: On 2019/8/12 下午5:49, Michael S. Tsirkin wrote: On Mon, Aug 12, 2019 at 10:44:51AM +0800, Jason Wang wrote: On 2019/8/11 上午1:52, Michael S. Tsirkin wrote: On Fri, Aug 09, 2019 at 01:48:4

Re: [PATCH V5 0/9] Fixes for vhost metadata acceleration

2019-08-19 Thread Michael S. Tsirkin
On Tue, Aug 13, 2019 at 04:12:49PM +0800, Jason Wang wrote: > > On 2019/8/12 下午5:49, Michael S. Tsirkin wrote: > > On Mon, Aug 12, 2019 at 10:44:51AM +0800, Jason Wang wrote: > > > On 2019/8/11 上午1:52, Michael S. Tsirkin wrote: > > > > On Fri, Aug 09, 2019 at 01:48:42AM -0400, Jason Wang wrote: >

Re: [PATCH V5 0/9] Fixes for vhost metadata acceleration

2019-08-15 Thread Jason Gunthorpe
On Thu, Aug 15, 2019 at 11:26:46AM +0800, Jason Wang wrote: > > On 2019/8/13 下午7:57, Jason Gunthorpe wrote: > > On Tue, Aug 13, 2019 at 04:31:07PM +0800, Jason Wang wrote: > > > > > What kind of issues do you see? Spinlock is to synchronize GUP with MMU > > > notifier in this series. > > A GUP th

Re: [PATCH V5 0/9] Fixes for vhost metadata acceleration

2019-08-14 Thread Jason Wang
On 2019/8/14 上午12:41, Christoph Hellwig wrote: On Tue, Aug 13, 2019 at 08:57:07AM -0300, Jason Gunthorpe wrote: On Tue, Aug 13, 2019 at 04:31:07PM +0800, Jason Wang wrote: What kind of issues do you see? Spinlock is to synchronize GUP with MMU notifier in this series. A GUP that can't sleep

Re: [PATCH V5 0/9] Fixes for vhost metadata acceleration

2019-08-14 Thread Jason Wang
On 2019/8/13 下午7:57, Jason Gunthorpe wrote: On Tue, Aug 13, 2019 at 04:31:07PM +0800, Jason Wang wrote: What kind of issues do you see? Spinlock is to synchronize GUP with MMU notifier in this series. A GUP that can't sleep can't pagefault which makes it a really weird pattern My understan

Re: [PATCH V5 0/9] Fixes for vhost metadata acceleration

2019-08-13 Thread Christoph Hellwig
On Tue, Aug 13, 2019 at 08:57:07AM -0300, Jason Gunthorpe wrote: > On Tue, Aug 13, 2019 at 04:31:07PM +0800, Jason Wang wrote: > > > What kind of issues do you see? Spinlock is to synchronize GUP with MMU > > notifier in this series. > > A GUP that can't sleep can't pagefault which makes it a rea

Re: [PATCH V5 0/9] Fixes for vhost metadata acceleration

2019-08-13 Thread Jason Gunthorpe
On Tue, Aug 13, 2019 at 04:31:07PM +0800, Jason Wang wrote: > What kind of issues do you see? Spinlock is to synchronize GUP with MMU > notifier in this series. A GUP that can't sleep can't pagefault which makes it a really weird pattern > Btw, back to the original question. May I know why synch

Re: [PATCH V5 0/9] Fixes for vhost metadata acceleration

2019-08-13 Thread Jason Wang
On 2019/8/12 下午9:02, Jason Gunthorpe wrote: On Mon, Aug 12, 2019 at 05:49:08AM -0400, Michael S. Tsirkin wrote: On Mon, Aug 12, 2019 at 10:44:51AM +0800, Jason Wang wrote: On 2019/8/11 上午1:52, Michael S. Tsirkin wrote: On Fri, Aug 09, 2019 at 01:48:42AM -0400, Jason Wang wrote: Hi all: This

Re: [PATCH V5 0/9] Fixes for vhost metadata acceleration

2019-08-13 Thread Jason Wang
On 2019/8/12 下午5:49, Michael S. Tsirkin wrote: On Mon, Aug 12, 2019 at 10:44:51AM +0800, Jason Wang wrote: On 2019/8/11 上午1:52, Michael S. Tsirkin wrote: On Fri, Aug 09, 2019 at 01:48:42AM -0400, Jason Wang wrote: Hi all: This series try to fix several issues introduced by meta data accelrea

Re: [PATCH V5 0/9] Fixes for vhost metadata acceleration

2019-08-12 Thread Jason Gunthorpe
On Mon, Aug 12, 2019 at 05:49:08AM -0400, Michael S. Tsirkin wrote: > On Mon, Aug 12, 2019 at 10:44:51AM +0800, Jason Wang wrote: > > > > On 2019/8/11 上午1:52, Michael S. Tsirkin wrote: > > > On Fri, Aug 09, 2019 at 01:48:42AM -0400, Jason Wang wrote: > > > > Hi all: > > > > > > > > This series tr

Re: [PATCH V5 0/9] Fixes for vhost metadata acceleration

2019-08-12 Thread Michael S. Tsirkin
On Mon, Aug 12, 2019 at 10:44:51AM +0800, Jason Wang wrote: > > On 2019/8/11 上午1:52, Michael S. Tsirkin wrote: > > On Fri, Aug 09, 2019 at 01:48:42AM -0400, Jason Wang wrote: > > > Hi all: > > > > > > This series try to fix several issues introduced by meta data > > > accelreation series. Please

Re: [PATCH V5 0/9] Fixes for vhost metadata acceleration

2019-08-11 Thread David Miller
From: Jason Wang Date: Mon, 12 Aug 2019 10:44:51 +0800 > On 2019/8/11 上午1:52, Michael S. Tsirkin wrote: >> At this point how about we revert >> 7f466032dc9e5a61217f22ea34b2df932786bbfc >> for this release, and then re-apply a corrected version >> for the next one? > > If possible, consider we've

Re: [PATCH V5 0/9] Fixes for vhost metadata acceleration

2019-08-11 Thread Jason Wang
On 2019/8/11 上午1:52, Michael S. Tsirkin wrote: On Fri, Aug 09, 2019 at 01:48:42AM -0400, Jason Wang wrote: Hi all: This series try to fix several issues introduced by meta data accelreation series. Please review. Changes from V4: - switch to use spinlock synchronize MMU notifier with accessor

Re: [PATCH V5 0/9] Fixes for vhost metadata acceleration

2019-08-10 Thread Michael S. Tsirkin
On Thu, Aug 08, 2019 at 08:54:54PM +0800, Jason Wang wrote: > I don't have any objection to convert  to spinlock() but just want to > know if any case that the above smp_mb() + counter looks good to you? So how about we try this: - revert the original patch for this release - new safe patch with a

Re: [PATCH V5 0/9] Fixes for vhost metadata acceleration

2019-08-10 Thread Michael S. Tsirkin
On Fri, Aug 09, 2019 at 01:48:42AM -0400, Jason Wang wrote: > Hi all: > > This series try to fix several issues introduced by meta data > accelreation series. Please review. > > Changes from V4: > - switch to use spinlock synchronize MMU notifier with accessors > > Changes from V3: > - remove th

[PATCH V5 0/9] Fixes for vhost metadata acceleration

2019-08-08 Thread Jason Wang
Hi all: This series try to fix several issues introduced by meta data accelreation series. Please review. Changes from V4: - switch to use spinlock synchronize MMU notifier with accessors Changes from V3: - remove the unnecessary patch Changes from V2: - use seqlck helper to synchronize MMU not