Re: [PATCH net] virtio-net: correctly enable callback during start_xmit

2022-12-13 Thread Michael S. Tsirkin
On Tue, Dec 13, 2022 at 02:57:54PM +0800, Jason Wang wrote: > On Tue, Dec 13, 2022 at 2:38 PM Michael S. Tsirkin wrote: > > > > On Tue, Dec 13, 2022 at 11:43:36AM +0800, Jason Wang wrote: > > > On Tue, Dec 13, 2022 at 11:38 AM Xuan Zhuo > > > wrote: > > > > > > > > On Mon, 12 Dec 2022 04:25:22 -

Re: [PATCH net] virtio-net: correctly enable callback during start_xmit

2022-12-12 Thread Jason Wang
On Tue, Dec 13, 2022 at 2:38 PM Michael S. Tsirkin wrote: > > On Tue, Dec 13, 2022 at 11:43:36AM +0800, Jason Wang wrote: > > On Tue, Dec 13, 2022 at 11:38 AM Xuan Zhuo > > wrote: > > > > > > On Mon, 12 Dec 2022 04:25:22 -0500, "Michael S. Tsirkin" > > > wrote: > > > > On Mon, Dec 12, 2022 at

Re: [PATCH net] virtio-net: correctly enable callback during start_xmit

2022-12-12 Thread Michael S. Tsirkin
On Tue, Dec 13, 2022 at 11:43:36AM +0800, Jason Wang wrote: > On Tue, Dec 13, 2022 at 11:38 AM Xuan Zhuo wrote: > > > > On Mon, 12 Dec 2022 04:25:22 -0500, "Michael S. Tsirkin" > > wrote: > > > On Mon, Dec 12, 2022 at 05:10:29PM +0800, Jason Wang wrote: > > > > Commit a7766ef18b33("virtio_net: d

Re: [PATCH net] virtio-net: correctly enable callback during start_xmit

2022-12-12 Thread Jason Wang
On Tue, Dec 13, 2022 at 11:38 AM Xuan Zhuo wrote: > > On Mon, 12 Dec 2022 04:25:22 -0500, "Michael S. Tsirkin" > wrote: > > On Mon, Dec 12, 2022 at 05:10:29PM +0800, Jason Wang wrote: > > > Commit a7766ef18b33("virtio_net: disable cb aggressively") enables > > > virtqueue callback via the follow

Re: [PATCH net] virtio-net: correctly enable callback during start_xmit

2022-12-12 Thread Xuan Zhuo
On Mon, 12 Dec 2022 04:25:22 -0500, "Michael S. Tsirkin" wrote: > On Mon, Dec 12, 2022 at 05:10:29PM +0800, Jason Wang wrote: > > Commit a7766ef18b33("virtio_net: disable cb aggressively") enables > > virtqueue callback via the following statement: > > > > do { > >.. > >

Re: [PATCH net] virtio-net: correctly enable callback during start_xmit

2022-12-12 Thread Michael S. Tsirkin
On Mon, Dec 12, 2022 at 05:10:29PM +0800, Jason Wang wrote: > Commit a7766ef18b33("virtio_net: disable cb aggressively") enables > virtqueue callback via the following statement: > > do { >.. > } while (use_napi && kick && >unlikely(!virtqueue_enable_c

[PATCH net] virtio-net: correctly enable callback during start_xmit

2022-12-12 Thread Jason Wang
Commit a7766ef18b33("virtio_net: disable cb aggressively") enables virtqueue callback via the following statement: do { .. } while (use_napi && kick && unlikely(!virtqueue_enable_cb_delayed(sq->vq))); This will cause a missing call to virtqueue_enable