Re: [PATCH net-next] virtio: change comment in transmit

2015-03-24 Thread David Miller
From: Rusty Russell Date: Wed, 25 Mar 2015 14:29:38 +1030 > I note that there's still no comment saying "don't do this" in > netdevice.h; I gather returning NETDEV_TX_BUSY is still considered a Bad > Thing? You're not supposed to do it still, that's right. If the driver returns NETDEV_TX_BUSY i

Re: [PATCH net-next] virtio: change comment in transmit

2015-03-24 Thread Rusty Russell
Stephen Hemminger writes: > The original comment was not really informative or funny > as well as sexist. Replace it with a better explanation of > why the driver does stop and what the impacts are. > > Signed-off-by: Stephen Hemminger Fair call. Comment was certainly snarky, probably sexist.

Re: [PATCH net-next] virtio: change comment in transmit

2015-03-24 Thread David Miller
From: Stephen Hemminger Date: Tue, 24 Mar 2015 16:22:07 -0700 > The original comment was not really informative or funny > as well as sexist. Replace it with a better explanation of > why the driver does stop and what the impacts are. > > Signed-off-by: Stephen Hemminger Applied, but _only_ be

[PATCH net-next] virtio: change comment in transmit

2015-03-24 Thread Stephen Hemminger
The original comment was not really informative or funny as well as sexist. Replace it with a better explanation of why the driver does stop and what the impacts are. Signed-off-by: Stephen Hemminger --- a/drivers/net/virtio_net.c 2015-03-24 15:20:25.174671000 -0700 +++ b/drivers/net/virtio_net