Re: [PATCH net-next] virtio_net: add ethtool support for set and get of settings

2016-02-03 Thread Stephen Hemminger
On Tue, 2 Feb 2016 13:51:20 +0100 Nikolay Aleksandrov wrote: > +static bool virtnet_validate_speed(u32 speed) > +{ > + switch (speed) { > + case SPEED_10: > + case SPEED_100: > + case SPEED_1000: > + case SPEED_2500: > + case SPEED_5000: > + case

[PATCH net-next] virtio_net: add ethtool support for set and get of settings

2016-02-02 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov This patch allows the user to set and retrieve speed and duplex of the virtio_net device via ethtool. Having this functionality is very helpful for simulating different environments and also enables the virtio_net device to participate in

Re: [PATCH net-next] virtio_net: add ethtool support for set and get of settings

2016-02-02 Thread Michael S. Tsirkin
On Tue, Feb 02, 2016 at 01:51:20PM +0100, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > This patch allows the user to set and retrieve speed and duplex of the > virtio_net device via ethtool. Having this functionality is very helpful > for simulating

Re: [PATCH net-next] virtio_net: add ethtool support for set and get of settings

2016-02-02 Thread Nikolay Aleksandrov
On 02/02/2016 01:51 PM, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > This patch allows the user to set and retrieve speed and duplex of the > virtio_net device via ethtool. Having this functionality is very helpful > for simulating different

Re: [PATCH net-next] virtio_net: add ethtool support for set and get of settings

2016-02-02 Thread Nikolay Aleksandrov
On 02/02/2016 02:23 PM, Michael S. Tsirkin wrote: > On Tue, Feb 02, 2016 at 01:51:20PM +0100, Nikolay Aleksandrov wrote: >> From: Nikolay Aleksandrov >> >> This patch allows the user to set and retrieve speed and duplex of the >> virtio_net device via ethtool. Having

Re: [PATCH net-next] virtio_net: add ethtool support for set and get of settings

2016-02-02 Thread Michael S. Tsirkin
On Tue, Feb 02, 2016 at 02:52:30PM +0100, Nikolay Aleksandrov wrote: > On 02/02/2016 02:23 PM, Michael S. Tsirkin wrote: > > On Tue, Feb 02, 2016 at 01:51:20PM +0100, Nikolay Aleksandrov wrote: > >> From: Nikolay Aleksandrov > >> > >> This patch allows the user to set