Re: [PATCH net-next 03/21] ethtool, stats: introduce standard XDP statistics

2021-11-08 Thread Toke Høiland-Jørgensen
Alexander Lobakin writes: > From: Toke Høiland-Jørgensen > Date: Mon, 08 Nov 2021 12:37:54 +0100 > >> Alexander Lobakin writes: >> >> > From: Alexander Lobakin >> > Date: Tue, 26 Oct 2021 11:23:23 +0200 >> > >> >> From: Saeed Mahameed >> >> Date: Tue, 03 Aug 2021 16:57:22 -0700 >> >> >> >>

Re: [PATCH net-next 03/21] ethtool, stats: introduce standard XDP statistics

2021-11-08 Thread Toke Høiland-Jørgensen
Alexander Lobakin writes: > From: Alexander Lobakin > Date: Tue, 26 Oct 2021 11:23:23 +0200 > >> From: Saeed Mahameed >> Date: Tue, 03 Aug 2021 16:57:22 -0700 >> >> [ snip ] >> >> > XDP is going to always be eBPF based ! why not just report such stats >> > to a special BPF_MAP ? BPF stack

Re: [PATCH net-next 03/21] ethtool, stats: introduce standard XDP statistics

2021-08-04 Thread David Ahern
On 8/4/21 12:27 PM, Saeed Mahameed wrote: > >> I just ran some quick tests with my setup and measured about 1.2% >> worst > > 1.2% is a lot ! what was the test ? what is the change ? I did say "quick test ... not exhaustive" and it was definitely eyeballing a pps change over a small time

Re: [PATCH net-next 03/21] ethtool, stats: introduce standard XDP statistics

2021-08-04 Thread David Ahern
On 8/4/21 10:44 AM, Jakub Kicinski wrote: > On Wed, 4 Aug 2021 10:17:56 -0600 David Ahern wrote: >> On 8/4/21 6:36 AM, Jakub Kicinski wrote: XDP is going to always be eBPF based ! why not just report such stats to a special BPF_MAP ? BPF stack can collect the stats from the driver

Re: [PATCH net-next 03/21] ethtool, stats: introduce standard XDP statistics

2021-08-04 Thread David Ahern
On 8/4/21 6:36 AM, Jakub Kicinski wrote: >> XDP is going to always be eBPF based ! why not just report such stats >> to a special BPF_MAP ? BPF stack can collect the stats from the driver >> and report them to this special MAP upon user request. > Do you mean replacing the ethtool-netlink /