Re: [PATCH net-next 4/4] mlx4: sizeof style usage

2017-10-26 Thread Tariq Toukan
On 20/08/2017 9:00 PM, Stephen Hemminger wrote: Yes, good catch. OK, I will include a fix for this in my next series. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org

Re: [PATCH net-next 4/4] mlx4: sizeof style usage

2017-10-26 Thread Leon Romanovsky
On Tue, Aug 15, 2017 at 10:29:19AM -0700, Stephen Hemminger wrote: > The kernel coding style is to treat sizeof as a function > (ie. with parenthesis) not as an operator. > > Also use kcalloc and kmalloc_array > > Signed-off-by: Stephen Hemminger > --- >

RE: [PATCH net-next 4/4] mlx4: sizeof style usage

2017-08-20 Thread Stephen Hemminger via Virtualization
el.org; virtualization@lists.linux-foundation.org; Stephen Hemminger <sthem...@microsoft.com> Subject: Re: [PATCH net-next 4/4] mlx4: sizeof style usage [You don't often get email from tar...@mellanox.com. Learn why this is important at http://aka.ms/LearnAboutSenderIdentification.] Th

[PATCH net-next 4/4] mlx4: sizeof style usage

2017-08-15 Thread Stephen Hemminger
The kernel coding style is to treat sizeof as a function (ie. with parenthesis) not as an operator. Also use kcalloc and kmalloc_array Signed-off-by: Stephen Hemminger --- drivers/net/ethernet/mellanox/mlx4/alloc.c | 2 +-