On 20/08/2017 9:00 PM, Stephen Hemminger wrote:
Yes, good catch.
OK, I will include a fix for this in my next series.
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtua
Thanks Stephen.
Sorry for the late reply, I was on vacation.
I know this is already accepted, but still I have one comment.
On 15/08/2017 8:29 PM, Stephen Hemminger wrote:
The kernel coding style is to treat sizeof as a function
(ie. with parenthesis) not as an operator.
Also use kcalloc and km
On Tue, Aug 15, 2017 at 10:29:19AM -0700, Stephen Hemminger wrote:
> The kernel coding style is to treat sizeof as a function
> (ie. with parenthesis) not as an operator.
>
> Also use kcalloc and kmalloc_array
>
> Signed-off-by: Stephen Hemminger
> ---
> drivers/net/ethernet/mellanox/mlx4/alloc.c
@lists.linux-foundation.org; Stephen Hemminger
Subject: Re: [PATCH net-next 4/4] mlx4: sizeof style usage
[You don't often get email from tar...@mellanox.com. Learn why this is
important at http://aka.ms/LearnAboutSenderIdentification.]
Thanks Stephen.
Sorry for the late reply, I was on vacation.
I
The kernel coding style is to treat sizeof as a function
(ie. with parenthesis) not as an operator.
Also use kcalloc and kmalloc_array
Signed-off-by: Stephen Hemminger
---
drivers/net/ethernet/mellanox/mlx4/alloc.c | 2 +-
drivers/net/ethernet/mellanox/mlx4/cmd.c | 4 ++--
d