Re: [PATCH net-next v2] drivers: net: virtio_net: Implement a dev_watchdog handler

2019-11-24 Thread Jakub Kicinski
On Sun, 24 Nov 2019 18:29:49 -0500, Michael S. Tsirkin wrote: > netdev: pass the stuck queue to the timeout handler > > This allows incrementing the correct timeout statistic without any mess. > Down the road, devices can learn to reset just the specific queue. FWIW Acked-by: Jakub Kicinski

Re: [PATCH net-next v2] drivers: net: virtio_net: Implement a dev_watchdog handler

2019-11-24 Thread Jakub Kicinski
On Sun, 24 Nov 2019 16:48:35 -0500, Michael S. Tsirkin wrote: > diff --git a/arch/m68k/emu/nfeth.c b/arch/m68k/emu/nfeth.c > index a4ebd2445eda..8e06e7407854 100644 > --- a/arch/m68k/emu/nfeth.c > +++ b/arch/m68k/emu/nfeth.c > @@ -167,7 +167,7 @@ static int nfeth_xmit(struct sk_buff *skb, struct

Re: [PATCH net-next v2] drivers: net: virtio_net: Implement a dev_watchdog handler

2019-11-24 Thread Michael S. Tsirkin
On Sun, Nov 24, 2019 at 03:03:52PM -0800, Jakub Kicinski wrote: > On Sun, 24 Nov 2019 16:48:35 -0500, Michael S. Tsirkin wrote: > > diff --git a/arch/m68k/emu/nfeth.c b/arch/m68k/emu/nfeth.c > > index a4ebd2445eda..8e06e7407854 100644 > > --- a/arch/m68k/emu/nfeth.c > > +++ b/arch/m68k/emu/nfeth.c

Re: [PATCH net-next v2] drivers: net: virtio_net: Implement a dev_watchdog handler

2019-11-24 Thread Michael S. Tsirkin
On Sat, Nov 23, 2019 at 08:33:40PM -0200, Julio Faracco wrote: > > > > netdev: pass the stuck queue to the timeout handler > > > > This allows incrementing the correct timeout statistic without any mess. > > Down the road, devices can learn to reset just the specific queue. > > > > Signed-off-by:

[PATCH net-next v2] drivers: net: virtio_net: Implement a dev_watchdog handler

2019-11-21 Thread Julio Faracco
Driver virtio_net is not handling error events for TX provided by dev_watchdog. This event is reached when transmission queue is having problems to transmit packets. This could happen for any reason. To enable it, driver should have .ndo_tx_timeout implemented. This commit brings back