[PATCH net-next v4 5/6] lib: Ensure EWMA does not store wrong intermediate values

2014-01-16 Thread Michael Dalton
To ensure ewma_read() without a lock returns a valid but possibly out of date average, modify ewma_add() by using ACCESS_ONCE to prevent intermediate wrong values from being written to avg-internal. Suggested-by: Eric Dumazet eric.duma...@gmail.com Signed-off-by: Michael Dalton

Re: [PATCH net-next v4 5/6] lib: Ensure EWMA does not store wrong intermediate values

2014-01-16 Thread Eric Dumazet
On Thu, 2014-01-16 at 11:52 -0800, Michael Dalton wrote: To ensure ewma_read() without a lock returns a valid but possibly out of date average, modify ewma_add() by using ACCESS_ONCE to prevent intermediate wrong values from being written to avg-internal. Suggested-by: Eric Dumazet

Re: [PATCH net-next v4 5/6] lib: Ensure EWMA does not store wrong intermediate values

2014-01-16 Thread Michael S. Tsirkin
On Thu, Jan 16, 2014 at 11:52:29AM -0800, Michael Dalton wrote: To ensure ewma_read() without a lock returns a valid but possibly out of date average, modify ewma_add() by using ACCESS_ONCE to prevent intermediate wrong values from being written to avg-internal. Suggested-by: Eric Dumazet