Re: [PATCH net-next v6] virtio/vsock: replace virtio_vsock_pkt with sk_buff

2022-12-13 Thread Stefano Garzarella
On Tue, Dec 13, 2022 at 10:06:23AM -0500, Michael S. Tsirkin wrote: On Tue, Dec 13, 2022 at 11:22:32AM +0100, Stefano Garzarella wrote: > + if (len <= GOOD_COPY_LEN && !skb_queue_empty_lockless(&vvs->rx_queue)) { Same here. If there are no major changes to be made, I think the next version is

Re: [PATCH net-next v6] virtio/vsock: replace virtio_vsock_pkt with sk_buff

2022-12-13 Thread Michael S. Tsirkin
On Tue, Dec 13, 2022 at 11:22:32AM +0100, Stefano Garzarella wrote: > > + if (len <= GOOD_COPY_LEN && !skb_queue_empty_lockless(&vvs->rx_queue)) { > > Same here. > > If there are no major changes to be made, I think the next version is the > final ones, though we are now in the merge window, so

Re: [PATCH net-next v6] virtio/vsock: replace virtio_vsock_pkt with sk_buff

2022-12-13 Thread Stefano Garzarella
On Tue, Dec 13, 2022 at 07:25:49AM +, Bobby Eshleman wrote: This commit changes virtio/vsock to use sk_buff instead of virtio_vsock_pkt. Beyond better conforming to other net code, using sk_buff allows vsock to use sk_buff-dependent features in the future (such as sockmap) and improves throug