Re: [PATCH net v2] failover: allow name change on IFF_UP slave interfaces

2019-04-19 Thread Liran Alon
> On 21 Mar 2019, at 16:04, Michael S. Tsirkin wrote: > > On Wed, Mar 06, 2019 at 10:08:32PM -0500, Si-Wei Liu wrote: >> When a netdev appears through hot plug then gets enslaved by a failover >> master that is already up and running, the slave will be opened >> right away after getting enslave

Re: [PATCH net v2] failover: allow name change on IFF_UP slave interfaces

2019-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2019 at 04:20:40PM +0200, Liran Alon wrote: > > > > On 21 Mar 2019, at 16:04, Michael S. Tsirkin wrote: > > > > On Wed, Mar 06, 2019 at 10:08:32PM -0500, Si-Wei Liu wrote: > >> When a netdev appears through hot plug then gets enslaved by a failover > >> master that is already up

Re: [PATCH net v2] failover: allow name change on IFF_UP slave interfaces

2019-03-21 Thread Michael S. Tsirkin
On Wed, Mar 06, 2019 at 10:08:32PM -0500, Si-Wei Liu wrote: > When a netdev appears through hot plug then gets enslaved by a failover > master that is already up and running, the slave will be opened > right away after getting enslaved. Today there's a race that userspace > (udev) may fail to renam

Re: [PATCH net v2] failover: allow name change on IFF_UP slave interfaces

2019-03-20 Thread Samudrala, Sridhar
On 3/19/2019 10:20 PM, si-wei liu wrote: Hi Sridhar, Are you fine with leaving the IFF_SLAVE_RENAME_OK flag as is, and thus can provide your Ack-by or Reviewed-by? I can change the code if you feel strong. My preference would be not to introduce a new flag unless there is any usecase wher

Re: [PATCH net v2] failover: allow name change on IFF_UP slave interfaces

2019-03-06 Thread Samudrala, Sridhar
On 3/6/2019 7:08 PM, Si-Wei Liu wrote: When a netdev appears through hot plug then gets enslaved by a failover master that is already up and running, the slave will be opened right away after getting enslaved. Today there's a race that userspace (udev) may fail to rename the slave if the kernel